)]}'
{"tox.ini":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d4719b9f52ec66001d864d0c3c5fd46d06941770","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# W504 skipped since you must choose either W503 or W504 (they conflict)"},{"line_number":60,"context_line":"show-source \u003d True"},{"line_number":61,"context_line":"ignore \u003d E123,E125,W504"},{"line_number":62,"context_line":"builtins \u003d _"},{"line_number":63,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1fa4df85_3789bbc9","line":61,"range":{"start_line":61,"start_character":19,"end_line":61,"end_character":23},"updated":"2020-02-27 14:32:31.000000000","message":"I took this out and pep8 still passes. Am I missing something?","commit_id":"150b8ec1b20f59c85795380edc292144af10e4e7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71db491cb55d533e453a9d1e8dd2e79218aa4676","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# W504 skipped since you must choose either W503 or W504 (they conflict)"},{"line_number":60,"context_line":"show-source \u003d True"},{"line_number":61,"context_line":"ignore \u003d E123,E125,W504"},{"line_number":62,"context_line":"builtins \u003d _"},{"line_number":63,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1fa4df85_cabbdec1","line":61,"range":{"start_line":61,"start_character":19,"end_line":61,"end_character":23},"in_reply_to":"1fa4df85_3789bbc9","updated":"2020-02-27 15:07:13.000000000","message":"I stuck this in preemptively, since this seemed like something we\u0027d hit in the future and I\u0027d rather we did the same thing across all nova\u0027ish projects. Seem reasonable?","commit_id":"150b8ec1b20f59c85795380edc292144af10e4e7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3b065d621bc6aa236890538f10a6b6e5abb57554","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# W504 skipped since you must choose either W503 or W504 (they conflict)"},{"line_number":60,"context_line":"show-source \u003d True"},{"line_number":61,"context_line":"ignore \u003d E123,E125,W504"},{"line_number":62,"context_line":"builtins \u003d _"},{"line_number":63,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1fa4df85_8dbbc070","line":61,"range":{"start_line":61,"start_character":19,"end_line":61,"end_character":23},"in_reply_to":"1fa4df85_8aa2c64a","updated":"2020-02-27 15:58:59.000000000","message":"Done","commit_id":"150b8ec1b20f59c85795380edc292144af10e4e7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"df360930cdaa7baa248cd200f39fe0bb8963ea38","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# W504 skipped since you must choose either W503 or W504 (they conflict)"},{"line_number":60,"context_line":"show-source \u003d True"},{"line_number":61,"context_line":"ignore \u003d E123,E125,W504"},{"line_number":62,"context_line":"builtins \u003d _"},{"line_number":63,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1fa4df85_8aa2c64a","line":61,"range":{"start_line":61,"start_character":19,"end_line":61,"end_character":23},"in_reply_to":"1fa4df85_cabbdec1","updated":"2020-02-27 15:22:34.000000000","message":"I\u0027m gonna call YAGNI on this.\n\n \u003e I stuck this in preemptively, since this seemed like something we\u0027d\n \u003e hit in the future\n\nThat seems quite doubtful to me, considering the size and scope of this repo.\n\n \u003e and I\u0027d rather we did the same thing across all\n \u003e nova\u0027ish projects.\n\nos-traits is not a nova\u0027ish project.","commit_id":"150b8ec1b20f59c85795380edc292144af10e4e7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"abe34c97a746035fb48311f73f8d3f4c600b38db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"envlist \u003d py37,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"# Automatic envs (pyXX) will use the python version appropriate to that"},{"line_number":6,"context_line":"# env and ignore basepython inherited from [testenv]. That\u0027s what we"},{"line_number":7,"context_line":"# want, and we don\u0027t need to be warned about it."}],"source_content_type":"text/x-properties","patch_set":2,"id":"1fa4df85_2c2b8eeb","side":"PARENT","line":4,"updated":"2020-03-18 10:35:09.000000000","message":"Don\u0027t we need this any more?","commit_id":"b99ab3336ced15dc29c0175f91a34d76557737c6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25b95acedc4062dd8e51519e0a82f55fa4200a70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"envlist \u003d py37,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"# Automatic envs (pyXX) will use the python version appropriate to that"},{"line_number":6,"context_line":"# env and ignore basepython inherited from [testenv]. That\u0027s what we"},{"line_number":7,"context_line":"# want, and we don\u0027t need to be warned about it."}],"source_content_type":"text/x-properties","patch_set":2,"id":"1fa4df85_473a6598","side":"PARENT","line":4,"in_reply_to":"1fa4df85_2c2b8eeb","updated":"2020-03-18 11:10:24.000000000","message":"No. This is used to avoid \"expensive sdists\" [1], however, this isn\u0027t expensive and we don\u0027t do it in e.g. os-traits.\n\n[1] https://tox.readthedocs.io/en/latest/example/general.html#avoiding-expensive-sdist","commit_id":"b99ab3336ced15dc29c0175f91a34d76557737c6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"abe34c97a746035fb48311f73f8d3f4c600b38db","unresolved":false,"context_lines":[{"line_number":10,"context_line":"[testenv]"},{"line_number":11,"context_line":"basepython \u003d python3"},{"line_number":12,"context_line":"usedevelop \u003d True"},{"line_number":13,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d"},{"line_number":15,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"   PYTHONWARNINGS\u003ddefault::DeprecationWarning"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1fa4df85_0c033275","side":"PARENT","line":13,"updated":"2020-03-18 10:35:09.000000000","message":"is this the default now?","commit_id":"b99ab3336ced15dc29c0175f91a34d76557737c6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25b95acedc4062dd8e51519e0a82f55fa4200a70","unresolved":false,"context_lines":[{"line_number":10,"context_line":"[testenv]"},{"line_number":11,"context_line":"basepython \u003d python3"},{"line_number":12,"context_line":"usedevelop \u003d True"},{"line_number":13,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d"},{"line_number":15,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"   PYTHONWARNINGS\u003ddefault::DeprecationWarning"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1fa4df85_2784095e","side":"PARENT","line":13,"in_reply_to":"1fa4df85_0c033275","updated":"2020-03-18 11:10:24.000000000","message":"Yes, it always has been. I suspect this was a hangover from when we configured constraints via this option instead of passing it into \u0027[testenv] deps\u0027","commit_id":"b99ab3336ced15dc29c0175f91a34d76557737c6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"abe34c97a746035fb48311f73f8d3f4c600b38db","unresolved":false,"context_lines":[{"line_number":13,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d"},{"line_number":15,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"   PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":17,"context_line":"   OS_STDOUT_CAPTURE\u003d1"},{"line_number":18,"context_line":"   OS_STDERR_CAPTURE\u003d1"},{"line_number":19,"context_line":"   OS_TEST_TIMEOUT\u003d60"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1fa4df85_4c2e0afb","side":"PARENT","line":16,"updated":"2020-03-18 10:35:09.000000000","message":"Don\u0027t we need this any more?","commit_id":"b99ab3336ced15dc29c0175f91a34d76557737c6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25b95acedc4062dd8e51519e0a82f55fa4200a70","unresolved":false,"context_lines":[{"line_number":13,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d"},{"line_number":15,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"   PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":17,"context_line":"   OS_STDOUT_CAPTURE\u003d1"},{"line_number":18,"context_line":"   OS_STDERR_CAPTURE\u003d1"},{"line_number":19,"context_line":"   OS_TEST_TIMEOUT\u003d60"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1fa4df85_a7c55990","side":"PARENT","line":16,"in_reply_to":"1fa4df85_4c2e0afb","updated":"2020-03-18 11:10:24.000000000","message":"Actually, yeah, we probably do","commit_id":"b99ab3336ced15dc29c0175f91a34d76557737c6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b9fe803a8dcd17bbafee61b1305a7ff05fdf425","unresolved":false,"context_lines":[{"line_number":13,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":14,"context_line":"setenv \u003d"},{"line_number":15,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":16,"context_line":"   PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":17,"context_line":"   OS_STDOUT_CAPTURE\u003d1"},{"line_number":18,"context_line":"   OS_STDERR_CAPTURE\u003d1"},{"line_number":19,"context_line":"   OS_TEST_TIMEOUT\u003d60"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1fa4df85_a72479c7","side":"PARENT","line":16,"in_reply_to":"1fa4df85_a7c55990","updated":"2020-03-18 11:47:52.000000000","message":"Nope, we don\u0027t because there are no dependencies in this package and therefore no deprecations to warn about","commit_id":"b99ab3336ced15dc29c0175f91a34d76557737c6"}]}