)]}'
{"os_testr/os_testr.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"85bea99356a177d464a667af12335689625ee9e1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        if exclude_regex:"},{"line_number":133,"context_line":"            exclude_regex \u003d \"\u0027(?!.*\" + exclude_regex + \")\""},{"line_number":134,"context_line":"    if regex:"},{"line_number":135,"context_line":"        if regex.find(\u0027/\u0027) !\u003d -1:"},{"line_number":136,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":137,"context_line":"            regex \u003d regex.replace(\u0027/\u0027, \u0027.\u0027)"},{"line_number":138,"context_line":"        exclude_regex +\u003d regex"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_f94c5078","line":135,"updated":"2015-07-19 14:31:20.000000000","message":"Could maybe call os.path.exists here instead, but this is faster.  I don\u0027t think any valid regex would contain a \u0027/\u0027","commit_id":"a17bc7d8c8aa0b50c983dbeb0c01293c6a1f9933"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c248010f1e8abf7c282f8a43f6147da9ebab284e","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if exclude_regex:"},{"line_number":134,"context_line":"            exclude_regex \u003d \"\u0027(?!.*\" + exclude_regex + \")\""},{"line_number":135,"context_line":"    if regex:"},{"line_number":136,"context_line":"        if regex.find(\u0027/\u0027) !\u003d -1:"},{"line_number":137,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":138,"context_line":"            regex \u003d regex.replace(\u0027/\u0027, \u0027.\u0027)"},{"line_number":139,"context_line":"        exclude_regex +\u003d regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_99284187","line":136,"updated":"2015-08-01 05:18:13.000000000","message":"use os.sep instead?","commit_id":"fe722c946f3939adbfefe71c82f2ceda48c562cd"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c248010f1e8abf7c282f8a43f6147da9ebab284e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if regex:"},{"line_number":136,"context_line":"        if regex.find(\u0027/\u0027) !\u003d -1:"},{"line_number":137,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":138,"context_line":"            regex \u003d regex.replace(\u0027/\u0027, \u0027.\u0027)"},{"line_number":139,"context_line":"        exclude_regex +\u003d regex"},{"line_number":140,"context_line":"    return exclude_regex"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_391fad5c","line":138,"updated":"2015-08-01 05:18:13.000000000","message":"use os.sep instead","commit_id":"fe722c946f3939adbfefe71c82f2ceda48c562cd"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"64092f467e4858d8af2e19e08006ab06269b06f9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if exclude_regex:"},{"line_number":134,"context_line":"            exclude_regex \u003d \"\u0027(?!.*\" + exclude_regex + \")\""},{"line_number":135,"context_line":"    if regex:"},{"line_number":136,"context_line":"        if regex.find(os.sep) !\u003d -1:"},{"line_number":137,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":138,"context_line":"            regex \u003d regex.replace(os.sep, \u0027.\u0027)"},{"line_number":139,"context_line":"        exclude_regex +\u003d regex"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_ac0cbded","line":136,"updated":"2015-08-05 19:31:07.000000000","message":"What if the regex has a \u0027/\u0027 in it on a unix system? Won\u0027t this match and try to convert it ?","commit_id":"1b88d38a8024e1046cde6ec66ea60b5b62f11281"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"66d2e7ae1da56459e4838666dee1fd6e2b0be52e","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if exclude_regex:"},{"line_number":134,"context_line":"            exclude_regex \u003d \"\u0027(?!.*\" + exclude_regex + \")\""},{"line_number":135,"context_line":"    if regex:"},{"line_number":136,"context_line":"        if regex.find(os.sep) !\u003d -1:"},{"line_number":137,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":138,"context_line":"            regex \u003d regex.replace(os.sep, \u0027.\u0027)"},{"line_number":139,"context_line":"        exclude_regex +\u003d regex"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_f767eeb4","line":136,"in_reply_to":"1a4dcd0f_6cd475bc","updated":"2015-08-05 20:03:17.000000000","message":"But / is not a special character within a regular expression those would be characters like [\\^$.|?*+()\n\nAlternatively, I could add a --file option.","commit_id":"1b88d38a8024e1046cde6ec66ea60b5b62f11281"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7e48dc38b1e7528deddd216cd75c619b9f75bd5c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if exclude_regex:"},{"line_number":134,"context_line":"            exclude_regex \u003d \"\u0027(?!.*\" + exclude_regex + \")\""},{"line_number":135,"context_line":"    if regex:"},{"line_number":136,"context_line":"        if regex.find(os.sep) !\u003d -1:"},{"line_number":137,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":138,"context_line":"            regex \u003d regex.replace(os.sep, \u0027.\u0027)"},{"line_number":139,"context_line":"        exclude_regex +\u003d regex"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_6cd475bc","line":136,"in_reply_to":"1a4dcd0f_8c91c149","updated":"2015-08-05 19:45:40.000000000","message":"The regex filter is much more than just listing a python class or method though, it\u0027s any regex which then gets matched to all the test_ids. Granted having a / in the regex would probably be a bit weird. The test_id also isn\u0027t only just a the python class or method, any attrs or scenarios get appended to it automagically (which I view as a bug in testr/subunit, but that\u0027s a separate discussion) There definitely isn\u0027t a rule saying that a \u0027/\u0027 can\u0027t be in an attribute, it\u0027s just a string. That\u0027s why I\u0027m worried about this being the check for doing this conversion.\n\nAlso, fwiw I normally recomend using --no-discover if you\u0027re trying to run a specific module, class, or method because it only runs discovery once instead of 1 + concurrency. The downside is that it serialized of course.","commit_id":"1b88d38a8024e1046cde6ec66ea60b5b62f11281"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"3de9793e39095e35cd4ce4fa8dc3f058095af905","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if exclude_regex:"},{"line_number":134,"context_line":"            exclude_regex \u003d \"\u0027(?!.*\" + exclude_regex + \")\""},{"line_number":135,"context_line":"    if regex:"},{"line_number":136,"context_line":"        if regex.find(os.sep) !\u003d -1:"},{"line_number":137,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":138,"context_line":"            regex \u003d regex.replace(os.sep, \u0027.\u0027)"},{"line_number":139,"context_line":"        exclude_regex +\u003d regex"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_8c91c149","line":136,"in_reply_to":"1a4dcd0f_ac0cbded","updated":"2015-08-05 19:36:18.000000000","message":"I don\u0027t think that is possible because a file or directory could not contain a \u0027/\u0027.\n\nA python class or method could not contain a \u0027/\u0027 either:\nhttps://docs.python.org/2/reference/lexical_analysis.html#identifiers","commit_id":"1b88d38a8024e1046cde6ec66ea60b5b62f11281"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"1042b7cb349e9f4e5547a6da49d14c7848b039ef","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if exclude_regex:"},{"line_number":134,"context_line":"            exclude_regex \u003d \"\u0027(?!.*\" + exclude_regex + \")\""},{"line_number":135,"context_line":"    if regex:"},{"line_number":136,"context_line":"        if regex.find(os.sep) !\u003d -1:"},{"line_number":137,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":138,"context_line":"            regex \u003d regex.replace(os.sep, \u0027.\u0027)"},{"line_number":139,"context_line":"        exclude_regex +\u003d regex"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_5cce0283","line":136,"in_reply_to":"1a4dcd0f_d253e0e0","updated":"2015-08-05 22:24:35.000000000","message":"Well, I\u0027m trying to understand your use case a bit more.\n\n--no-discover requires an explicit python module path, because that gets passed right to the test runner so discovery isn\u0027t being run. This makes it faster to start, but the actual execution is serialized which is the tradeoff there. So if you\u0027re looking to run things in parallel having a new --file option is fine, but if serialized is fine then maybe do the conversion like here, but only on the no-dscover param, because having a / on the input there is invalid.\n\nOr probably just doing both would be the best of both worlds.","commit_id":"1b88d38a8024e1046cde6ec66ea60b5b62f11281"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"11db6c36a1f40cf430c7daa4fc328234031bba24","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if exclude_regex:"},{"line_number":134,"context_line":"            exclude_regex \u003d \"\u0027(?!.*\" + exclude_regex + \")\""},{"line_number":135,"context_line":"    if regex:"},{"line_number":136,"context_line":"        if regex.find(os.sep) !\u003d -1:"},{"line_number":137,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":138,"context_line":"            regex \u003d regex.replace(os.sep, \u0027.\u0027)"},{"line_number":139,"context_line":"        exclude_regex +\u003d regex"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_f7712e45","line":136,"in_reply_to":"1a4dcd0f_f767eeb4","updated":"2015-08-05 20:08:55.000000000","message":"Sure, I realize that, but if the test_ids aren\u0027t strictly python paths I don\u0027t think we can guarantee that / will only ever be passed in as part of the regex if it\u0027s selecting by file.\n\nI think making it a separate file flag would be better approach, although how does that differ from the --no-discover option? (well assuming we added the path conversion there)","commit_id":"1b88d38a8024e1046cde6ec66ea60b5b62f11281"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"2a0457577aac1b96cbb3cd491e24c93db24c8e68","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        if exclude_regex:"},{"line_number":134,"context_line":"            exclude_regex \u003d \"\u0027(?!.*\" + exclude_regex + \")\""},{"line_number":135,"context_line":"    if regex:"},{"line_number":136,"context_line":"        if regex.find(os.sep) !\u003d -1:"},{"line_number":137,"context_line":"            regex, _ \u003d os.path.splitext(regex)"},{"line_number":138,"context_line":"            regex \u003d regex.replace(os.sep, \u0027.\u0027)"},{"line_number":139,"context_line":"        exclude_regex +\u003d regex"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_d253e0e0","line":136,"in_reply_to":"1a4dcd0f_f7712e45","updated":"2015-08-05 20:30:04.000000000","message":"Hmm, --no-discover will not support directories.  Which ever you want though, I could live with just file names.","commit_id":"1b88d38a8024e1046cde6ec66ea60b5b62f11281"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"919a2c74988333236de53c8f6f1af8ccfdf29e88","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    parser.add_argument(\u0027--blacklist_file\u0027, \u0027-b\u0027,"},{"line_number":30,"context_line":"                        help\u003d\u0027Path to a blacklist file, this file contains a\u0027"},{"line_number":31,"context_line":"                             \u0027 separate regex exclude on each newline\u0027)"},{"line_number":32,"context_line":"    group \u003d parser.add_mutually_exclusive_group()"},{"line_number":33,"context_line":"    group.add_argument(\u0027--regex\u0027, \u0027-r\u0027,"},{"line_number":34,"context_line":"                       help\u003d\u0027A normal testr selection regex. If a blacklist \u0027"},{"line_number":35,"context_line":"                            \u0027file is specified, the regex will be appended \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_75c2beea","line":32,"updated":"2015-08-06 21:52:18.000000000","message":"Man, I need to read the docs better, I was doing this by hand in main()","commit_id":"aee3402c6815f6620f23125f786cbd972ae16ae4"}],"os_testr/tests/test_os_testr.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"68e790f5f06e11905825fa0acc91a19973416733","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \"openstack.tests.unit.network.v2.test_network\", result)"},{"line_number":33,"context_line":"        result \u003d os_testr.construct_regex("},{"line_number":34,"context_line":"            None, \"openstack/tests/unit/network/v2\", False)"},{"line_number":35,"context_line":"        self.assertEqual("},{"line_number":36,"context_line":"            \"openstack.tests.unit.network.v2\", result)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_193511da","line":35,"updated":"2015-08-01 05:19:51.000000000","message":"this could fit on one line","commit_id":"fe722c946f3939adbfefe71c82f2ceda48c562cd"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"919a2c74988333236de53c8f6f1af8ccfdf29e88","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from os_testr.tests import base"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class Test_Construct_Regex(base.TestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_file_name(self):"},{"line_number":29,"context_line":"        result \u003d os_testr.path_to_regex(\"tests/network/v2/test_net.py\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_f8700374","line":26,"updated":"2015-08-06 21:52:18.000000000","message":"Normally these are camelcase, I don\u0027t know why","commit_id":"aee3402c6815f6620f23125f786cbd972ae16ae4"}]}
