)]}'
{"os_testr/os_testr.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c46a2f346de4e9e13ccc592ab06b946b46bd0fcd","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    testtools_run.main([sys.argv[0], test_id], sys.stdout)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def process_opts():"},{"line_number":244,"context_line":"    return get_parser().parse_args()"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_9305867b","line":243,"updated":"2015-09-28 15:47:46.000000000","message":"Maybe we should just combine this with the get_parser() function. It seems kinda weird to split it like this when all we\u0027re doing is calling one method on the parser object here.","commit_id":"cc4afd15b7e1919c594f09d455448fa763502c54"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"aa69bf0fc7358be74948169213f8c9432966859b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    testtools_run.main([sys.argv[0], test_id], sys.stdout)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def process_opts():"},{"line_number":244,"context_line":"    return get_parser().parse_args()"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_b6519810","line":243,"in_reply_to":"9a1a9d01_9305867b","updated":"2015-09-28 15:57:04.000000000","message":"Yeah, it\u0027s kinda goofy, but I was being lazy; since we use the parser object from get_parser to feed back into the libraries parse_args method it was sort of a pain to fake this out.\n\nI moved it like this so I could just fake this one method out in the tests and get the whole deal without a lot of fuss.  I\u0027m happy to revisit later, or if it\u0027s a big deal I can change it now.","commit_id":"cc4afd15b7e1919c594f09d455448fa763502c54"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"2805eb5dece86832e96d10e4f8cd1f90457a726b","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        if test_to_run.find(\u0027/\u0027) !\u003d -1:"},{"line_number":285,"context_line":"            test_to_run \u003d path_to_regex(test_to_run)"},{"line_number":286,"context_line":"        ret \u003d call_subunit_run(opts.no_discover, opts.pretty, opts.subunit)"},{"line_number":287,"context_line":"    exit(ret)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":290,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_5ae39f33","line":287,"updated":"2015-09-27 13:09:43.000000000","message":"Definitely an improvement, but if all this code was pulled out of main, you could skip the fake_exit thing.","commit_id":"cc4afd15b7e1919c594f09d455448fa763502c54"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ad1ff37722fd7452b9513fb416c1fe8898e6ad94","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        if test_to_run.find(\u0027/\u0027) !\u003d -1:"},{"line_number":285,"context_line":"            test_to_run \u003d path_to_regex(test_to_run)"},{"line_number":286,"context_line":"        ret \u003d call_subunit_run(opts.no_discover, opts.pretty, opts.subunit)"},{"line_number":287,"context_line":"    exit(ret)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":290,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_bad19bcf","line":287,"in_reply_to":"9a1a9d01_5ae39f33","updated":"2015-09-27 14:50:16.000000000","message":"So maybe  like everything from 273 on pulled out into another method that takes opts as an arg?  Then just use the return from that method for the exit?\n\nI kinda like that, and it makes  things a bit more readable.  I\u0027ll look at proposing that as an update to this, thanks!","commit_id":"cc4afd15b7e1919c594f09d455448fa763502c54"}]}