)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"309ac4443207b4b965c1c2430091ee50e73c9a20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02b52130_b0501469","updated":"2023-08-10 19:46:01.000000000","message":"this is very old change and not sure if this is still needed. I am cleaning up the old reviews if there are some interesting one left out.\n\nI also think for success case, we should add new flag instead of using the failure-debug flag. \n\nI will leave this change open for a week or so otherwise abandon which can be restore anytime","commit_id":"ae053a5d3c8df652998e88bfa014ed12121593a6"}],"os_testr/subunit_trace.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"bc397ba26450c7a17aa7cb78ab28c1e968b2c1cf","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":323,"context_line":"    parser.add_argument(\u0027--version\u0027, action\u003d\u0027version\u0027,"},{"line_number":324,"context_line":"                        version\u003d\u0027%s\u0027 % __version__)"},{"line_number":325,"context_line":"    parser.add_argument(\u0027--no-failure-debug\u0027, \u0027-n\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":326,"context_line":"                        dest\u003d\u0027print_failures\u0027, help\u003d\u0027Disable printing failure \u0027"},{"line_number":327,"context_line":"                        \u0027debug information in realtime\u0027)"},{"line_number":328,"context_line":"    parser.add_argument(\u0027--fails\u0027, \u0027-f\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":329,"context_line":"                        dest\u003d\u0027post_fails\u0027, help\u003d\u0027Print failure debug \u0027"},{"line_number":330,"context_line":"                        \u0027information after the stream is proccesed\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_5e0a4521","line":327,"range":{"start_line":325,"start_character":0,"end_line":327,"end_character":56},"updated":"2016-06-17 09:02:38.000000000","message":"If we handle this for success as well, I guess the name of the parameter and description are not matching anymore?","commit_id":"ae053a5d3c8df652998e88bfa014ed12121593a6"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"2777e7b97ce5ad5e2ea9be4125085247a8d81d73","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":323,"context_line":"    parser.add_argument(\u0027--version\u0027, action\u003d\u0027version\u0027,"},{"line_number":324,"context_line":"                        version\u003d\u0027%s\u0027 % __version__)"},{"line_number":325,"context_line":"    parser.add_argument(\u0027--no-failure-debug\u0027, \u0027-n\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":326,"context_line":"                        dest\u003d\u0027print_failures\u0027, help\u003d\u0027Disable printing failure \u0027"},{"line_number":327,"context_line":"                        \u0027debug information in realtime\u0027)"},{"line_number":328,"context_line":"    parser.add_argument(\u0027--fails\u0027, \u0027-f\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":329,"context_line":"                        dest\u003d\u0027post_fails\u0027, help\u003d\u0027Print failure debug \u0027"},{"line_number":330,"context_line":"                        \u0027information after the stream is proccesed\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_ca07661a","line":327,"range":{"start_line":325,"start_character":0,"end_line":327,"end_character":56},"in_reply_to":"5a9d85d2_e53671b3","updated":"2017-03-02 16:16:47.000000000","message":"Uhm in my understanding this option is about enabling or disabling printing attachment in case of failed tests (failure-debug). \nWith this change the same flag will enable/disable printing attachment also in case of success or xfail.","commit_id":"ae053a5d3c8df652998e88bfa014ed12121593a6"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"183a40109092d356ae588a3511df9b682c38e39d","unresolved":false,"context_lines":[{"line_number":322,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":323,"context_line":"    parser.add_argument(\u0027--version\u0027, action\u003d\u0027version\u0027,"},{"line_number":324,"context_line":"                        version\u003d\u0027%s\u0027 % __version__)"},{"line_number":325,"context_line":"    parser.add_argument(\u0027--no-failure-debug\u0027, \u0027-n\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":326,"context_line":"                        dest\u003d\u0027print_failures\u0027, help\u003d\u0027Disable printing failure \u0027"},{"line_number":327,"context_line":"                        \u0027debug information in realtime\u0027)"},{"line_number":328,"context_line":"    parser.add_argument(\u0027--fails\u0027, \u0027-f\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":329,"context_line":"                        dest\u003d\u0027post_fails\u0027, help\u003d\u0027Print failure debug \u0027"},{"line_number":330,"context_line":"                        \u0027information after the stream is proccesed\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_e53671b3","line":327,"range":{"start_line":325,"start_character":0,"end_line":327,"end_character":56},"in_reply_to":"7aa08908_5e0a4521","updated":"2016-06-20 02:34:21.000000000","message":"I don\u0027t think so. I think this option is for disabling to print debug information to the stream. So I feel there\u0027s no inconsistency in this option and description at this time.","commit_id":"ae053a5d3c8df652998e88bfa014ed12121593a6"}]}
