)]}'
{"os_testr/ostestr.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"7c746b1d768a1aceff9245a63da7169e0144b72b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    group \u003d parser.add_mutually_exclusive_group()"},{"line_number":46,"context_line":"    group.add_argument(\u0027--regex\u0027, \u0027-r\u0027,"},{"line_number":47,"context_line":"                       help\u003d\u0027A normal testr selection regex. If a blacklist \u0027"},{"line_number":48,"context_line":"                            \u0027or whitelist file is specified, the regex will \u0027"},{"line_number":49,"context_line":"                            \u0027be appended to the end of the generated regex \u0027"},{"line_number":50,"context_line":"                            \u0027from that file.\u0027)"},{"line_number":51,"context_line":"    group.add_argument(\u0027--path\u0027, metavar\u003d\u0027FILE_OR_DIRECTORY\u0027,"},{"line_number":52,"context_line":"                       help\u003d\u0027A file name or directory of tests to run.\u0027)"},{"line_number":53,"context_line":"    group.add_argument(\u0027--no-discover\u0027, \u0027-n\u0027, metavar\u003d\u0027TEST_ID\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_2ddcff44","line":50,"range":{"start_line":48,"start_character":65,"end_line":50,"end_character":43},"updated":"2016-06-27 06:53:53.000000000","message":"So, I think there\u0027s a difference between blacklist and whitelist ones.\nIn a black list, the regex will just be appended to the end. But in a white list, the regex will be appended with \u0027|\u0027, right?","commit_id":"197f211d7c185ec7d1ecb114139751195a311921"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"13cc113b239ad978d2bebb82801e5a0561b16f39","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    group \u003d parser.add_mutually_exclusive_group()"},{"line_number":46,"context_line":"    group.add_argument(\u0027--regex\u0027, \u0027-r\u0027,"},{"line_number":47,"context_line":"                       help\u003d\u0027A normal testr selection regex. If a blacklist \u0027"},{"line_number":48,"context_line":"                            \u0027or whitelist file is specified, the regex will \u0027"},{"line_number":49,"context_line":"                            \u0027be appended to the end of the generated regex \u0027"},{"line_number":50,"context_line":"                            \u0027from that file.\u0027)"},{"line_number":51,"context_line":"    group.add_argument(\u0027--path\u0027, metavar\u003d\u0027FILE_OR_DIRECTORY\u0027,"},{"line_number":52,"context_line":"                       help\u003d\u0027A file name or directory of tests to run.\u0027)"},{"line_number":53,"context_line":"    group.add_argument(\u0027--no-discover\u0027, \u0027-n\u0027, metavar\u003d\u0027TEST_ID\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b258d1fb","line":50,"range":{"start_line":48,"start_character":65,"end_line":50,"end_character":43},"in_reply_to":"3aaa91ec_2ddcff44","updated":"2016-06-29 02:12:31.000000000","message":"DOne","commit_id":"197f211d7c185ec7d1ecb114139751195a311921"}],"os_testr/regex_builder.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"51deefb98bf3cf213d45317983f4945d43d4d68e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    if regex:"},{"line_number":99,"context_line":"        exclude_regex +\u003d regex"},{"line_number":100,"context_line":"    if whitelist_file:"},{"line_number":101,"context_line":"        if exclude_regex:"},{"line_number":102,"context_line":"            exclude_regex +\u003d \u0027|\u0027"},{"line_number":103,"context_line":"        exclude_regex +\u003d \u0027%s\u0027 % get_regex_from_whitelist_file(whitelist_file)"},{"line_number":104,"context_line":"    return exclude_regex"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_aad93c59","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":32},"updated":"2016-06-24 07:23:44.000000000","message":"I like this change itself. But I feel this is different behavior from blacklist_file one. (But yeah, I think it\u0027s difficult to change the blacklist one like this, though.)\n\nIf we change like this, I feel the help message or a document should be updated at least.","commit_id":"8ec1bb55d3b33c0090c522eba70cd6d66a8160c9"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"7c746b1d768a1aceff9245a63da7169e0144b72b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    elif whitelist_file:"},{"line_number":98,"context_line":"        constructed_regex \u003d (\u0027%s\u0027 %"},{"line_number":99,"context_line":"                             get_regex_from_whitelist_file(whitelist_file))"},{"line_number":100,"context_line":"        if regex:"},{"line_number":101,"context_line":"            constructed_regex +\u003d \u0027|\u0027"},{"line_number":102,"context_line":"    if regex:"},{"line_number":103,"context_line":"        constructed_regex +\u003d regex"},{"line_number":104,"context_line":"    return constructed_regex"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_4d706b72","line":101,"range":{"start_line":100,"start_character":0,"end_line":101,"end_character":36},"updated":"2016-06-27 06:53:53.000000000","message":"This appending is different from blacklist_file\u0027s behavior. So I think we should write a document/help about this difference.","commit_id":"197f211d7c185ec7d1ecb114139751195a311921"}]}