)]}'
{"os_testr/ostestr.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6e17b44ca171a0d528f774c6228172cce8294adb","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        test_file \u003d os.fdopen(test_fd, \u0027w\u0027)"},{"line_number":122,"context_line":"        test_file.write(\u0027\\n\u0027.join(list_of_tests) + \u0027\\n\u0027)"},{"line_number":123,"context_line":"        test_file.close()"},{"line_number":124,"context_line":"        cmd.extend((\u0027--load-list\u0027, test_file_name))"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        cmd.append(regex)"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_e2118a53","line":124,"updated":"2016-08-17 21:59:18.000000000","message":"I wish testr exposed an interface where we didn\u0027t have to make a temp file. But I guess there isn\u0027t any other option here","commit_id":"69c9e9fa299ea27e401ac57df638d65b0840b8c7"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6e17b44ca171a0d528f774c6228172cce8294adb","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        exit(5)"},{"line_number":267,"context_line":"    if ((opts.pdb or opts.no_discover) and"},{"line_number":268,"context_line":"            (opts.blacklist_file or opts.whitelist_file)):"},{"line_number":269,"context_line":"        msg \u003d \"You can not use blacklist or whitelist with pdb or no-discover\""},{"line_number":270,"context_line":"        print(msg)"},{"line_number":271,"context_line":"        exit(6)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_421dfe64","line":269,"updated":"2016-08-17 21:59:18.000000000","message":"This is a good condition to check, although not really related to this change. It was outlined in the docs implicitly but I agrree better to add a check for it. I think we should do it as a separate patch maybe","commit_id":"69c9e9fa299ea27e401ac57df638d65b0840b8c7"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"3c5eb5129980a551b13f4035787c607a77364abd","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        exit(5)"},{"line_number":267,"context_line":"    if ((opts.pdb or opts.no_discover) and"},{"line_number":268,"context_line":"            (opts.blacklist_file or opts.whitelist_file)):"},{"line_number":269,"context_line":"        msg \u003d \"You can not use blacklist or whitelist with pdb or no-discover\""},{"line_number":270,"context_line":"        print(msg)"},{"line_number":271,"context_line":"        exit(6)"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_72dcd412","line":269,"in_reply_to":"3ac371cc_421dfe64","updated":"2016-09-06 08:39:04.000000000","message":"https://review.openstack.org/#/c/363739/","commit_id":"69c9e9fa299ea27e401ac57df638d65b0840b8c7"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4b37d51d6f2ec49d652195210da44a4d6d38efda","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    if not opts.no_discover and not opts.pdb:"},{"line_number":219,"context_line":"        ec \u003d call_testr(exclude_regex, opts.subunit, opts.pretty, opts.list,"},{"line_number":220,"context_line":"                        opts.slowest, opts.parallel, opts.concurrency,"},{"line_number":221,"context_line":"                        opts.until_failure, opts.color, None, others)"},{"line_number":222,"context_line":"    else:"},{"line_number":223,"context_line":"        if others:"},{"line_number":224,"context_line":"            print(\u0027Unexpected arguments: \u0027 + \u0027 \u0027.join(others))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_543cf7e1","line":221,"updated":"2016-09-15 16:05:46.000000000","message":"Heh, makes me wonder why you didn\u0027t just put list_of_tests at the end","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e401ab4040ac63bada06d996a2c8649c9c9d3435","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    if not opts.no_discover and not opts.pdb:"},{"line_number":219,"context_line":"        ec \u003d call_testr(exclude_regex, opts.subunit, opts.pretty, opts.list,"},{"line_number":220,"context_line":"                        opts.slowest, opts.parallel, opts.concurrency,"},{"line_number":221,"context_line":"                        opts.until_failure, opts.color, None, others)"},{"line_number":222,"context_line":"    else:"},{"line_number":223,"context_line":"        if others:"},{"line_number":224,"context_line":"            print(\u0027Unexpected arguments: \u0027 + \u0027 \u0027.join(others))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_7b75f12f","line":221,"in_reply_to":"7a8ec9b2_543cf7e1","updated":"2016-09-19 09:00:25.000000000","message":"other semed to the always last argument, it\u0027s named \u0027others \u0027 .","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4b37d51d6f2ec49d652195210da44a4d6d38efda","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    return ec"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def _call_testr_with_list(opts, test_list, others):"},{"line_number":234,"context_line":"    ec \u003d 1"},{"line_number":235,"context_line":"    _ensure_testr()"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_743f33d6","line":233,"updated":"2016-09-15 16:05:46.000000000","message":"Why do we need to split this into a separate function. It looks liek this is the same as _select_and_call_runner() except it takes a test list isntead of a regex. But that is just a kwarg for call_testr() so why not just pass it in to a single function?","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e401ab4040ac63bada06d996a2c8649c9c9d3435","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    return ec"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"def _call_testr_with_list(opts, test_list, others):"},{"line_number":234,"context_line":"    ec \u003d 1"},{"line_number":235,"context_line":"    _ensure_testr()"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_3b29a9e6","line":233,"in_reply_to":"7a8ec9b2_743f33d6","updated":"2016-09-19 09:00:25.000000000","message":"Originally I wanted to write to it lite differently, some cleanup is needed here at the end of the series anyway, logic will change a little.","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"}],"os_testr/testlist_builder.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4b37d51d6f2ec49d652195210da44a4d6d38efda","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        line_regex \u003d split_line[0].strip()"},{"line_number":27,"context_line":"        if len(split_line) \u003e 1:"},{"line_number":28,"context_line":"            # After the # is a comment"},{"line_number":29,"context_line":"            comment \u003d split_line[1].strip()"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            comment \u003d \u0027Skipped because of regex %s:\u0027 % line_regex"},{"line_number":32,"context_line":"        if not line_regex:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_94267fcc","line":29,"updated":"2016-09-15 16:05:46.000000000","message":"This should probably be split_line[1:] just i ncase there is a # in the comment (it would be a bit weird, but still)","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e401ab4040ac63bada06d996a2c8649c9c9d3435","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        line_regex \u003d split_line[0].strip()"},{"line_number":27,"context_line":"        if len(split_line) \u003e 1:"},{"line_number":28,"context_line":"            # After the # is a comment"},{"line_number":29,"context_line":"            comment \u003d split_line[1].strip()"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            comment \u003d \u0027Skipped because of regex %s:\u0027 % line_regex"},{"line_number":32,"context_line":"        if not line_regex:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_db7e05e3","line":29,"in_reply_to":"7a8ec9b2_94267fcc","updated":"2016-09-19 09:00:25.000000000","message":"good catch.","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4b37d51d6f2ec49d652195210da44a4d6d38efda","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def construct_list(blacklist_file, whitelist_file, regex, print_exclude):"},{"line_number":46,"context_line":"    \"\"\"Filters the discovered test cases"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @retrun: iterable of strings. The strings are full"},{"line_number":49,"context_line":"        test cases names, including tags like.:"},{"line_number":50,"context_line":"        \"project.api.TestClass.test_case[positive]\""},{"line_number":51,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_b421bbb6","line":48,"updated":"2016-09-15 16:05:46.000000000","message":"Let\u0027s use the standard restructured text format here, so:\n\n  :return: Iterator of test id strings\n\nor something like that. We probably should also add an autodoc module to the doc source so we include this in api documentation","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e401ab4040ac63bada06d996a2c8649c9c9d3435","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def construct_list(blacklist_file, whitelist_file, regex, print_exclude):"},{"line_number":46,"context_line":"    \"\"\"Filters the discovered test cases"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @retrun: iterable of strings. The strings are full"},{"line_number":49,"context_line":"        test cases names, including tags like.:"},{"line_number":50,"context_line":"        \"project.api.TestClass.test_case[positive]\""},{"line_number":51,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_5b6bd51d","line":48,"in_reply_to":"7a8ec9b2_b421bbb6","updated":"2016-09-19 09:00:25.000000000","message":"Done","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4b37d51d6f2ec49d652195210da44a4d6d38efda","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        white_re \u003d \u0027\u0027"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if regex:"},{"line_number":62,"context_line":"        if white_re:"},{"line_number":63,"context_line":"            regex \u003d \u0027|\u0027.join((regex, white_re))"},{"line_number":64,"context_line":"    else:"},{"line_number":65,"context_line":"        regex \u003d white_re"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_d4300704","line":62,"updated":"2016-09-15 16:05:46.000000000","message":"Why not just do?:\n\n  if regex and white_re:","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4b37d51d6f2ec49d652195210da44a4d6d38efda","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    if regex:"},{"line_number":62,"context_line":"        if white_re:"},{"line_number":63,"context_line":"            regex \u003d \u0027|\u0027.join((regex, white_re))"},{"line_number":64,"context_line":"    else:"},{"line_number":65,"context_line":"        regex \u003d white_re"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if blacklist_file:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_f42b4392","line":64,"updated":"2016-09-15 16:05:46.000000000","message":"Ok, now I see why you split it, but let\u0027s make this a bit more explicit and easier to follow and just do:\n\n  elif not regex and white_re:","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e401ab4040ac63bada06d996a2c8649c9c9d3435","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    if regex:"},{"line_number":62,"context_line":"        if white_re:"},{"line_number":63,"context_line":"            regex \u003d \u0027|\u0027.join((regex, white_re))"},{"line_number":64,"context_line":"    else:"},{"line_number":65,"context_line":"        regex \u003d white_re"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if blacklist_file:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_7ba97123","line":64,"in_reply_to":"7a8ec9b2_f42b4392","updated":"2016-09-19 09:00:25.000000000","message":"I\u0027ll try to do some reorg.","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4b37d51d6f2ec49d652195210da44a4d6d38efda","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        return set_of_test_cases"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(afazekas): We might use a faster logic when the"},{"line_number":85,"context_line":"    # print option is not requested"},{"line_number":86,"context_line":"    for (rex, msg, s_list) in black_data:"},{"line_number":87,"context_line":"        for test_case in list_of_test_cases:"},{"line_number":88,"context_line":"            if rex.search(test_case):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_14198f88","line":85,"updated":"2016-09-15 16:05:46.000000000","message":"Would there be a noticeable improvement in doing that. I wonder how much of a penalty we have by doing it this way.","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e401ab4040ac63bada06d996a2c8649c9c9d3435","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        return set_of_test_cases"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    # NOTE(afazekas): We might use a faster logic when the"},{"line_number":85,"context_line":"    # print option is not requested"},{"line_number":86,"context_line":"    for (rex, msg, s_list) in black_data:"},{"line_number":87,"context_line":"        for test_case in list_of_test_cases:"},{"line_number":88,"context_line":"            if rex.search(test_case):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_fb10215b","line":85,"in_reply_to":"7a8ec9b2_14198f88","updated":"2016-09-19 09:00:25.000000000","message":"likely not visible under 10k test, comparing to the regular python interpreter statup + module load times.","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4b37d51d6f2ec49d652195210da44a4d6d38efda","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                s_list.append(test_case)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    if print_exclude:"},{"line_number":93,"context_line":"        for (rex, msg, s_list) in black_data:"},{"line_number":94,"context_line":"            if s_list:"},{"line_number":95,"context_line":"                print_skips(rex, msg, s_list)"},{"line_number":96,"context_line":"    return set_of_test_cases"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_341ccb76","line":93,"updated":"2016-09-15 16:05:46.000000000","message":"Couldn\u0027t you drop this if you moved the if under the outer loop above (and after the inner loop)","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"e401ab4040ac63bada06d996a2c8649c9c9d3435","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                s_list.append(test_case)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    if print_exclude:"},{"line_number":93,"context_line":"        for (rex, msg, s_list) in black_data:"},{"line_number":94,"context_line":"            if s_list:"},{"line_number":95,"context_line":"                print_skips(rex, msg, s_list)"},{"line_number":96,"context_line":"    return set_of_test_cases"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_fe556ff9","line":93,"in_reply_to":"7a8ec9b2_341ccb76","updated":"2016-09-19 09:00:25.000000000","message":"Originally it was printed by regexp, the move would lead to different printing order.","commit_id":"da794db02791bb9327de267841957cbd6cc1aefe"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"158bddb897e2ee6414addcdfa1607c83e3792b83","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            comment \u003d \u0027Skipped because of regex %s:\u0027 % line_regex"},{"line_number":32,"context_line":"        if not line_regex:"},{"line_number":33,"context_line":"            next"},{"line_number":34,"context_line":"        regex_comment_lst.append((re.compile(line_regex), comment, []))"},{"line_number":35,"context_line":"    return regex_comment_lst"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_b50a1dd0","line":33,"updated":"2016-09-19 10:48:02.000000000","message":"Should this be a continue? Next is a a function I thought and wouldn\u0027t this just be a function pointer?","commit_id":"be225234d100128b0f64a8ec2aa2df0b07c6bc67"}]}
