)]}'
{"os_traits/storage/disk.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"695081dd50b864d6261796cd135c2a9ed6c5c2dd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"register \u003d utils.register_fn(__name__)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"register(\u0027HDD\u0027)  # spinning oxide"},{"line_number":21,"context_line":"register(\u0027SSD\u0027)  # solid-state disks"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_8177ffd4","line":20,"range":{"start_line":20,"start_character":17,"end_line":20,"end_character":33},"updated":"2017-03-27 17:54:56.000000000","message":"aka rust :) but yes technical this is true +1","commit_id":"cc5f88a4d233235dfa6a757e07248e3fb77f6ce5"}],"os_traits/utils.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b1274375c81980a85fcbf353d6778138a935a5b5","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    Would end up creating the following symbols:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    os_traits.hw.cpu.x86.AVX2 with the value of \u0027HW_CPU_X86_AVX2\u0027"},{"line_number":44,"context_line":"    os_traits.hw.cpu.x86.SSE with the value of \u0027HW_CPU_X86_SSE\u0027"},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    leaf_mod \u003d sys.modules[mod_name]"},{"line_number":47,"context_line":"    value_base \u003d \u0027_\u0027.join([m.upper() for m in mod_name.split(\u0027.\u0027)[1:]])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_f4f8004a","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":63},"updated":"2017-03-25 18:03:47.000000000","message":"You should also add:\n\nos_traits.HW_CPU_X86_AVX2 with the value of \u0027HW_CPU_X86_AVX2\u0027\nos_traits.HW_CPU_X86_SSE with the value of \u0027HW_CPU_X86_SSE\u0027","commit_id":"e5de1a4e1f149c4dfaa048dc207f4c150d7ff740"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4b36c0b23500643962ab780d0ac03880f1ffb206","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    Would end up creating the following symbols:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    os_traits.hw.cpu.x86.AVX2 with the value of \u0027HW_CPU_X86_AVX2\u0027"},{"line_number":44,"context_line":"    os_traits.hw.cpu.x86.SSE with the value of \u0027HW_CPU_X86_SSE\u0027"},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    leaf_mod \u003d sys.modules[mod_name]"},{"line_number":47,"context_line":"    value_base \u003d \u0027_\u0027.join([m.upper() for m in mod_name.split(\u0027.\u0027)[1:]])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_3972b112","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":63},"in_reply_to":"ffe62b97_f4f8004a","updated":"2017-03-27 16:55:36.000000000","message":"Done","commit_id":"e5de1a4e1f149c4dfaa048dc207f4c150d7ff740"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"092fabe27bdb9bbdbd6b07c11929fb4052aaa5f3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    setattr(leaf_mod, name.upper(), value)  # os_traits.hw.cpu.x86.SSE"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def register_fn(mod_name):"},{"line_number":56,"context_line":"    return functools.partial(symbolize, mod_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_d5a0f792","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":49},"updated":"2017-03-28 14:40:40.000000000","message":"I wonder if we should enhanced this to include documentation with the option. Would involve using something other than constants though","commit_id":"cc5f88a4d233235dfa6a757e07248e3fb77f6ce5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3084460ffbaf10f84f7a86abf52362283c999cd1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    setattr(leaf_mod, name.upper(), value)  # os_traits.hw.cpu.x86.SSE"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def register_fn(mod_name):"},{"line_number":56,"context_line":"    return functools.partial(symbolize, mod_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_abb51234","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":49},"in_reply_to":"ffe62b97_58053e10","updated":"2017-03-28 15:05:30.000000000","message":"Sorry - I\u0027m referring to my comment on the next patch set. Would it be possible to change register some documentation with the train along with the trait itself? Maybe it\u0027s a long term thing for now?","commit_id":"cc5f88a4d233235dfa6a757e07248e3fb77f6ce5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3e252f683da97814b71f53f7a00576ddfe9a32d0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    setattr(leaf_mod, name.upper(), value)  # os_traits.hw.cpu.x86.SSE"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def register_fn(mod_name):"},{"line_number":56,"context_line":"    return functools.partial(symbolize, mod_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_58053e10","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":49},"in_reply_to":"ffe62b97_d5a0f792","updated":"2017-03-28 14:47:16.000000000","message":"Sorry, not quite following you... can you explain with an example?","commit_id":"cc5f88a4d233235dfa6a757e07248e3fb77f6ce5"}]}