)]}'
{"os_traits/misc/__init__.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b9f30b288fd34b2377f5d627d2ff22d640ba36a3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# There may be 10 other resource providers, let\u0027s call them \"CN_1\" through"},{"line_number":27,"context_line":"# \"CN_10\" that represent compute nodes. These compute node resource providers"},{"line_number":28,"context_line":"# have inventory records for MEMORY_MB and VCPU resources, but no DISK_GB"},{"line_number":29,"context_line":"# inventory."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# Both the \"NFS_SHARE\" resource provider and each of the \"CN_x\" resource"},{"line_number":32,"context_line":"# providers are associated to the same aggregate, let\u0027s call it \"AGG_A\"."}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_5a8442b1","line":29,"range":{"start_line":28,"start_character":59,"end_line":29,"end_character":12},"updated":"2017-04-26 19:18:58.000000000","message":"How do they not report DISK_GB? Does the virt driver just have to not return DISK_GB via the get_inventory method? And in what cases does that happen? The hypervisor reports local_gb\u003d0?","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42207cae8d4b0281bc1501d500e4671fdbf0c72a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# There may be 10 other resource providers, let\u0027s call them \"CN_1\" through"},{"line_number":27,"context_line":"# \"CN_10\" that represent compute nodes. These compute node resource providers"},{"line_number":28,"context_line":"# have inventory records for MEMORY_MB and VCPU resources, but no DISK_GB"},{"line_number":29,"context_line":"# inventory."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# Both the \"NFS_SHARE\" resource provider and each of the \"CN_x\" resource"},{"line_number":32,"context_line":"# providers are associated to the same aggregate, let\u0027s call it \"AGG_A\"."}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_da66122a","line":29,"range":{"start_line":28,"start_character":59,"end_line":29,"end_character":12},"in_reply_to":"5ff73747_5a8442b1","updated":"2017-04-26 19:20:40.000000000","message":"Maybe a more direct question is, do we plan on having a config option or something in the nova-compute service that makes the virt driver report local_gb\u003d0 (DISK_GB.inventory.total\u003d0)?","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c423c1451d630ee9f5e9c1efbf23da66f47a5617","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# There may be 10 other resource providers, let\u0027s call them \"CN_1\" through"},{"line_number":27,"context_line":"# \"CN_10\" that represent compute nodes. These compute node resource providers"},{"line_number":28,"context_line":"# have inventory records for MEMORY_MB and VCPU resources, but no DISK_GB"},{"line_number":29,"context_line":"# inventory."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# Both the \"NFS_SHARE\" resource provider and each of the \"CN_x\" resource"},{"line_number":32,"context_line":"# providers are associated to the same aggregate, let\u0027s call it \"AGG_A\"."}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_f5d2015c","line":29,"range":{"start_line":28,"start_character":59,"end_line":29,"end_character":12},"in_reply_to":"5ff73747_da66122a","updated":"2017-04-26 19:31:57.000000000","message":"No, the plan is for the resource tracker and scheduler report client to ask placement API \"hey, is this compute node associated with an aggregate?\" if so, ask the placement API \"does this aggregate have any resource providers associated to it that a) have a DISK_GB inventory record and b) are decorated with this MISC_SHARES_VIA_AGGREGATE trait\".\n\nIf yes, then the compute node is assumed to used shared storage and the DISK_GB inventory record for the compute node will be deleted and the allocations against that \"local\" DISK_GB inventory will be instead placed against the resource provider representing the shared disk pool.\n\nAll this trait does is provide the \"marker\" that the resource provider is providing some shared resources to other resource providers associated with an aggregate.","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc20cbd946a80e8ce7245840953d6e35c6f9df7a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# There may be 10 other resource providers, let\u0027s call them \"CN_1\" through"},{"line_number":27,"context_line":"# \"CN_10\" that represent compute nodes. These compute node resource providers"},{"line_number":28,"context_line":"# have inventory records for MEMORY_MB and VCPU resources, but no DISK_GB"},{"line_number":29,"context_line":"# inventory."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# Both the \"NFS_SHARE\" resource provider and each of the \"CN_x\" resource"},{"line_number":32,"context_line":"# providers are associated to the same aggregate, let\u0027s call it \"AGG_A\"."}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_f5dd6114","line":29,"range":{"start_line":28,"start_character":59,"end_line":29,"end_character":12},"in_reply_to":"5ff73747_f5d2015c","updated":"2017-04-26 19:42:52.000000000","message":"OK I took the \"but no DISK_GB inventory\" literally as in the get_inventory method would return no DISK_GB inventory for that compute node, and I wasn\u0027t sure how that was going to work without config, or the virt driver querying the placement API (something we don\u0027t want). So the get_inventory() method could be reporting local DISK_GB, but RT/scheduler report client would ignore what the virt driver is reporting iff the compute node RT is associated via aggregate to another RP that has this trait and has some matching resource class, DISK_GB in this case. If the virt driver reports CUSTOM_FOO inventory and the compute node RP is associated via aggregate to another RP with the MISC_SHARES_VIA_AGGREGATE trait, but doesn\u0027t have CUSTOM_FOO inventory, then the compute node RP reports that inventory from the driver.\n\nI guess we never had a spec for https://blueprints.launchpad.net/nova/+spec/shared-resources-pike, unless the plan, as you describe it, is elsewhere, like in the traits API spec, but I don\u0027t think any of this design plan was in the generic-resource-pools spec since that was written long ago. So design-wise I wasn\u0027t sure how this was going to tie together since I don\u0027t think it\u0027s actually written down anywhere, but I might just be missing something (this seems to be common complaint of cdent as well).","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3982872edc0b13fbd9fe6253212e2cfa4f1d3605","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# inventory."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# Both the \"NFS_SHARE\" resource provider and each of the \"CN_x\" resource"},{"line_number":32,"context_line":"# providers are associated to the same aggregate, let\u0027s call it \"AGG_A\"."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# Deployers would decorate the \"NFS_SHARE\" resource provider with the"},{"line_number":35,"context_line":"# \"MISC_SHARES_VIA_AGGREGATE\" trait to indicate to the system that the DISK_GB"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_3af4d685","line":32,"range":{"start_line":32,"start_character":65,"end_line":32,"end_character":70},"updated":"2017-04-26 19:14:58.000000000","message":"nit: something specific to the NFS provider so maybe NFS_AGG_A?","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c423c1451d630ee9f5e9c1efbf23da66f47a5617","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# inventory."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# Both the \"NFS_SHARE\" resource provider and each of the \"CN_x\" resource"},{"line_number":32,"context_line":"# providers are associated to the same aggregate, let\u0027s call it \"AGG_A\"."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# Deployers would decorate the \"NFS_SHARE\" resource provider with the"},{"line_number":35,"context_line":"# \"MISC_SHARES_VIA_AGGREGATE\" trait to indicate to the system that the DISK_GB"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_95cf3daf","line":32,"range":{"start_line":32,"start_character":65,"end_line":32,"end_character":70},"in_reply_to":"5ff73747_3af4d685","updated":"2017-04-26 19:31:57.000000000","message":"No, it\u0027s not specific to NFS... the aggregate is merely a grouping of resource providers, nothing more.","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc20cbd946a80e8ce7245840953d6e35c6f9df7a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# inventory."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# Both the \"NFS_SHARE\" resource provider and each of the \"CN_x\" resource"},{"line_number":32,"context_line":"# providers are associated to the same aggregate, let\u0027s call it \"AGG_A\"."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# Deployers would decorate the \"NFS_SHARE\" resource provider with the"},{"line_number":35,"context_line":"# \"MISC_SHARES_VIA_AGGREGATE\" trait to indicate to the system that the DISK_GB"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_55f53582","line":32,"range":{"start_line":32,"start_character":65,"end_line":32,"end_character":70},"in_reply_to":"5ff73747_95cf3daf","updated":"2017-04-26 19:42:52.000000000","message":"Well, I meant specific to the NFS_SHARE RP, but OK. I guess you could have an NFS_SHARE RP and an IP_POOL RP and both of those are in aggregate associations with your 10 CN RPs.","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3982872edc0b13fbd9fe6253212e2cfa4f1d3605","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# providers are associated to the same aggregate, let\u0027s call it \"AGG_A\"."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# Deployers would decorate the \"NFS_SHARE\" resource provider with the"},{"line_number":35,"context_line":"# \"MISC_SHARES_VIA_AGGREGATE\" trait to indicate to the system that the DISK_GB"},{"line_number":36,"context_line":"# inventory it provides can be consumed by consumers of resources on any of the"},{"line_number":37,"context_line":"# other resource providers associated with any aggregate \"NFS_SHARE\" is"},{"line_number":38,"context_line":"# associated to."},{"line_number":39,"context_line":"register(\u0027SHARES_VIA_AGGREGATE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_da7cd2ec","line":36,"range":{"start_line":35,"start_character":30,"end_line":36,"end_character":23},"updated":"2017-04-26 19:14:58.000000000","message":"What about the name MISC_SHARES_VIA_AGGREGATE indicates that this traits is associated with DISK_GB inventory? Shouldn\u0027t it be called something like SHARES_DISK_GB_VIA_AGGREGATE?","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9de7f33a009ba0725e467670027aace8e392793f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# Deployers would decorate the \"NFS_SHARE\" resource provider with the"},{"line_number":35,"context_line":"# \"MISC_SHARES_VIA_AGGREGATE\" trait to indicate to the system that the DISK_GB"},{"line_number":36,"context_line":"# inventory it provides can be consumed by consumers of resources on any of the"},{"line_number":37,"context_line":"# other resource providers associated with any aggregate \"NFS_SHARE\" is"},{"line_number":38,"context_line":"# associated to."},{"line_number":39,"context_line":"register(\u0027SHARES_VIA_AGGREGATE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_edf1156d","line":36,"in_reply_to":"5ff73747_b541190e","updated":"2017-04-26 20:24:44.000000000","message":"This means we don\u0027t allow the case where a resource provider provides multiple classes of resource but only shares one or some of them. Which is fine, we\u0027ve declared that to be the case from the start.\n\nThis is a nice write up, thanks for that.","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c423c1451d630ee9f5e9c1efbf23da66f47a5617","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# providers are associated to the same aggregate, let\u0027s call it \"AGG_A\"."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# Deployers would decorate the \"NFS_SHARE\" resource provider with the"},{"line_number":35,"context_line":"# \"MISC_SHARES_VIA_AGGREGATE\" trait to indicate to the system that the DISK_GB"},{"line_number":36,"context_line":"# inventory it provides can be consumed by consumers of resources on any of the"},{"line_number":37,"context_line":"# other resource providers associated with any aggregate \"NFS_SHARE\" is"},{"line_number":38,"context_line":"# associated to."},{"line_number":39,"context_line":"register(\u0027SHARES_VIA_AGGREGATE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_b541190e","line":36,"range":{"start_line":35,"start_character":30,"end_line":36,"end_character":23},"in_reply_to":"5ff73747_da7cd2ec","updated":"2017-04-26 19:31:57.000000000","message":"No. DISK_GB is a resource class. The MISC_SHARES_VIA_AGGREGATE is a trait that says \"this resource provider shares its resources with all resource providers associated via an aggregate\".","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3982872edc0b13fbd9fe6253212e2cfa4f1d3605","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# inventory it provides can be consumed by consumers of resources on any of the"},{"line_number":37,"context_line":"# other resource providers associated with any aggregate \"NFS_SHARE\" is"},{"line_number":38,"context_line":"# associated to."},{"line_number":39,"context_line":"register(\u0027SHARES_VIA_AGGREGATE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_9a11aaaf","line":39,"range":{"start_line":39,"start_character":10,"end_line":39,"end_character":30},"updated":"2017-04-26 19:14:58.000000000","message":"I\u0027m confused, is it SHARES_VIA_AGGREGATE or MISC_SHARES_VIA_AGGREGATE?","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c423c1451d630ee9f5e9c1efbf23da66f47a5617","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# inventory it provides can be consumed by consumers of resources on any of the"},{"line_number":37,"context_line":"# other resource providers associated with any aggregate \"NFS_SHARE\" is"},{"line_number":38,"context_line":"# associated to."},{"line_number":39,"context_line":"register(\u0027SHARES_VIA_AGGREGATE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_355509c7","line":39,"range":{"start_line":39,"start_character":10,"end_line":39,"end_character":30},"in_reply_to":"5ff73747_9a11aaaf","updated":"2017-04-26 19:31:57.000000000","message":"The MISC_ is tacked on automatically by the os_traits.utils.register() function.","commit_id":"ffff9ea6cb73f15cd1ef8f41c9173f093a06724e"}]}
