)]}'
{"os_traits/__init__.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"57e7868fbabfd9f251a86e7bb7369fe709f2c168","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    a trait, registers a symbol in the module that corresponds to the full"},{"line_number":44,"context_line":"    namespaced trait name."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    leaf_mod, value \u003d format_name(mod_name, name)"},{"line_number":47,"context_line":"    setattr(THIS_LIB, value, value)  # os_traits.HW_CPU_X86_SSE"},{"line_number":48,"context_line":"    setattr(leaf_mod, name, value)  # os_traits.hw.cpu.x86.SSE"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_f42ca4ad","line":46,"updated":"2017-07-20 15:08:02.000000000","message":"this is a reasonable clean up so I\u0027m happy to see it, but some might say it is no longer a proper member of this change","commit_id":"2d34fc739023ede57dcafdbb55ab928b858b8e57"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f22c81d6d3c88cd6d4d48051ffcd653275d7cf9c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    a trait, registers a symbol in the module that corresponds to the full"},{"line_number":44,"context_line":"    namespaced trait name."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    leaf_mod, value \u003d format_name(mod_name, name)"},{"line_number":47,"context_line":"    setattr(THIS_LIB, value, value)  # os_traits.HW_CPU_X86_SSE"},{"line_number":48,"context_line":"    setattr(leaf_mod, name, value)  # os_traits.hw.cpu.x86.SSE"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_da178f45","line":46,"in_reply_to":"1f1a1f67_f42ca4ad","updated":"2017-07-20 15:31:00.000000000","message":"Yes, I need to take the previous version back. This is not needed anymore.","commit_id":"2d34fc739023ede57dcafdbb55ab928b858b8e57"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"13852319f3a870ce1ed85c9b22a67d3a500aa9e2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"import_submodules(sys.modules.get(__name__))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def get_traits(prefix\u003dNone, suffix\u003dNone):"},{"line_number":69,"context_line":"    \"\"\"Returns the trait strings in the os_traits module, optionally filtered"},{"line_number":70,"context_line":"    by a supplied prefix and suffix."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_c9c6a717","line":68,"range":{"start_line":68,"start_character":15,"end_line":68,"end_character":39},"updated":"2017-07-23 05:42:58.000000000","message":"why not default to \"\"","commit_id":"ce9bef1c5be77011ee5fc59c65fc3ce2a7ab14f2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8ffa1e717d107168824edb29030d56088ed6cd84","unresolved":false,"context_lines":[{"line_number":65,"context_line":"import_submodules(sys.modules.get(__name__))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def get_traits(prefix\u003dNone, suffix\u003dNone):"},{"line_number":69,"context_line":"    \"\"\"Returns the trait strings in the os_traits module, optionally filtered"},{"line_number":70,"context_line":"    by a supplied prefix and suffix."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_1d95fbe4","line":68,"in_reply_to":"ff346bd7_827aa621","updated":"2017-07-24 10:20:35.000000000","message":"That\u0027s correct, I\u0027m preserving the pattern.\n\nBut Sean is correct: use an empty string is better.\n\nSean, do you mind if I address this in other patch? I\u0027ll change all optional variables in os-traits functions (get_traits, check_traits)","commit_id":"ce9bef1c5be77011ee5fc59c65fc3ce2a7ab14f2"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"69a21cc76fbf36fa49c1baf01b77c0c75f72d008","unresolved":false,"context_lines":[{"line_number":65,"context_line":"import_submodules(sys.modules.get(__name__))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def get_traits(prefix\u003dNone, suffix\u003dNone):"},{"line_number":69,"context_line":"    \"\"\"Returns the trait strings in the os_traits module, optionally filtered"},{"line_number":70,"context_line":"    by a supplied prefix and suffix."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_827aa621","line":68,"in_reply_to":"ff346bd7_c9c6a717","updated":"2017-07-24 09:35:30.000000000","message":"I suspect the new code is preserving the pattern of the old code...","commit_id":"ce9bef1c5be77011ee5fc59c65fc3ce2a7ab14f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"13852319f3a870ce1ed85c9b22a67d3a500aa9e2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    :param prefix: Optional string prefix to filter by. e.g. \u0027HW_\u0027"},{"line_number":73,"context_line":"    :param suffix: Optional string suffix to filter by, e.g. \u0027SSE\u0027"},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":"    prefix \u003d prefix or \"\""},{"line_number":76,"context_line":"    suffix \u003d suffix or \"\""},{"line_number":77,"context_line":"    return ["},{"line_number":78,"context_line":"        v for k, v in sys.modules[__name__].__dict__.items()"},{"line_number":79,"context_line":"        if isinstance(v, six.string_types) and"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_a9cb631c","line":76,"range":{"start_line":75,"start_character":4,"end_line":76,"end_character":25},"updated":"2017-07-23 05:42:58.000000000","message":"then you can removed theses lines.","commit_id":"ce9bef1c5be77011ee5fc59c65fc3ce2a7ab14f2"}],"os_traits/tests/test_os_traits.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"57e7868fbabfd9f251a86e7bb7369fe709f2c168","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    #         if ot.TEST_DIR in name:"},{"line_number":114,"context_line":"    #             continue"},{"line_number":115,"context_line":"    #         module \u003d importlib.import_module(name)"},{"line_number":116,"context_line":"    #         self.assertTrue(getattr(module, \u0027find_trait\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_7412d464","line":116,"updated":"2017-07-20 15:08:02.000000000","message":"remove this, please","commit_id":"2d34fc739023ede57dcafdbb55ab928b858b8e57"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f22c81d6d3c88cd6d4d48051ffcd653275d7cf9c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    #         if ot.TEST_DIR in name:"},{"line_number":114,"context_line":"    #             continue"},{"line_number":115,"context_line":"    #         module \u003d importlib.import_module(name)"},{"line_number":116,"context_line":"    #         self.assertTrue(getattr(module, \u0027find_trait\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_9a50f70c","line":116,"in_reply_to":"1f1a1f67_7412d464","updated":"2017-07-20 15:31:00.000000000","message":"Done","commit_id":"2d34fc739023ede57dcafdbb55ab928b858b8e57"}]}
