)]}'
{"os_traits/fw/bios.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2b04e0898ab265546e8b022e9b97c74b575c5607","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # indicates bios boot support"},{"line_number":17,"context_line":"    \"BIOS\","},{"line_number":18,"context_line":"    # legacy bios boot is enabled not uefi."},{"line_number":19,"context_line":"    \"BOOT_MODE_LEGACY\""},{"line_number":20,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_43e60719","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":22},"updated":"2017-11-10 19:00:25.000000000","message":"This doesn\u0027t seem like a capability to me, but rather a configuration setting for a piece of hardware. Would end-users be requesting a \"resource provider that boots in legacy boot mode\"?","commit_id":"ee1f20b9fbefb2d18a528cf71e9ce37a99db9092"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"855ec43c2d67673c078b7baa891b21743af97575","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # indicates bios boot support"},{"line_number":17,"context_line":"    \"BIOS\","},{"line_number":18,"context_line":"    # legacy bios boot is enabled not uefi."},{"line_number":19,"context_line":"    \"BOOT_MODE_LEGACY\""},{"line_number":20,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_aa0d8b38","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":22},"in_reply_to":"1f485f77_43e60719","updated":"2017-11-10 22:52:43.000000000","message":"if my glance image does not contain an efi boot partition\nthe yes i may need to request legacy boot.","commit_id":"ee1f20b9fbefb2d18a528cf71e9ce37a99db9092"}],"os_traits/fw/uefi.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2b04e0898ab265546e8b022e9b97c74b575c5607","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # or other devices such as GPUs"},{"line_number":18,"context_line":"    \"UEFI\","},{"line_number":19,"context_line":"    # indicates the system will boot in uefi mode."},{"line_number":20,"context_line":"    \"BOOT_MODE_UEFI\","},{"line_number":21,"context_line":"    # see: https://en.wikipedia.org/wiki/Unified_Extensible_Firmware_Interface"},{"line_number":22,"context_line":"    # Compatibility_Support_Module"},{"line_number":23,"context_line":"    \"CSM\","}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_437de71a","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":21},"updated":"2017-11-10 19:00:25.000000000","message":"not a capability :)","commit_id":"ee1f20b9fbefb2d18a528cf71e9ce37a99db9092"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2b04e0898ab265546e8b022e9b97c74b575c5607","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    # see: https://en.wikipedia.org/wiki/Unified_Extensible_Firmware_Interface"},{"line_number":25,"context_line":"    # Secure_boot"},{"line_number":26,"context_line":"    \"SECURE_BOOT\","},{"line_number":27,"context_line":"    \"SECURE_BOOT_ENABLED\""},{"line_number":28,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_6388e31e","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":25},"updated":"2017-11-10 19:00:25.000000000","message":"This isn\u0027t a trait. Traits are capabilities, not configuration settings.","commit_id":"ee1f20b9fbefb2d18a528cf71e9ce37a99db9092"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"855ec43c2d67673c078b7baa891b21743af97575","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    # see: https://en.wikipedia.org/wiki/Unified_Extensible_Firmware_Interface"},{"line_number":25,"context_line":"    # Secure_boot"},{"line_number":26,"context_line":"    \"SECURE_BOOT\","},{"line_number":27,"context_line":"    \"SECURE_BOOT_ENABLED\""},{"line_number":28,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_caf20707","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":25},"in_reply_to":"1f485f77_6388e31e","updated":"2017-11-10 22:52:43.000000000","message":"that is true, i may legitimately for legal reasons need to request that my workload (vm,bare metal or container) can only be scheduled to a host that is using secure boot.\n\ntraits may not be the right way to do that but with out using traits for this we will need a new field for resource providers to track the configuration of this host capability.","commit_id":"ee1f20b9fbefb2d18a528cf71e9ce37a99db9092"}]}
