)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"de59093e5cb3691ca3f9a0d3a1439ca00785713f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The virt driver API in nova has a capabilities dict that lists the"},{"line_number":10,"context_line":"capabilities of the virt driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Based on the patch at https://review.openstack.org/#/c/538498/6, let\u0027s"},{"line_number":13,"context_line":"try to standardize the relevant capabilities into a new"},{"line_number":14,"context_line":"os_traits.compute module."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa0c359_caa08293","line":12,"updated":"2018-02-21 18:09:36.000000000","message":"Should probably use a Depends-On for this so we don\u0027t actually do this in the library unless we have agreement in nova.","commit_id":"9ce78b9452c708aa26f7f05de560a82cee8cad78"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"3568f550dc5d4fb6120918d939d5769e910f4ef0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The virt driver API in nova has a capabilities dict that lists the"},{"line_number":10,"context_line":"capabilities of the virt driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Based on the patch at https://review.openstack.org/#/c/538498/6, let\u0027s"},{"line_number":13,"context_line":"try to standardize the relevant capabilities into a new"},{"line_number":14,"context_line":"os_traits.compute module."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa0c359_b3500ed7","line":12,"in_reply_to":"3fa0c359_caa08293","updated":"2018-02-21 19:38:03.000000000","message":"You mean have https://review.openstack.org/#/c/538498 depend on this patch? or have this patch depend on https://review.openstack.org/#/c/538498?","commit_id":"9ce78b9452c708aa26f7f05de560a82cee8cad78"}],"os_traits/compute/net.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9ef2f7c3c18536f6e0b2a1a132dc189a49e716a1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a network interface after boot"},{"line_number":17,"context_line":"    \u0027ATTACH_INTERFACE\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports associating a tag with a network interface after"},{"line_number":19,"context_line":"    # boot"},{"line_number":20,"context_line":"    \u0027ATTACH_INTERFACE_WITH_TAG\u0027,"},{"line_number":21,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_10ac969e","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":10},"updated":"2018-04-19 08:10:07.000000000","message":"Isn\u0027t it more like \"The virt driver support attaching a tagged network interface after boot\" ?","commit_id":"9ce78b9452c708aa26f7f05de560a82cee8cad78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"372f0c25adeaf2e73392a4b398d8d2b02dae8595","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a network interface after boot"},{"line_number":17,"context_line":"    \u0027ATTACH_INTERFACE\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports associating a tag with a network interface after"},{"line_number":19,"context_line":"    # boot"},{"line_number":20,"context_line":"    \u0027ATTACH_INTERFACE_WITH_TAG\u0027,"},{"line_number":21,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_9bb2a648","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":10},"in_reply_to":"9f6a8fd7_0dcd0a65","updated":"2018-04-24 09:11:20.000000000","message":"@Artom: looks good to me","commit_id":"9ce78b9452c708aa26f7f05de560a82cee8cad78"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1f45d3f75dd70ca19f5ab0a6467d565f011bb7cc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a network interface after boot"},{"line_number":17,"context_line":"    \u0027ATTACH_INTERFACE\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports associating a tag with a network interface after"},{"line_number":19,"context_line":"    # boot"},{"line_number":20,"context_line":"    \u0027ATTACH_INTERFACE_WITH_TAG\u0027,"},{"line_number":21,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_0dcd0a65","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":10},"in_reply_to":"9f6a8fd7_0de8aadf","updated":"2018-04-23 19:46:44.000000000","message":"How about \"supports tagging a network interface during attachment\"?","commit_id":"9ce78b9452c708aa26f7f05de560a82cee8cad78"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"0e4885f2fc4ad9830e27aaac84c1f86ee8431558","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a network interface after boot"},{"line_number":17,"context_line":"    \u0027ATTACH_INTERFACE\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports associating a tag with a network interface after"},{"line_number":19,"context_line":"    # boot"},{"line_number":20,"context_line":"    \u0027ATTACH_INTERFACE_WITH_TAG\u0027,"},{"line_number":21,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_0de8aadf","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":10},"in_reply_to":"9f6a8fd7_10ac969e","updated":"2018-04-23 19:38:13.000000000","message":"Honestly, I\u0027m not entirely sure :(\n\nFrom what I can tell, the only difference between attach_interface() for virt drivers that support \"tagged_interface_attach\" is that instance.device_metadata is created/saved when True.\n\nSo, I thought \"supports associating a tag with a network interface after boot\" described that functionality best.\n\nBut, I could go either way.\n\nArtom, what are your thoughts?","commit_id":"9ce78b9452c708aa26f7f05de560a82cee8cad78"}],"os_traits/compute/volume.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"63418384a8546cbba40b3ea1f390998bf3824cff","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a volume after boot"},{"line_number":17,"context_line":"    \u0027ATTACH\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports associating a tag with a volume after boot"},{"line_number":19,"context_line":"    \u0027ATTACH_WITH_TAG\u0027,"},{"line_number":20,"context_line":"    # The virt driver supports extending a volume after boot"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_cadac276","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":11},"updated":"2018-02-21 17:57:56.000000000","message":"Which ComputeDriver capability does this correspond to?","commit_id":"9ce78b9452c708aa26f7f05de560a82cee8cad78"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d1b744e50e3deb46d59ea380dff6acd8a41a7c9b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a volume after boot"},{"line_number":17,"context_line":"    \u0027ATTACH\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports associating a tag with a volume after boot"},{"line_number":19,"context_line":"    \u0027ATTACH_WITH_TAG\u0027,"},{"line_number":20,"context_line":"    # The virt driver supports extending a volume after boot"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_b3bb2e0d","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":11},"in_reply_to":"3fa0c359_cadac276","updated":"2018-02-21 19:37:05.000000000","message":"It does not correspond to a specific capability listed currently in the virt driver interface. But it should... for instance, Ironic does not support attach_volume().","commit_id":"9ce78b9452c708aa26f7f05de560a82cee8cad78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9ef2f7c3c18536f6e0b2a1a132dc189a49e716a1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a volume after boot"},{"line_number":17,"context_line":"    \u0027ATTACH\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports associating a tag with a volume after boot"},{"line_number":19,"context_line":"    \u0027ATTACH_WITH_TAG\u0027,"},{"line_number":20,"context_line":"    # The virt driver supports extending a volume after boot"},{"line_number":21,"context_line":"    \u0027EXTEND\u0027,"},{"line_number":22,"context_line":"    # The virt driver supports volumes that can be attached to multiple guests"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_f079e22e","line":19,"range":{"start_line":18,"start_character":1,"end_line":19,"end_character":1},"updated":"2018-04-19 08:10:07.000000000","message":"Isn\u0027t it more like \"The virt driver support attaching a tagged volume after boot\" ?","commit_id":"9ce78b9452c708aa26f7f05de560a82cee8cad78"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b60c48609bddb54c207ba4a1206fbb10eefd58d1","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a volume after boot"},{"line_number":17,"context_line":"    \u0027ATTACH\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports attaching a volume after boot and specifying a"},{"line_number":19,"context_line":"    # device tag for the volume"},{"line_number":20,"context_line":"    \u0027ATTACH_WITH_TAG\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f969d425","line":17,"updated":"2018-06-19 17:39:24.000000000","message":"This doesn\u0027t map to anything in the compute driver capabilities dict.","commit_id":"56531c2a81e4938fd790d6fc05791ee745da5f03"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"47c975f5636d08e4813d64e3ec97cde929cd1c97","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a volume after boot"},{"line_number":17,"context_line":"    \u0027ATTACH\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports attaching a volume after boot and specifying a"},{"line_number":19,"context_line":"    # device tag for the volume"},{"line_number":20,"context_line":"    \u0027ATTACH_WITH_TAG\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_23de2410","line":17,"in_reply_to":"5f7c97a3_44125cb6","updated":"2018-06-20 12:36:36.000000000","message":"Ah yeah...","commit_id":"56531c2a81e4938fd790d6fc05791ee745da5f03"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"077dec72b3238d536edadbfe055e697b5d02f257","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The virt driver supports attaching a volume after boot"},{"line_number":17,"context_line":"    \u0027ATTACH\u0027,"},{"line_number":18,"context_line":"    # The virt driver supports attaching a volume after boot and specifying a"},{"line_number":19,"context_line":"    # device tag for the volume"},{"line_number":20,"context_line":"    \u0027ATTACH_WITH_TAG\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_44125cb6","line":17,"in_reply_to":"5f7c97a3_f969d425","updated":"2018-06-19 19:12:47.000000000","message":"I noted that on PS1 - see Jay\u0027s response.","commit_id":"56531c2a81e4938fd790d6fc05791ee745da5f03"}]}