)]}'
{"os_traits/compute/image.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d0889d8be601a436406b7cc58b3dc98d70ff8274","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # Amazon kernel, machine, and ramdisk images"},{"line_number":17,"context_line":"    \u0027IMAGE_TYPE_SUPPORT_AKI\u0027,"},{"line_number":18,"context_line":"    \u0027IMAGE_TYPE_SUPPORT_AMI\u0027,"},{"line_number":19,"context_line":"    \u0027IMAGE_TYPE_SUPPORT_ARI\u0027,"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_b7419a0c","line":17,"updated":"2019-03-27 15:12:34.000000000","message":"This results in traits that look like this:\n\nCOMPUTE_IMAGE_IMAGE_TYPE_SUPPORT_VHDX\n\nwhich I assume is not what you\u0027re after. The package (less \u0027os_traits\u0027) is prepended to the trait string. You could presumably create type and support packages but it\u0027s definitely not necessary and probably not what you really want in this case as the meaning value is the whole \"TYPE[...]\" bit","commit_id":"85918857b495c876145087f5f8cf5b5865745aac"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b9f2f088ea9df0364654c1677a4c084ca530d15f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # Amazon kernel, machine, and ramdisk images"},{"line_number":17,"context_line":"    \u0027TYPE_SUPPORT_AKI\u0027,"},{"line_number":18,"context_line":"    \u0027TYPE_SUPPORT_AMI\u0027,"},{"line_number":19,"context_line":"    \u0027TYPE_SUPPORT_ARI\u0027,"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_cfa8468d","line":17,"updated":"2019-03-27 19:22:40.000000000","message":"not sure there\u0027s a need to have AKI or ARI since the disk image format is really just \"AMI\". But, won\u0027t hurt I guess.","commit_id":"603591c8dd4a575180e8f66da834e22c965a820b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f28032ce2fa017f03af4a994efc03aca5c47458b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # Amazon kernel, machine, and ramdisk images"},{"line_number":17,"context_line":"    \u0027TYPE_SUPPORT_AKI\u0027,"},{"line_number":18,"context_line":"    \u0027TYPE_SUPPORT_AMI\u0027,"},{"line_number":19,"context_line":"    \u0027TYPE_SUPPORT_ARI\u0027,"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_40aae570","line":17,"in_reply_to":"5fc1f717_cfa8468d","updated":"2019-03-27 21:38:49.000000000","message":"They\u0027re in glance\u0027s list of disk containers, so I\u0027d like to keep it a 1:1 mapping if possible.","commit_id":"603591c8dd4a575180e8f66da834e22c965a820b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b9f2f088ea9df0364654c1677a4c084ca530d15f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    # Native format for QEMU"},{"line_number":25,"context_line":"    \u0027TYPE_SUPPORT_QCOW2\u0027,"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    # Unstrucured generic byte-for-byte disk image"},{"line_number":28,"context_line":"    \u0027TYPE_SUPPORT_RAW\u0027,"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    # Native format for VirtualBox"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_efabc284","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":17},"updated":"2019-03-27 19:22:40.000000000","message":"Unstructured","commit_id":"603591c8dd4a575180e8f66da834e22c965a820b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"31f2952bdc32b0300e7bb6889cb048e43845edd7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # Amazon kernel, machine, and ramdisk images"},{"line_number":17,"context_line":"    \u0027TYPE_AKI\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_4c69ae22","line":14,"updated":"2019-03-28 16:39:08.000000000","message":"Please add a comment to the effect of:\n\n# This is fed from the list at\n# https://docs.openstack.org/image-guide/image-formats.html#disk-formats\n# and should be kept up to date with same.","commit_id":"d225a7f5aae67cdda0b69af929f812a5d8921a59"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b06b90493a763233cfe8bbcc18a967311f9b72e2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # Amazon kernel, machine, and ramdisk images"},{"line_number":17,"context_line":"    \u0027TYPE_AKI\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_0c7966c3","line":14,"in_reply_to":"5fc1f717_4c69ae22","updated":"2019-03-28 16:47:28.000000000","message":"https://review.openstack.org/#/c/648466/","commit_id":"d225a7f5aae67cdda0b69af929f812a5d8921a59"}]}
