)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"4937eb35a6cabfd8506802862ab6ff1d1bbd5094","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add libvirt image metadata traits"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change introduces standard traits for the"},{"line_number":10,"context_line":"  well defiend hw_disk_model, hw_cdrom_model, hw_video_model"},{"line_number":11,"context_line":"  and hw_vif_model image metadata properties."},{"line_number":12,"context_line":"- This spec defines all of the new traits in the compute"},{"line_number":13,"context_line":"  namespace as they represent the ablity of a hypervisor to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_1cbcc167","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":14},"updated":"2019-04-17 18:40:00.000000000","message":"defined","commit_id":"d483b89071741c5b44d1740e252afafe27e7b02a"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"4937eb35a6cabfd8506802862ab6ff1d1bbd5094","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  and hw_vif_model image metadata properties."},{"line_number":12,"context_line":"- This spec defines all of the new traits in the compute"},{"line_number":13,"context_line":"  namespace as they represent the ablity of a hypervisor to"},{"line_number":14,"context_line":"  emulate a specifc virtual device model, not the presence"},{"line_number":15,"context_line":"  of the respectiv hardware device on the host."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I42237b196644bfa87701f978a1519941d447b450"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_dc72b9e3","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":19},"updated":"2019-04-17 18:40:00.000000000","message":"specific","commit_id":"d483b89071741c5b44d1740e252afafe27e7b02a"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"4937eb35a6cabfd8506802862ab6ff1d1bbd5094","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- This spec defines all of the new traits in the compute"},{"line_number":13,"context_line":"  namespace as they represent the ablity of a hypervisor to"},{"line_number":14,"context_line":"  emulate a specifc virtual device model, not the presence"},{"line_number":15,"context_line":"  of the respectiv hardware device on the host."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I42237b196644bfa87701f978a1519941d447b450"},{"line_number":18,"context_line":"Task: 30526"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_dcadd931","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":18},"updated":"2019-04-17 18:40:00.000000000","message":"respective","commit_id":"d483b89071741c5b44d1740e252afafe27e7b02a"}],"os_traits/compute/disk.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cbc0cbc56e00d3a79a78b36aa309b2956d8ae558","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_disk_bus\""},{"line_number":17,"context_line":"    # image metadata property."},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L320-L332"},{"line_number":19,"context_line":"    \u0027BUS_MODEL_FDC\u0027,"},{"line_number":20,"context_line":"    \u0027BUS_MODEL_IDE\u0027,"},{"line_number":21,"context_line":"    \u0027BUS_MODEL_SATA\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_5ffdfa6b","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":85},"updated":"2019-05-01 20:58:15.000000000","message":"I notice \u0027lxc\u0027 is present here but not in [1]. What gives? Would we be adding it there?\n\n[1] https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json#L17","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8fae7e1cd90eac147a8b562a5d34313ffc1415ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_disk_bus\""},{"line_number":17,"context_line":"    # image metadata property."},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L320-L332"},{"line_number":19,"context_line":"    \u0027BUS_MODEL_FDC\u0027,"},{"line_number":20,"context_line":"    \u0027BUS_MODEL_IDE\u0027,"},{"line_number":21,"context_line":"    \u0027BUS_MODEL_SATA\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_fa5ddc14","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":85},"in_reply_to":"ffb9cba7_5ffdfa6b","updated":"2019-05-01 21:24:13.000000000","message":"i can add it there as a sperate change yes.\none of the problems with the metadefs is that\nwe have not requried people to update them as we change the set that we support in nova.","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cbc0cbc56e00d3a79a78b36aa309b2956d8ae558","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027BUS_MODEL_VIRTIO\u0027,"},{"line_number":25,"context_line":"    \u0027BUS_MODEL_XEN\u0027,"},{"line_number":26,"context_line":"    \u0027BUS_MODEL_LXC\u0027,"},{"line_number":27,"context_line":"    \u0027BUS_MODEL_UML\u0027,"},{"line_number":28,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_1ffb0279","line":27,"updated":"2019-05-01 20:58:15.000000000","message":"any particular reason not to alphabetize this, just for readability?","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8fae7e1cd90eac147a8b562a5d34313ffc1415ac","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027BUS_MODEL_VIRTIO\u0027,"},{"line_number":25,"context_line":"    \u0027BUS_MODEL_XEN\u0027,"},{"line_number":26,"context_line":"    \u0027BUS_MODEL_LXC\u0027,"},{"line_number":27,"context_line":"    \u0027BUS_MODEL_UML\u0027,"},{"line_number":28,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_9a9ce0c0","line":27,"in_reply_to":"ffb9cba7_1ffb0279","updated":"2019-05-01 21:24:13.000000000","message":"no i can do that.","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1326d8061efb9d8ec34cd256b82567a51509c385","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \u0027BUS_MODEL_VIRTIO\u0027,"},{"line_number":25,"context_line":"    \u0027BUS_MODEL_XEN\u0027,"},{"line_number":26,"context_line":"    \u0027BUS_MODEL_LXC\u0027,"},{"line_number":27,"context_line":"    \u0027BUS_MODEL_UML\u0027,"},{"line_number":28,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_9ac86022","line":27,"in_reply_to":"ffb9cba7_9a9ce0c0","updated":"2019-05-01 22:21:49.000000000","message":"throughout, please.","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"}],"os_traits/compute/graphics.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cbc0cbc56e00d3a79a78b36aa309b2956d8ae558","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_video_model\""},{"line_number":17,"context_line":"    # image metadata property."},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L501-L509"},{"line_number":19,"context_line":"    \u0027MODEL_VGA\u0027,"},{"line_number":20,"context_line":"    \u0027MODEL_CIRRUS\u0027,"},{"line_number":21,"context_line":"    \u0027MODEL_VMVGA\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_bf68b61c","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":85},"updated":"2019-05-01 20:58:15.000000000","message":"Comparing, [1] doesn\u0027t have virtio or gop; and has qxl which is absent here.\n\nThe nova reference doesn\u0027t have gop either. And where did None come from?\n\n[1] https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json#L45","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8fae7e1cd90eac147a8b562a5d34313ffc1415ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_video_model\""},{"line_number":17,"context_line":"    # image metadata property."},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L501-L509"},{"line_number":19,"context_line":"    \u0027MODEL_VGA\u0027,"},{"line_number":20,"context_line":"    \u0027MODEL_CIRRUS\u0027,"},{"line_number":21,"context_line":"    \u0027MODEL_VMVGA\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_fab2bc48","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":85},"in_reply_to":"ffb9cba7_bf68b61c","updated":"2019-05-01 21:24:13.000000000","message":"this comes form my specless blueprint here \nhttps://review.opendev.org/#/c/647733/3/nova/objects/fields.py\n\nwhere i add the new fields.\ni can move them into a follow up patch which depends on that\nif you want.","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1326d8061efb9d8ec34cd256b82567a51509c385","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_video_model\""},{"line_number":17,"context_line":"    # image metadata property."},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L501-L509"},{"line_number":19,"context_line":"    \u0027MODEL_VGA\u0027,"},{"line_number":20,"context_line":"    \u0027MODEL_CIRRUS\u0027,"},{"line_number":21,"context_line":"    \u0027MODEL_VMVGA\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_3ad934f2","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":85},"in_reply_to":"ffb9cba7_fab2bc48","updated":"2019-05-01 22:21:49.000000000","message":"Ah, then the link in the comment won\u0027t be accurate once that merges. So yeah, probably better to do both in a followon instead.","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"}],"os_traits/compute/net.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cbc0cbc56e00d3a79a78b36aa309b2956d8ae558","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    # The virt driver supports attaching a network interface after boot and"},{"line_number":19,"context_line":"    # specifying a device tag for the interface"},{"line_number":20,"context_line":"    \u0027ATTACH_INTERFACE_WITH_TAG\u0027,"},{"line_number":21,"context_line":"    # traits corresponding to the allowed values of \"hw_vif_model\""},{"line_number":22,"context_line":"    # image metadata property"},{"line_number":23,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/network/model.py#L136-L149"},{"line_number":24,"context_line":"    \u0027VIF_MODEL_E1000\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_5fe73aad","line":21,"updated":"2019-05-01 20:58:15.000000000","message":"Okay, so this is more how I would have expected the others to look: with comments describing which came from https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json and which came from https://github.com/openstack/nova/blob/1f74441/nova/*","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8fae7e1cd90eac147a8b562a5d34313ffc1415ac","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    # The virt driver supports attaching a network interface after boot and"},{"line_number":19,"context_line":"    # specifying a device tag for the interface"},{"line_number":20,"context_line":"    \u0027ATTACH_INTERFACE_WITH_TAG\u0027,"},{"line_number":21,"context_line":"    # traits corresponding to the allowed values of \"hw_vif_model\""},{"line_number":22,"context_line":"    # image metadata property"},{"line_number":23,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/network/model.py#L136-L149"},{"line_number":24,"context_line":"    \u0027VIF_MODEL_E1000\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_1a99d0c2","line":21,"in_reply_to":"ffb9cba7_5fe73aad","updated":"2019-05-01 21:24:13.000000000","message":"yes i was not sure which to reference.\nthe meta defs wehre ment to be the documention for these values however they were not updated consitently and since we\nenforce this in code in nova i decided to reference then the nova code as the athoritive source instead of the metadefs.","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cbc0cbc56e00d3a79a78b36aa309b2956d8ae558","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \u0027VIF_MODEL_PCNET\u0027,"},{"line_number":29,"context_line":"    \u0027VIF_MODEL_RT18139\u0027,"},{"line_number":30,"context_line":"    \u0027VIF_MODEL_SPAPR_VLAN\u0027,"},{"line_number":31,"context_line":"    \u0027VIF_MODEL_VIRTIO\u0027,"},{"line_number":32,"context_line":"    # addional hw_vif_model values supported by nova but not documented in"},{"line_number":33,"context_line":"    # glance metadefs"},{"line_number":34,"context_line":"    \u0027VIF_MODEL_SRIOV\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_1fdc62e2","line":31,"updated":"2019-05-01 20:58:15.000000000","message":"✔","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cbc0cbc56e00d3a79a78b36aa309b2956d8ae558","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \u0027VIF_MODEL_SRIOV\u0027,"},{"line_number":35,"context_line":"    \u0027VIF_MODEL_VMXNET\u0027,"},{"line_number":36,"context_line":"    \u0027VIF_MODEL_VMXNET3\u0027,"},{"line_number":37,"context_line":"    \u0027VIF_MODEL_LAN9118\u0027,"},{"line_number":38,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_dfe1ea9c","line":37,"updated":"2019-05-01 20:58:15.000000000","message":"✔","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"79ea2fd85c8bac121794e2c7edd18b8caf24df09","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \u0027VIF_MODEL_NETFRONT\u0027,"},{"line_number":29,"context_line":"    \u0027VIF_MODEL_NE2K_PCI\u0027,"},{"line_number":30,"context_line":"    \u0027VIF_MODEL_PCNET\u0027,"},{"line_number":31,"context_line":"    \u0027VIF_MODEL_RT18139\u0027,"},{"line_number":32,"context_line":"    \u0027VIF_MODEL_SPAPR_VLAN\u0027,"},{"line_number":33,"context_line":"    \u0027VIF_MODEL_SRIOV\u0027,"},{"line_number":34,"context_line":"    \u0027VIF_MODEL_VIRTIO\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_c593edff","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":22},"updated":"2019-06-18 22:21:32.000000000","message":"RTL18139 (missing L)","commit_id":"cda9e13f6efdd38a20f047634a20b008509c0178"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1e992a174241e436c77d0b51c2ac94b2c859a737","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \u0027VIF_MODEL_NETFRONT\u0027,"},{"line_number":29,"context_line":"    \u0027VIF_MODEL_NE2K_PCI\u0027,"},{"line_number":30,"context_line":"    \u0027VIF_MODEL_PCNET\u0027,"},{"line_number":31,"context_line":"    \u0027VIF_MODEL_RT18139\u0027,"},{"line_number":32,"context_line":"    \u0027VIF_MODEL_SPAPR_VLAN\u0027,"},{"line_number":33,"context_line":"    \u0027VIF_MODEL_SRIOV\u0027,"},{"line_number":34,"context_line":"    \u0027VIF_MODEL_VIRTIO\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_f22583ac","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":22},"in_reply_to":"9fb8cfa7_c593edff","updated":"2019-06-19 16:38:38.000000000","message":"ah good spot.","commit_id":"cda9e13f6efdd38a20f047634a20b008509c0178"}],"os_traits/compute/removable_media.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cbc0cbc56e00d3a79a78b36aa309b2956d8ae558","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_cdrom_bus\""},{"line_number":17,"context_line":"    # image metadata property."},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L320-L332"},{"line_number":19,"context_line":"    \u0027BUS_MODEL_FDC\u0027,"},{"line_number":20,"context_line":"    \u0027BUS_MODEL_IDE\u0027,"},{"line_number":21,"context_line":"    \u0027BUS_MODEL_SATA\u0027,"},{"line_number":22,"context_line":"    \u0027BUS_MODEL_SCSI\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_bf9bd615","line":19,"updated":"2019-05-01 20:58:15.000000000","message":"same as https://review.opendev.org/#/c/652996/2/os_traits/compute/disk.py yah?","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8fae7e1cd90eac147a8b562a5d34313ffc1415ac","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_cdrom_bus\""},{"line_number":17,"context_line":"    # image metadata property."},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L320-L332"},{"line_number":19,"context_line":"    \u0027BUS_MODEL_FDC\u0027,"},{"line_number":20,"context_line":"    \u0027BUS_MODEL_IDE\u0027,"},{"line_number":21,"context_line":"    \u0027BUS_MODEL_SATA\u0027,"},{"line_number":22,"context_line":"    \u0027BUS_MODEL_SCSI\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_da8ed877","line":19,"in_reply_to":"ffb9cba7_bf9bd615","updated":"2019-05-01 21:24:13.000000000","message":"yes they are the same\nshould i remove and just have \n\nCOMPUTE_STORAGE_BUS_* for both?","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1326d8061efb9d8ec34cd256b82567a51509c385","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_cdrom_bus\""},{"line_number":17,"context_line":"    # image metadata property."},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L320-L332"},{"line_number":19,"context_line":"    \u0027BUS_MODEL_FDC\u0027,"},{"line_number":20,"context_line":"    \u0027BUS_MODEL_IDE\u0027,"},{"line_number":21,"context_line":"    \u0027BUS_MODEL_SATA\u0027,"},{"line_number":22,"context_line":"    \u0027BUS_MODEL_SCSI\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_dae1f89c","line":19,"in_reply_to":"ffb9cba7_da8ed877","updated":"2019-05-01 22:21:49.000000000","message":"Meh, no strong opinion; I was just confirming that they were the same.","commit_id":"b22117170bbf347d2f3b0030436f5e3910506fc2"}],"os_traits/compute/storage.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"79ea2fd85c8bac121794e2c7edd18b8caf24df09","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_disk_bus\""},{"line_number":17,"context_line":"    # image metadata property"},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L320-L332"},{"line_number":19,"context_line":"    \u0027BUS_MODEL_FDC\u0027,"},{"line_number":20,"context_line":"    \u0027BUS_MODEL_IDE\u0027,"},{"line_number":21,"context_line":"    \u0027BUS_MODEL_LXC\u0027,"},{"line_number":22,"context_line":"    \u0027BUS_MODEL_SATA\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_258e89d0","line":19,"updated":"2019-06-18 22:21:32.000000000","message":"is _MODEL necessary here?","commit_id":"cda9e13f6efdd38a20f047634a20b008509c0178"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1e992a174241e436c77d0b51c2ac94b2c859a737","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # traits corresponding to the allowed values of \"hw_disk_bus\""},{"line_number":17,"context_line":"    # image metadata property"},{"line_number":18,"context_line":"    # https://github.com/openstack/nova/blob/1f74441/nova/objects/fields.py#L320-L332"},{"line_number":19,"context_line":"    \u0027BUS_MODEL_FDC\u0027,"},{"line_number":20,"context_line":"    \u0027BUS_MODEL_IDE\u0027,"},{"line_number":21,"context_line":"    \u0027BUS_MODEL_LXC\u0027,"},{"line_number":22,"context_line":"    \u0027BUS_MODEL_SATA\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_923f67b4","line":19,"in_reply_to":"9fb8cfa7_258e89d0","updated":"2019-06-19 16:38:38.000000000","message":"am no its really not\nill shorten it.","commit_id":"cda9e13f6efdd38a20f047634a20b008509c0178"}]}