)]}'
{"doc/source/reference/index.rst":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"da6755cca13a3603b0532f461b8011d86103d204","unresolved":false,"context_lines":[{"line_number":84,"context_line":"indicate that a compute host contains support for SEV not only on-CPU,"},{"line_number":85,"context_line":"but also in all other layers of the hypervisor stack required in order"},{"line_number":86,"context_line":"to take advantage of this feature: the kernel, QEMU, and libvirt."},{"line_number":87,"context_line":"This trait is not yet usable by cloud operators or users, but the"},{"line_number":88,"context_line":"intended design can be seen in `the AMD SEV spec for nova"},{"line_number":89,"context_line":"\u003chttp://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html\u003e`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffb9cba7_c2f966c8","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":102},"updated":"2019-04-25 14:44:07.000000000","message":"Zooming out, I don\u0027t think we should do this, because versions of the os-traits library that include this trait could still be used by the forthcoming impl.\n\n(That\u0027s disregarding the rename issue.)","commit_id":"52c92ddd939bb31cc716af1d21efde73e3a1affc"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"1522205f88609dbfbc052beb26998043433f1425","unresolved":false,"context_lines":[{"line_number":84,"context_line":"indicate that a compute host contains support for SEV not only on-CPU,"},{"line_number":85,"context_line":"but also in all other layers of the hypervisor stack required in order"},{"line_number":86,"context_line":"to take advantage of this feature: the kernel, QEMU, and libvirt."},{"line_number":87,"context_line":"This trait is not yet usable by cloud operators or users, but the"},{"line_number":88,"context_line":"intended design can be seen in `the AMD SEV spec for nova"},{"line_number":89,"context_line":"\u003chttp://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html\u003e`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffb9cba7_b53cabbf","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":102},"in_reply_to":"ffb9cba7_88adcf89","updated":"2019-04-25 17:21:29.000000000","message":"Done","commit_id":"52c92ddd939bb31cc716af1d21efde73e3a1affc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7ff0afe3871317ac49f5900e02c58c31094715f4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"indicate that a compute host contains support for SEV not only on-CPU,"},{"line_number":85,"context_line":"but also in all other layers of the hypervisor stack required in order"},{"line_number":86,"context_line":"to take advantage of this feature: the kernel, QEMU, and libvirt."},{"line_number":87,"context_line":"This trait is not yet usable by cloud operators or users, but the"},{"line_number":88,"context_line":"intended design can be seen in `the AMD SEV spec for nova"},{"line_number":89,"context_line":"\u003chttp://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html\u003e`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffb9cba7_88adcf89","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":102},"in_reply_to":"ffb9cba7_a81773ed","updated":"2019-04-25 16:04:19.000000000","message":"Since you put it that way: we should remove the implementation details entirely. They don\u0027t belong in os-traits.\n\nSo I would leave L83-86 as is (though I would prefer replacing \"QEMU, and libvirt\" with something more generic; or really you could just stop after \"...of this feature\"), and delete L87-end.","commit_id":"52c92ddd939bb31cc716af1d21efde73e3a1affc"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"177877ca366343f9c92d92d6257a319636230c23","unresolved":false,"context_lines":[{"line_number":84,"context_line":"indicate that a compute host contains support for SEV not only on-CPU,"},{"line_number":85,"context_line":"but also in all other layers of the hypervisor stack required in order"},{"line_number":86,"context_line":"to take advantage of this feature: the kernel, QEMU, and libvirt."},{"line_number":87,"context_line":"This trait is not yet usable by cloud operators or users, but the"},{"line_number":88,"context_line":"intended design can be seen in `the AMD SEV spec for nova"},{"line_number":89,"context_line":"\u003chttp://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html\u003e`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffb9cba7_a81773ed","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":102},"in_reply_to":"ffb9cba7_c2f966c8","updated":"2019-04-25 15:54:31.000000000","message":"I\u0027m not sure I follow.  Presumably you don\u0027t want to keep the existing version of this sentence which was released for Stein, since it\u0027s simply incorrect.  Are you saying it should be changed to a forward-looking statement which explains when/how this trait could be used, with an assumption that the implementation which will make that forward-looking statement true will land before Train is released?","commit_id":"52c92ddd939bb31cc716af1d21efde73e3a1affc"}]}