)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31455b6e7e019bd06ee1d7c9fbaee80b4c6e342b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"[1] https://github.com/openstack/nova/blob/19.0.0/nova/virt/driver.py#L153"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I29ef5c402e0d006518bfce14f616e58f85ce7c9d"},{"line_number":26,"context_line":"Related-Bug: #1819216"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_660f7588","line":26,"range":{"start_line":26,"start_character":14,"end_line":26,"end_character":21},"updated":"2019-08-12 19:42:30.000000000","message":"Change this to bug 1748697.","commit_id":"9120358b36e520fe0c77e0e274b2defc5791b889"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"602b991ab5fc0ad75c186f084168bdc13c089f87","unresolved":false,"context_lines":[{"line_number":23,"context_line":"[1] https://github.com/openstack/nova/blob/19.0.0/nova/virt/driver.py#L153"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I29ef5c402e0d006518bfce14f616e58f85ce7c9d"},{"line_number":26,"context_line":"Related-Bug: #1819216"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_98d4feeb","line":26,"range":{"start_line":26,"start_character":14,"end_line":26,"end_character":21},"in_reply_to":"7faddb67_660f7588","updated":"2019-11-19 20:51:18.000000000","message":"Done","commit_id":"9120358b36e520fe0c77e0e274b2defc5791b889"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"540fdd2848e8afc9a0d3763ef570d4c329af0b10","unresolved":false,"context_lines":[{"line_number":31,"context_line":"would still leave the nova scheduler to filter out allocation candidates"},{"line_number":32,"context_line":"using the RequestSpec.ignore_hosts list as it does today but it\u0027s better"},{"line_number":33,"context_line":"than using a global config option in the API which could be wrong for a"},{"line_number":34,"context_line":"mixed hypervisor deployment. Long-term nova may be able to pre-filter the"},{"line_number":35,"context_line":"allocation candidates using the forbidden trait if the RequestSpec is"},{"line_number":36,"context_line":"modified (but not persisted) with the appropriate info for the cold"},{"line_number":37,"context_line":"migrate operation, e.g. hack the forbidden trait into the Flavor object"},{"line_number":38,"context_line":"embedded in the RequestSpec."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[1] https://github.com/openstack/nova/blob/19.0.0/nova/virt/driver.py#L153"},{"line_number":41,"context_line":"[2] https://review.opendev.org/676022/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_f1bbef71","line":38,"range":{"start_line":34,"start_character":29,"end_line":38,"end_character":28},"updated":"2019-12-05 19:47:24.000000000","message":"So remove this.","commit_id":"a4e27b83766be3c03f472583b0c83c735e972a82"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05840b3ffc2e641a5f163ba1da9bf0203d686440","unresolved":false,"context_lines":[{"line_number":31,"context_line":"would still leave the nova scheduler to filter out allocation candidates"},{"line_number":32,"context_line":"using the RequestSpec.ignore_hosts list as it does today but it\u0027s better"},{"line_number":33,"context_line":"than using a global config option in the API which could be wrong for a"},{"line_number":34,"context_line":"mixed hypervisor deployment. Long-term nova may be able to pre-filter the"},{"line_number":35,"context_line":"allocation candidates using the forbidden trait if the RequestSpec is"},{"line_number":36,"context_line":"modified (but not persisted) with the appropriate info for the cold"},{"line_number":37,"context_line":"migrate operation, e.g. hack the forbidden trait into the Flavor object"},{"line_number":38,"context_line":"embedded in the RequestSpec."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[1] https://github.com/openstack/nova/blob/19.0.0/nova/virt/driver.py#L153"},{"line_number":41,"context_line":"[2] https://review.opendev.org/676022/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_d4a341fe","line":38,"range":{"start_line":34,"start_character":29,"end_line":38,"end_character":28},"in_reply_to":"3fa7e38b_f1bbef71","updated":"2019-12-05 20:08:01.000000000","message":"Done","commit_id":"a4e27b83766be3c03f472583b0c83c735e972a82"}],"os_traits/compute/__init__.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"540fdd2848e8afc9a0d3763ef570d4c329af0b10","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # The virt driver supports cold migrating to the same compute service host."},{"line_number":21,"context_line":"    # This really only works for a cluster-type hypervisor driver like the"},{"line_number":22,"context_line":"    # vCenter driver which is a single compute service host managing a vCenter"},{"line_number":23,"context_line":"    # cluster of potentially hundreds of ESXi hosts."},{"line_number":24,"context_line":"    \u0027SAME_HOST_COLD_MIGRATE\u0027,"},{"line_number":25,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_91715be1","line":23,"updated":"2019-12-05 19:47:24.000000000","message":"What do you want to say here? Something like:\n\n\"\"\"Note that this is not expected to be used during cold migration scheduling in nova since how this trait gets reported and how it could be used would not work when getting allocation candidates. For example, the libvirt nodes will not report the trait but using it as a forbidden trait filter when getting allocation candidates would still return libvirt nodes which means we could attempt to cold migrate to the same libvirt node, which would fail.\"\"\"","commit_id":"a4e27b83766be3c03f472583b0c83c735e972a82"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8fc535cdb59d6ad2adc6c11ba95f5982f3d44efb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # The virt driver supports cold migrating to the same compute service host."},{"line_number":21,"context_line":"    # This really only works for a cluster-type hypervisor driver like the"},{"line_number":22,"context_line":"    # vCenter driver which is a single compute service host managing a vCenter"},{"line_number":23,"context_line":"    # cluster of potentially hundreds of ESXi hosts."},{"line_number":24,"context_line":"    \u0027SAME_HOST_COLD_MIGRATE\u0027,"},{"line_number":25,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d45581fa","line":23,"in_reply_to":"3fa7e38b_91715be1","updated":"2019-12-05 20:02:35.000000000","message":"Actually I still don\u0027t really think this is a good place for this comment. If the concern is:\n\n\u003e Having a comment to that effect in here just makes it simpler for future me to remember that reasoning any time someone proposes the patch to \"improve\" your post-filter by making it a placement request filter.\n\nThen I\u0027d argue that comment belongs where the trait is being used in nova here:\n\nhttps://review.opendev.org/#/c/695220/\n\nBecause if someone tries to change that later, that\u0027s where you\u0027d notice, not where the trait is defined.","commit_id":"a4e27b83766be3c03f472583b0c83c735e972a82"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"46d58bdeecd14c51884f7d464b2b10cebad22c3f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # The virt driver supports cold migrating to the same compute service host."},{"line_number":21,"context_line":"    # This really only works for a cluster-type hypervisor driver like the"},{"line_number":22,"context_line":"    # vCenter driver which is a single compute service host managing a vCenter"},{"line_number":23,"context_line":"    # cluster of potentially hundreds of ESXi hosts."},{"line_number":24,"context_line":"    \u0027SAME_HOST_COLD_MIGRATE\u0027,"},{"line_number":25,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_943b89c6","line":23,"in_reply_to":"3fa7e38b_91715be1","updated":"2019-12-05 20:03:21.000000000","message":"That would be okay, but my reasoning was simpler than that.\n\n\"Note that this trait will not make sense to use in GET /allocation_candidates until/unless there\u0027s a way to tie it to the condition of SAME_HOST-ness.\"","commit_id":"a4e27b83766be3c03f472583b0c83c735e972a82"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"05840b3ffc2e641a5f163ba1da9bf0203d686440","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # The virt driver supports cold migrating to the same compute service host."},{"line_number":21,"context_line":"    # This really only works for a cluster-type hypervisor driver like the"},{"line_number":22,"context_line":"    # vCenter driver which is a single compute service host managing a vCenter"},{"line_number":23,"context_line":"    # cluster of potentially hundreds of ESXi hosts."},{"line_number":24,"context_line":"    \u0027SAME_HOST_COLD_MIGRATE\u0027,"},{"line_number":25,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b49ec5b4","line":23,"in_reply_to":"3fa7e38b_943b89c6","updated":"2019-12-05 20:08:01.000000000","message":"Done","commit_id":"a4e27b83766be3c03f472583b0c83c735e972a82"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"46d58bdeecd14c51884f7d464b2b10cebad22c3f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # The virt driver supports cold migrating to the same compute service host."},{"line_number":21,"context_line":"    # This really only works for a cluster-type hypervisor driver like the"},{"line_number":22,"context_line":"    # vCenter driver which is a single compute service host managing a vCenter"},{"line_number":23,"context_line":"    # cluster of potentially hundreds of ESXi hosts."},{"line_number":24,"context_line":"    \u0027SAME_HOST_COLD_MIGRATE\u0027,"},{"line_number":25,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7467edeb","line":23,"in_reply_to":"3fa7e38b_d45581fa","updated":"2019-12-05 20:03:21.000000000","message":"I agree with that. Also, not instead.","commit_id":"a4e27b83766be3c03f472583b0c83c735e972a82"}]}