)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9db866026882c3796423a904b66f85edef3828db","unresolved":false,"context_lines":[{"line_number":12,"context_line":"out compute node allocation candidates that are disabled,"},{"line_number":13,"context_line":"similar to the post-placement ComputeFilter."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Part of nova blueprint pre-filter-disabled-computes"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ia8e4487bfb59f764a6817ec8650785ffa902eab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_06a774bf","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":51},"updated":"2019-06-24 21:01:16.000000000","message":"✔","commit_id":"74f8a3fe097bfde1cae3c58c2d8bf6f92ae192ba"}],"os_traits/compute/status.py":[{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"4e37b287812aaea1406c5a81b01d8a773a1d616d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The compute node resource provider is disabled."},{"line_number":17,"context_line":"    \u0027DISABLED\u0027,"},{"line_number":18,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_a02b7592","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":40},"updated":"2019-07-02 13:32:37.000000000","message":"nit: I guess its ``nova-compute service on the compute host`` since its the compute host that we disable (not the compute node or resource provider in the ironic case or nested rp case) but its clearly stated in the spec so its fine.","commit_id":"74f8a3fe097bfde1cae3c58c2d8bf6f92ae192ba"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4091dd9d23a0815c921e01f898e538ab47a2637b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The compute node resource provider is disabled."},{"line_number":17,"context_line":"    \u0027DISABLED\u0027,"},{"line_number":18,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_a7538a39","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":40},"in_reply_to":"9fb8cfa7_87a9a67d","updated":"2019-07-02 14:43:14.000000000","message":"The trait goes on the root compute node resource provider. The action is initiated via enabling/disabling the compute service record, yes, and then that is proxied to the compute node(s) and their respective root compute node resource provider. I\u0027m not sure how detailed this comment needs to be. The nova docs are what matter for this really - operators likely aren\u0027t going to be trying to figure this out from the os-traits code comments.","commit_id":"74f8a3fe097bfde1cae3c58c2d8bf6f92ae192ba"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f3ebd427c00a19dbc7aff2c46d28d19c7d15c877","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRAITS \u003d ["},{"line_number":16,"context_line":"    # The compute node resource provider is disabled."},{"line_number":17,"context_line":"    \u0027DISABLED\u0027,"},{"line_number":18,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_87a9a67d","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":40},"in_reply_to":"9fb8cfa7_a02b7592","updated":"2019-07-02 14:27:20.000000000","message":"I agree with your assessment and would welcome a fup to clarify this comment.","commit_id":"74f8a3fe097bfde1cae3c58c2d8bf6f92ae192ba"}]}