)]}'
{"os_traits/compute/__init__.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e8f20b6fd41a1dcef8da0b9e023e8b6e99c5454e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/share-pci-between-numa-nodes.html"},{"line_number":37,"context_line":"    \u0027NUMA_POLICY_REQUIRED\u0027,"},{"line_number":38,"context_line":"    \u0027NUMA_POLICY_PREFERRED\u0027,"},{"line_number":39,"context_line":"    \u0027NUMA_POLICY_LEGACY\u0027,"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_f024afc8","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":25},"updated":"2020-07-30 14:49:43.000000000","message":"Do we want to expose this? The only reason it exists is for buggy drivers, of which I\u0027d hope there are vanishingly few, and to preserve behavior across nova versions. Given this is going to be implemented as a new feature, do we really care about the legacy approach?","commit_id":"2ecda0124af6a7afe153177e38350fe3326b1198"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2a7866bdfe81f302ea34ed8e925d11260fa61a99","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/share-pci-between-numa-nodes.html"},{"line_number":37,"context_line":"    \u0027NUMA_POLICY_REQUIRED\u0027,"},{"line_number":38,"context_line":"    \u0027NUMA_POLICY_PREFERRED\u0027,"},{"line_number":39,"context_line":"    \u0027NUMA_POLICY_LEGACY\u0027,"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_13696d8a","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":25},"in_reply_to":"9f560f44_b309a12d","updated":"2020-07-30 15:04:05.000000000","message":"no that is not the only reason it exits.\nif a pci device does not use memory mapped io it will not have a numa affinity\nlegacy exists to allow you to have numa affinity for numa device and still use device with no numa affinity","commit_id":"2ecda0124af6a7afe153177e38350fe3326b1198"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"04a5015f6385c1c22b60c0bff09f3cdc6533b6fd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/share-pci-between-numa-nodes.html"},{"line_number":37,"context_line":"    \u0027NUMA_POLICY_REQUIRED\u0027,"},{"line_number":38,"context_line":"    \u0027NUMA_POLICY_PREFERRED\u0027,"},{"line_number":39,"context_line":"    \u0027NUMA_POLICY_LEGACY\u0027,"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b309a12d","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":25},"in_reply_to":"9f560f44_f024afc8","updated":"2020-07-30 14:52:16.000000000","message":"At least we should have the option to select it, although is not recommended. I think we should mimic the Nova behavior here.","commit_id":"2ecda0124af6a7afe153177e38350fe3326b1198"}],"os_traits/compute/net.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d465243f485b2b5ed43c40d8d19fc5a7fa879b91","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0027VIF_MODEL_VMXNET\u0027,"},{"line_number":36,"context_line":"    \u0027VIF_MODEL_VMXNET3\u0027,"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Traits corresponding to the NUMA affinity policy:"},{"line_number":39,"context_line":"    # https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/share-pci-between-numa-nodes.html"},{"line_number":40,"context_line":"    \u0027NUMA_POLICY_REQUIRED\u0027,"},{"line_number":41,"context_line":"    \u0027NUMA_POLICY_PREFERRED\u0027,"},{"line_number":42,"context_line":"    \u0027NUMA_POLICY_LEGACY\u0027,"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ae2aba7a","line":42,"range":{"start_line":38,"start_character":1,"end_line":42,"end_character":25},"updated":"2020-07-08 13:06:45.000000000","message":"i know i actully suggested thisd file on IRC\nbut i am now wonderign if this is the correct place.\n\nwe may want to use this for non nics too.\n\nso im conflicted between haveing a generic trat\nhere https://github.com/openstack/os-traits/blob/master/os_traits/misc/__init__.py or here https://github.com/openstack/os-traits/blob/master/os_traits/compute/__init__.py\n\ne.g. MISC_NUMA_* or COMPUTE_NUMA_* to avoid the net\n\nor haveing multipel numa traits in the futre to denote that we suppor polciyes for different types of devices.\n\n\ne.g. COMPUTE_NET_NUMA_* to denote nuam affintiy for network devices COMPUTE_ACCLERATORS_NUMA_* for cyborg device numa affintiy\n\n\nin the long run if we have nested resouce providers i think the generic triati applied to the correct RP is the way to go so i would sugges moving this up to \nhere https://github.com/openstack/os-traits/blob/master/os_traits/compute/__init__.py\n\nand creating COMPUTE_NUMA_* for now. \n\nthis is still a compute capablity e.g. the abilty of the comptue node to assign and instance with a numa toployg to the correct numa node to suppor the policy and  i think this is a trait that nova should report if it support it. e.g. when either pci deivces are allocatable or the numa aware vswitch feature is configured in nova.\n\nif we add numa affinity for vgpus or pmem those whoudl be examples of non nics that can have numa affinity.\n\nthe exiting exampes today are crypto cards like QAT or phsyical GPUs that can be consumed via generic pci passhough.","commit_id":"d351808472116b47dd71334b65d99bd454e06e13"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"08c98c4f91041c7744781816fa4c0283e3eb5b91","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0027VIF_MODEL_VMXNET\u0027,"},{"line_number":36,"context_line":"    \u0027VIF_MODEL_VMXNET3\u0027,"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Traits corresponding to the NUMA affinity policy:"},{"line_number":39,"context_line":"    # https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/share-pci-between-numa-nodes.html"},{"line_number":40,"context_line":"    \u0027NUMA_POLICY_REQUIRED\u0027,"},{"line_number":41,"context_line":"    \u0027NUMA_POLICY_PREFERRED\u0027,"},{"line_number":42,"context_line":"    \u0027NUMA_POLICY_LEGACY\u0027,"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2e8fca2e","line":42,"range":{"start_line":38,"start_character":1,"end_line":42,"end_character":25},"in_reply_to":"bf51134e_ae2aba7a","updated":"2020-07-08 13:18:39.000000000","message":"Ok with that, moving this to compute","commit_id":"d351808472116b47dd71334b65d99bd454e06e13"}]}