)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5426c9f3f9f4c86ad02cb440460bfe5a360a6fe2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-09 12:45:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027HW_FIRMWARE_UEFI\u0027, \u0027HW_FIRMWARE_BIOS\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allows us to report this trait and use it to filter out hosts that"},{"line_number":10,"context_line":"support our requested \u0027hw_firmware_type\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f9e59828_856478c6","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":42},"updated":"2021-08-17 16:38:41.000000000","message":"-1 technially these traits mean that the host is capably of boot in uefi or bios mode\n\nthey do not state that the host is capably of booting vms in uefi or bios mode.\n\nthose woudl be COMPUTE_FIRMWARE_*\n\nthe HW traits would have been a valid alternitive to my fireware traits form the tursted compute work i abandonded  https://review.opendev.org/c/openstack/os-traits/+/514713 \n\nthere i was creating a toplevel FW namespace.\n\n\ncan we change these too\nCOMPUTE_FIRMWARE_UEFI\u0027, \u0027COMPUTE_FIRMWARE_BIOS\u0027\n\nsince these are capabilities of the hypervisor and independent of if the hypervisor host supports booting with uefi. i.e. you can boot uefi vms on host booted with legacy bior and vis versa so teh hw namespcase is not reallly correct here.","commit_id":"ea260110175728565afd064c7ba1a6d550b9fc48"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d736e89b0b667bee6a772e0fc8a66412b0573b8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stephen Finucane \u003csfinucan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-09 12:45:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027HW_FIRMWARE_UEFI\u0027, \u0027HW_FIRMWARE_BIOS\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This allows us to report this trait and use it to filter out hosts that"},{"line_number":10,"context_line":"support our requested \u0027hw_firmware_type\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"413e2a20_7bffc4c5","line":7,"range":{"start_line":7,"start_character":2,"end_line":7,"end_character":42},"in_reply_to":"f9e59828_856478c6","updated":"2021-08-19 09:56:09.000000000","message":"Good point. I\u0027ll do that now.","commit_id":"ea260110175728565afd064c7ba1a6d550b9fc48"}]}