)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1408c0a2d0eb39f88ffe141a876b617290770f90","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a trait for the \"bochs\" display device"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027bochs\u0027 display device is a recommended[1] safe option for UEFI"},{"line_number":10,"context_line":"guests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This lets an admin set the trait either via the flavor extra-specs or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"51792938_817980f1","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":46},"updated":"2021-06-08 14:47:34.000000000","message":"your reference is evidently written in invisible ink 😉","commit_id":"9e7dfc5fff502d1a40e2ad9ae90f4e26a1a13cd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aa721916c63a52fc8404f2c794638c169eefbd66","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a trait for the \"bochs\" display device"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027bochs\u0027 display device is a recommended[1] safe option for UEFI"},{"line_number":10,"context_line":"guests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This lets an admin set the trait either via the flavor extra-specs or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"549dffd4_b6a73c00","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":46},"in_reply_to":"51792938_817980f1","updated":"2021-08-17 17:51:07.000000000","message":"it was proably ment to be too\nhttps://www.kraxel.org/blog/2019/09/display-devices-in-qemu/#tldr","commit_id":"9e7dfc5fff502d1a40e2ad9ae90f4e26a1a13cd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"620b08281fe00207f049109daff41f442dc731be","unresolved":true,"context_lines":[{"line_number":10,"context_line":"guests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This lets an admin set the trait either via the flavor extra-specs or"},{"line_number":13,"context_line":"image metadata properties:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    trait:COMPUTE_GRAPHICS_MODEL_BOCHS\u003drequired"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8d2f0649_db072e7b","line":13,"updated":"2021-06-08 14:55:28.000000000","message":"This isn\u0027t the full story. The scheduler can automatically translate a number of image metadata properties, including \u0027hw_video_model\u0027, into traits. This functionality is enabled via \u0027[scheduler] image_metadata_prefilter\u0027 and its implementation can be seen in \u0027transform_image_metadata\u0027 in \u0027nova/scheduler/request_filter.py\u0027. We need this because the libvirt driver will report this trait if libvirt itself says it supports it (via domain capabilities - see \u0027_get_video_model_traits\u0027 in \u0027nova.virt.libvirt.driver.LibvirtDriver\u0027). Without the libvirt driver reporting this trait, the scheduler won\u0027t find a host to support this.\n\nSo, tl;dr: we need this to allows the scheduler to find hosts with support for this video model when the image metadata scheduler prefilter is enabled (via \u0027[scheduler] image_metadata_prefilter\u0027).","commit_id":"9e7dfc5fff502d1a40e2ad9ae90f4e26a1a13cd6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aa721916c63a52fc8404f2c794638c169eefbd66","unresolved":true,"context_lines":[{"line_number":10,"context_line":"guests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This lets an admin set the trait either via the flavor extra-specs or"},{"line_number":13,"context_line":"image metadata properties:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    trait:COMPUTE_GRAPHICS_MODEL_BOCHS\u003drequired"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"406bc35d_5f02115c","line":13,"in_reply_to":"8d2f0649_db072e7b","updated":"2021-08-17 17:51:07.000000000","message":"yes and to enable the libviort driver to actully report it.\notherwise it woudl have to use a custom trait","commit_id":"9e7dfc5fff502d1a40e2ad9ae90f4e26a1a13cd6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6e80d461419e7ce9ac8da907f12380c6879d50d2","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    trait:COMPUTE_GRAPHICS_MODEL_BOCHS\u003drequired"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also allows The libvirt virt dirver report a standard trait"},{"line_number":18,"context_line":"for bochs graphics model support and enables the image_metadata_prefilter"},{"line_number":19,"context_line":"to automatically request the trait. This will enable vm that request"},{"line_number":20,"context_line":"the bochs graphics model to be automaticaly scheduled to hosts that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d2806668_55ed1bfd","line":17,"range":{"start_line":17,"start_character":34,"end_line":17,"end_character":40},"updated":"2021-08-19 13:54:17.000000000","message":"driver","commit_id":"0f404b4b481212867e10fd2d4656ec26e467ddeb"}]}