)]}'
{"os_traits/compute/viommu.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d7baeb1f96ed6a627019a14bb91fd8db77bfb07b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    # traits corresponding to the allowed values of \"hw_iommu_model\""},{"line_number":18,"context_line":"    # image metadata property"},{"line_number":19,"context_line":"    # Please check VIOMMUModel under /nova/objects/fields.py"},{"line_number":20,"context_line":"    \u0027MODEL_NONE\u0027,"},{"line_number":21,"context_line":"    \u0027MODEL_INTEL\u0027,"},{"line_number":22,"context_line":"    \u0027MODEL_SMMUV3\u0027,"},{"line_number":23,"context_line":"    \u0027MODEL_VIRTIO\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b534a258_e75651ff","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":17},"updated":"2022-07-18 11:31:16.000000000","message":"non is not a trait we need to report","commit_id":"aba0bd8ef3acf9736e230c120da5c5cee85a23bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"54b7c8a1f9005a31ef438164fdd8046ea3cb643b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    # traits corresponding to the allowed values of \"hw_iommu_model\""},{"line_number":18,"context_line":"    # image metadata property"},{"line_number":19,"context_line":"    # Please check VIOMMUModel under /nova/objects/fields.py"},{"line_number":20,"context_line":"    \u0027MODEL_NONE\u0027,"},{"line_number":21,"context_line":"    \u0027MODEL_INTEL\u0027,"},{"line_number":22,"context_line":"    \u0027MODEL_SMMUV3\u0027,"},{"line_number":23,"context_line":"    \u0027MODEL_VIRTIO\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"749f21b3_c4a8d05b","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":17},"in_reply_to":"b534a258_e75651ff","updated":"2022-07-28 11:22:16.000000000","message":"Done","commit_id":"aba0bd8ef3acf9736e230c120da5c5cee85a23bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d7baeb1f96ed6a627019a14bb91fd8db77bfb07b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    \u0027MODEL_INTEL\u0027,"},{"line_number":22,"context_line":"    \u0027MODEL_SMMUV3\u0027,"},{"line_number":23,"context_line":"    \u0027MODEL_VIRTIO\u0027,"},{"line_number":24,"context_line":"    \u0027MODEL_AUTO\u0027,"},{"line_number":25,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c5aec23_08e141f5","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":17},"updated":"2022-07-18 11:31:16.000000000","message":"same for auto","commit_id":"aba0bd8ef3acf9736e230c120da5c5cee85a23bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"54b7c8a1f9005a31ef438164fdd8046ea3cb643b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0027MODEL_INTEL\u0027,"},{"line_number":22,"context_line":"    \u0027MODEL_SMMUV3\u0027,"},{"line_number":23,"context_line":"    \u0027MODEL_VIRTIO\u0027,"},{"line_number":24,"context_line":"    \u0027MODEL_AUTO\u0027,"},{"line_number":25,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"e293e89e_cce3c1d0","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":17},"in_reply_to":"3c591c5a_64f83f8c","updated":"2022-07-28 11:22:16.000000000","message":"Done","commit_id":"aba0bd8ef3acf9736e230c120da5c5cee85a23bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c6936ae82eb5362dcce0ab2625667a40ed76dd99","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    \u0027MODEL_INTEL\u0027,"},{"line_number":22,"context_line":"    \u0027MODEL_SMMUV3\u0027,"},{"line_number":23,"context_line":"    \u0027MODEL_VIRTIO\u0027,"},{"line_number":24,"context_line":"    \u0027MODEL_AUTO\u0027,"},{"line_number":25,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"f62474d2_234295ff","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":17},"in_reply_to":"5c5aec23_08e141f5","updated":"2022-07-18 11:31:58.000000000","message":"auto im more open too but none shoudl not be added","commit_id":"aba0bd8ef3acf9736e230c120da5c5cee85a23bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21abcf215b4f1e937825d0c1a77d5309a63b035b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    \u0027MODEL_INTEL\u0027,"},{"line_number":22,"context_line":"    \u0027MODEL_SMMUV3\u0027,"},{"line_number":23,"context_line":"    \u0027MODEL_VIRTIO\u0027,"},{"line_number":24,"context_line":"    \u0027MODEL_AUTO\u0027,"},{"line_number":25,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c591c5a_64f83f8c","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":17},"in_reply_to":"f62474d2_234295ff","updated":"2022-07-18 11:38:41.000000000","message":"thinking about this having auto is a vaiald trait as it signifes that the virt driver can select the correct model and it will simplify the prefilter logic.\nim torn on none.\n\nthe none model means disable teh iommu but its off by default and due to the performance overhead i dont see us ever truning it on.\n\nso i would remove none and we can added it in the future if we need it for some reason.","commit_id":"aba0bd8ef3acf9736e230c120da5c5cee85a23bd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5e51c1002828e6226d5637f4a7be947eba0f8ed2","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    # traits corresponding to the allowed values of \"hw_iommu_model\""},{"line_number":18,"context_line":"    # image metadata property"},{"line_number":19,"context_line":"    # Please check VIOMMUModel under /nova/objects/fields.py"},{"line_number":20,"context_line":"    # we do not include None as by default no iommu will be provided"},{"line_number":21,"context_line":"    \u0027MODEL_INTEL\u0027,"},{"line_number":22,"context_line":"    \u0027MODEL_SMMUV3\u0027,"},{"line_number":23,"context_line":"    \u0027MODEL_VIRTIO\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c5c858d8_2686a56b","line":20,"updated":"2022-07-28 14:15:52.000000000","message":"thanks for the explanation","commit_id":"74988cdba731d9b48b15b76372da8460304ea937"}]}