)]}'
{"setup.cfg":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"df012824e0f0e791094cd4b96bf2653488819122","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"[compile_catalog]"},{"line_number":45,"context_line":"directory \u003d os_vif/locale"},{"line_number":46,"context_line":"domain \u003d os_vif"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[update_catalog]"},{"line_number":49,"context_line":"domain \u003d os_vif"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"3a57f1b5_66db35ed","line":46,"updated":"2016-02-12 04:45:20.000000000","message":"what to do for the new vif_plug_ovs domain?","commit_id":"91460d3b88eb3fbf140cf27b9d843024eafcb305"}],"vif_plug_ovs/i18n.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"83ce1a1ab8cd728cd66e71f28f7e1363e0a33676","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import oslo_i18n"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DOMAIN \u003d \u0027os_vif\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_translators \u003d oslo_i18n.TranslatorFactory(domain\u003dDOMAIN)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_5e5e7577","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":17},"updated":"2016-02-09 13:35:05.000000000","message":"do we need this file?\nwe already have it in https://github.com/openstack/os-vif/blob/master/os_vif/i18n.py","commit_id":"b18b2ddf363824b69668b7ed3c8bf220f4e9b9ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"15b2c1c3f6af18b5029946ebcc620983ef54df3e","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import oslo_i18n"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DOMAIN \u003d \u0027os_vif\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_translators \u003d oslo_i18n.TranslatorFactory(domain\u003dDOMAIN)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_e878c22d","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":17},"in_reply_to":"5a5ae5dd_12b3110c","updated":"2016-02-09 14:26:49.000000000","message":"actully that i dont know.\n\n@dan  should this be DOMAIN \u003d \u0027vif_plug_ovs\u0027 ?\n\nlooking at \n\nhttps://github.com/jaypipes/vif_plug_vhostuser/blob/master/vif_plug_vhostuser/i18n.py\n\nhttps://github.com/jaypipes/vif_plug_ovs/blob/master/vif_plug_ovs/i18n.py\n\nand \n\nhttps://github.com/jaypipes/vif_plug_hw_veb/blob/master/vif_plug_hw_veb/i18n.py\n\nthis is always \u0027os_vif\u0027\n\nif it is always the same im not sure what the value is over just importing the module form os_vif/i18n.py but if it shoudl be different then the plugin name makes sense to me.\n\n\nalso i just noticed that you dont have the i18n.py and exceptions.py files in the Linux bridge patch.\nwe should be consistent between these two.","commit_id":"b18b2ddf363824b69668b7ed3c8bf220f4e9b9ad"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"df3840a1d08838068a0b8130382482e9f2f413ff","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import oslo_i18n"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DOMAIN \u003d \u0027os_vif\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_translators \u003d oslo_i18n.TranslatorFactory(domain\u003dDOMAIN)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_12b3110c","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":17},"in_reply_to":"5a5ae5dd_325c0ded","updated":"2016-02-09 13:50:51.000000000","message":"Ok,\nso is it ok we are using the same domain as in \nhttps://github.com/openstack/os-vif/blob/master/os_vif/i18n.py#L23\nshouldn\u0027t it be DOMAIN \u003d \u0027vif_plug_ovs\u0027","commit_id":"b18b2ddf363824b69668b7ed3c8bf220f4e9b9ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d7fad093da3d16d3cb9bbfd59faafecd32f39b58","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import oslo_i18n"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DOMAIN \u003d \u0027os_vif\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_translators \u003d oslo_i18n.TranslatorFactory(domain\u003dDOMAIN)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_325c0ded","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":17},"in_reply_to":"5a5ae5dd_5e5e7577","updated":"2016-02-09 13:44:58.000000000","message":"we also already have https://review.openstack.org/#/c/273610/5/vif_plug_ovs/exception.py here https://github.com/openstack/os-vif/blob/master/os_vif/exception.py\n\nthat is why i was questioning if we should have a \nos_vif/common folder to this file, the exception class and the linux_net modules shared.\n\nif the intention is for the \nos-vif/vif_plug_ovs subtree to be clonable as\na stand alone plugin then we should keep this file if we expect plugins to ship there own internationalization resources.","commit_id":"b18b2ddf363824b69668b7ed3c8bf220f4e9b9ad"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"ccec9df5755c3ca6c6fef5e33cd162742bce08e1","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import oslo_i18n"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DOMAIN \u003d \u0027os_vif\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"_translators \u003d oslo_i18n.TranslatorFactory(domain\u003dDOMAIN)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_06c5cf59","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":17},"in_reply_to":"5a5ae5dd_e878c22d","updated":"2016-02-11 11:43:54.000000000","message":"Yes it should be \u0027vif_plug_ovs\u0027.  We don\u0027t have i18n in linux_bridge, because there\u0027s no specific exceptions we currently need to raise.","commit_id":"b18b2ddf363824b69668b7ed3c8bf220f4e9b9ad"}],"vif_plug_ovs/linux_net.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95ad7c6db2bc13b257cdc64ec3f71ddd8756b88e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_d06b6aef","updated":"2016-02-02 00:22:09.000000000","message":"should this be plug specific.\nthere is also a linux_net in the linux bridge plugin\nhttps://review.openstack.org/#/c/273609/2/vif_plug_linux_bridge/linux_net.py\n\nthese should probably combined to prevent duplication.","commit_id":"f08c7f18e7006a6ccdc9da8d68d88506127e85a4"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e2a0342286db60033338ad814b93e84e1be0fef4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a5de9d1_a944391b","in_reply_to":"7a5de9d1_d06b6aef","updated":"2016-02-02 09:22:19.000000000","message":"Actually there is no all that much code duplication - I deleted most of the code from linux_net to just leave the stuff that was needed by the plugin impl.\n\nWe don\u0027t want people to consider linux_net a public API, so we don\u0027t want it under the shared os_vif python namespace.\n\nFinally the intention of the vif_plug impls is that they illustrate how you would structure an out-of-tree plugin, so we want them to be self-contained and linux_bridge/ovs not to share any code except for the public os_vif module namespace.\n\nie it should be possible to copy the vif_plug_linux_bridge subdirectory into its own standalone git repo with no code changes.","commit_id":"f08c7f18e7006a6ccdc9da8d68d88506127e85a4"}]}