)]}'
{"vif_plug_ovs/ovs_hybrid.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7034456a47fa0f5cfedca6c29f092a5e5a8190f2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            processutils.execute(\u0027tee\u0027, syspath, process_input\u003d\u00270\u0027,"},{"line_number":88,"context_line":"                                 check_exit_code\u003d[0, 1],"},{"line_number":89,"context_line":"                                 run_as_root\u003dTrue)"},{"line_number":90,"context_line":"            disv6 \u003d (\u0027/proc/sys/net/ipv6/conf/%s/disable_ipv6\u0027 %"},{"line_number":91,"context_line":"                     vif.bridge_name)"},{"line_number":92,"context_line":"            if os.path.exists(disv6):"},{"line_number":93,"context_line":"                processutils.execute(\u0027tee\u0027,"},{"line_number":94,"context_line":"                                     disv6,"},{"line_number":95,"context_line":"                                     process_input\u003d\u00271\u0027,"},{"line_number":96,"context_line":"                                     run_as_root\u003dTrue,"},{"line_number":97,"context_line":"                                     check_exit_code\u003d[0, 1])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if not linux_net.device_exists(v2_name):"},{"line_number":100,"context_line":"            linux_net.create_veth_pair(v1_name, v2_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_27be20d5","line":97,"range":{"start_line":90,"start_character":12,"end_line":97,"end_character":60},"updated":"2016-02-09 05:58:39.000000000","message":"should this interface ever have an ip v4 or v6 assigned?\n\ni think not\n\nan alternative would be to use ip address flush here\n\n processutils.execute(\u0027ip addr flush dev %s\u0027% vif.bridge_name , process_input\u003d\u00270\u0027,\n                                 check_exit_code\u003d[0, 1],\n                                 run_as_root\u003dTrue)","commit_id":"826edfd290c1f379a725479f0847e58a623819c9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"fe7d377dd96e01e5da84f6801ca9531674011bc6","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            processutils.execute(\u0027tee\u0027, syspath, process_input\u003d\u00270\u0027,"},{"line_number":88,"context_line":"                                 check_exit_code\u003d[0, 1],"},{"line_number":89,"context_line":"                                 run_as_root\u003dTrue)"},{"line_number":90,"context_line":"            disv6 \u003d (\u0027/proc/sys/net/ipv6/conf/%s/disable_ipv6\u0027 %"},{"line_number":91,"context_line":"                     vif.bridge_name)"},{"line_number":92,"context_line":"            if os.path.exists(disv6):"},{"line_number":93,"context_line":"                processutils.execute(\u0027tee\u0027,"},{"line_number":94,"context_line":"                                     disv6,"},{"line_number":95,"context_line":"                                     process_input\u003d\u00271\u0027,"},{"line_number":96,"context_line":"                                     run_as_root\u003dTrue,"},{"line_number":97,"context_line":"                                     check_exit_code\u003d[0, 1])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if not linux_net.device_exists(v2_name):"},{"line_number":100,"context_line":"            linux_net.create_veth_pair(v1_name, v2_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_e9c3f188","line":97,"range":{"start_line":90,"start_character":12,"end_line":97,"end_character":60},"in_reply_to":"5a5ae5dd_27be20d5","updated":"2016-02-09 11:11:42.000000000","message":"It shouldn\u0027t have any addresses on it at all. The only reason it would end up with an IPv6 address is due to  address auto-config, so by disabling ipv6, we disable autoconfig and thus prevent the address appearing in the first place. This is probably more reliable than just flushing current addresses, as it prevents chance of auto-config address ever coming back in the future.\n\nBTW, this is just importing the equivalent nova change as-is","commit_id":"826edfd290c1f379a725479f0847e58a623819c9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b7437612b17735d188efba8e9d6da12d596d2fc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            processutils.execute(\u0027tee\u0027, syspath, process_input\u003d\u00270\u0027,"},{"line_number":88,"context_line":"                                 check_exit_code\u003d[0, 1],"},{"line_number":89,"context_line":"                                 run_as_root\u003dTrue)"},{"line_number":90,"context_line":"            disv6 \u003d (\u0027/proc/sys/net/ipv6/conf/%s/disable_ipv6\u0027 %"},{"line_number":91,"context_line":"                     vif.bridge_name)"},{"line_number":92,"context_line":"            if os.path.exists(disv6):"},{"line_number":93,"context_line":"                processutils.execute(\u0027tee\u0027,"},{"line_number":94,"context_line":"                                     disv6,"},{"line_number":95,"context_line":"                                     process_input\u003d\u00271\u0027,"},{"line_number":96,"context_line":"                                     run_as_root\u003dTrue,"},{"line_number":97,"context_line":"                                     check_exit_code\u003d[0, 1])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if not linux_net.device_exists(v2_name):"},{"line_number":100,"context_line":"            linux_net.create_veth_pair(v1_name, v2_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_9e514d11","line":97,"range":{"start_line":90,"start_character":12,"end_line":97,"end_character":60},"in_reply_to":"5a5ae5dd_e9c3f188","updated":"2016-02-09 13:23:27.000000000","message":"ok yes that makes sense to me. unless we have a reason to handle it differently we should probably keep this the same as the nova change then to keep the behavior as similar as we transition to os-vif","commit_id":"826edfd290c1f379a725479f0847e58a623819c9"}]}