)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"50c937b6be54b5ba21ad0d075d95257a38500919","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for vhost-user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change introduces a ovs vhost user plug driver"},{"line_number":10,"context_line":"- This change will be consumed by the reference openvswitch"},{"line_number":11,"context_line":"  ml2 driver, networking-odl and networking-ovn to enable"},{"line_number":12,"context_line":"  vhost-user with openvswitch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_e97b3279","line":9,"updated":"2016-05-22 23:08:05.000000000","message":"Technically, the above is incorrect. What this patch does is allow the existing OVS plugin to handle vhostuser VIF types. I think it\u0027s worth correcting since we want to be clear that we are not adding a new driver or plugin but instead adding support within an existing os-vif plugin for a new VIF type.","commit_id":"0ed7879287b9fb08f087b2a9c7847789dcd87edd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ee23f14f0baa5e24240443b05d0ffda2b3f593ae","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for vhost-user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change introduces a ovs vhost user plug driver"},{"line_number":10,"context_line":"- This change will be consumed by the reference openvswitch"},{"line_number":11,"context_line":"  ml2 driver, networking-odl and networking-ovn to enable"},{"line_number":12,"context_line":"  vhost-user with openvswitch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_29625a0a","line":9,"in_reply_to":"bab6814e_e97b3279","updated":"2016-05-23 01:00:49.000000000","message":"your right the v1 of this patch added a new driver but the decision was made to merge the hybrid pug driver and non hybrid plug driver so i followed suit\n\ni for got to update this. \nthanks jay ill fix in next version.","commit_id":"0ed7879287b9fb08f087b2a9c7847789dcd87edd"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b3c67b2a08db7769d7d4e0e457e66c29958d2726","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  os-vif vif objects as part of plug and unplug function calls."},{"line_number":12,"context_line":"- This change will be consumed by the reference openvswitch"},{"line_number":13,"context_line":"  ml2 driver, networking-odl and networking-ovn to enable"},{"line_number":14,"context_line":"  vhost-user with openvswitch."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ifa53e5e821093459ab7a390ff8af26028b2a9056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7aa08908_25ba326f","line":14,"updated":"2016-06-09 15:03:51.000000000","message":"++ good commit message now.","commit_id":"8c58816f4663868db5530c8fce7fcf1e91e3deab"}],"releasenotes/notes/add-ovs-vhostuser-support-2ba8de51c1f3a244.yaml":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"50c937b6be54b5ba21ad0d075d95257a38500919","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The ovs plugin has been extended to support"},{"line_number":4,"context_line":"    vhost-user interfaces. vhost-user is a userspace"},{"line_number":5,"context_line":"    protocol for highspeed virtual networking introduced"},{"line_number":6,"context_line":"    in qemu 2.1 and first supported in ovs 2.4 with dpdk 2.0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_c97e2e69","line":5,"updated":"2016-05-22 23:08:05.000000000","message":"s/highspeed/high speed/","commit_id":"0ed7879287b9fb08f087b2a9c7847789dcd87edd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ee23f14f0baa5e24240443b05d0ffda2b3f593ae","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The ovs plugin has been extended to support"},{"line_number":4,"context_line":"    vhost-user interfaces. vhost-user is a userspace"},{"line_number":5,"context_line":"    protocol for highspeed virtual networking introduced"},{"line_number":6,"context_line":"    in qemu 2.1 and first supported in ovs 2.4 with dpdk 2.0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_a9348afb","line":5,"in_reply_to":"bab6814e_c97e2e69","updated":"2016-05-23 01:00:49.000000000","message":"yep will fix in next version","commit_id":"0ed7879287b9fb08f087b2a9c7847789dcd87edd"}],"vif_plug_ovs/constants.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"0d941593e5e68122d5f254b654e1b2ec1c272f64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bab6814e_c8bee5fe","line":2,"updated":"2016-05-18 10:01:33.000000000","message":"missing copyright","commit_id":"7e279b5464ea48492e4796d8c49f237f6adc20a1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8cb00114b1c05e6d9c2dab20443d2a2c40236b67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bab6814e_2204e57c","line":2,"in_reply_to":"bab6814e_c8bee5fe","updated":"2016-05-18 12:25:32.000000000","message":"should i add openstack or intel here as the copyright owner.\n\ntechnically as part of the contributors license agreement we grant copyright of the code to the openstack foundation but im not sure if only staff of the openstack foundation are ment to use the use the openstack copyright.\n\nill add lintel\u0027s for now but i can change it later.\n\nin a follow up commit i want to move some of the random strings in the plugin to constants in this file.","commit_id":"7e279b5464ea48492e4796d8c49f237f6adc20a1"}],"vif_plug_ovs/linux_net.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"0d941593e5e68122d5f254b654e1b2ec1c272f64","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    if interface_type !\u003d constants.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":72,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        LOG.debug(\"MTU not set on %(interface_name)s interface \""},{"line_number":75,"context_line":"                  \"of type %(interface_type)s.\","},{"line_number":76,"context_line":"                  {\u0027interface_name\u0027: dev,"},{"line_number":77,"context_line":"                   \u0027interface_type\u0027: interface_type})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_4835d544","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":17},"updated":"2016-05-18 10:01:33.000000000","message":"should this be a warning","commit_id":"7e279b5464ea48492e4796d8c49f237f6adc20a1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8cb00114b1c05e6d9c2dab20443d2a2c40236b67","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    if interface_type !\u003d constants.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":72,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        LOG.debug(\"MTU not set on %(interface_name)s interface \""},{"line_number":75,"context_line":"                  \"of type %(interface_type)s.\","},{"line_number":76,"context_line":"                  {\u0027interface_name\u0027: dev,"},{"line_number":77,"context_line":"                   \u0027interface_type\u0027: interface_type})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_c23199ee","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":17},"in_reply_to":"bab6814e_4835d544","updated":"2016-05-18 12:25:32.000000000","message":"this comes from a port of the logic i introduced in nova where they said it should be a debug message not a warning.\n\nhttps://github.com/openstack/nova/commit/adf7ba61dd73fe4bfffa20295be9a4b1006a1fe6\n\ni would prefer to keep consistent with nova implementation.\n\ni also don\u0027t think this should be a warning as it is the expected behavior. a warning implies something went wrong which is not the case. the debug message is only intended to be consume when debugging the code not by an operator.","commit_id":"7e279b5464ea48492e4796d8c49f237f6adc20a1"}],"vif_plug_ovs/ovs_vhostuser.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"c4c7c2dca860485f6294108386cdc8596dab82ba","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # should only be called to plug vhost-user port"},{"line_number":37,"context_line":"        # to ovs. generic vhost-user should be supported"},{"line_number":38,"context_line":"        # in a seperate plug driver."},{"line_number":39,"context_line":"        if vif.vhostuser_ovs_plug:"},{"line_number":40,"context_line":"            iface_id \u003d vif.ovs_interfaceid"},{"line_number":41,"context_line":"            port_name \u003d os.path.basename(vif.vhostuser_socket)"},{"line_number":42,"context_line":"            linux_net.create_ovs_vif_port(vif.bridge_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_15ffd2aa","line":39,"updated":"2016-02-29 11:53:45.000000000","message":"THis does not exist in our data model. There is a  \u0027portprofile\u0027 which provides OVS port profile parameters","commit_id":"05d6c5eb2495496202683e5c8ab8389eeb57a48d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e19662c3c1ecca1e02e4b93e8c37ab7ba4e8ec82","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # should only be called to plug vhost-user port"},{"line_number":37,"context_line":"        # to ovs. generic vhost-user should be supported"},{"line_number":38,"context_line":"        # in a seperate plug driver."},{"line_number":39,"context_line":"        if vif.vhostuser_ovs_plug:"},{"line_number":40,"context_line":"            iface_id \u003d vif.ovs_interfaceid"},{"line_number":41,"context_line":"            port_name \u003d os.path.basename(vif.vhostuser_socket)"},{"line_number":42,"context_line":"            linux_net.create_ovs_vif_port(vif.bridge_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_ffeafb72","line":39,"in_reply_to":"9aed3d3a_15ffd2aa","updated":"2016-02-29 15:59:07.000000000","message":"thanks :) \nthis is taken for \nhttps://github.com/jaypipes/vif_plug_vhostuser\ni have started the port to how the os-vif libary \nnow structured but this patch is not functional yet.","commit_id":"05d6c5eb2495496202683e5c8ab8389eeb57a48d"}]}