)]}'
{"vif_plug_linux_bridge/iptables.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c6ab55dfbab85e252f4186fd27e51506562e5f81","unresolved":false,"context_lines":[{"line_number":357,"context_line":"            s +\u003d [(ip6tables_save, ip6tables_restore, self.ipv6)]"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        for save, restore, tables in s:"},{"line_number":360,"context_line":"            all_tables, _err \u003d save()"},{"line_number":361,"context_line":"            all_lines \u003d all_tables.split(\u0027\\n\u0027)"},{"line_number":362,"context_line":"            for table_name, table in six.iteritems(tables):"},{"line_number":363,"context_line":"                start, end \u003d self._find_table(all_lines, table_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_1bc79b46","line":360,"range":{"start_line":360,"start_character":24,"end_line":360,"end_character":28},"updated":"2016-03-15 11:40:40.000000000","message":"should we have an error check here?\n\nif not _err :\n... rest of cod e below","commit_id":"fa4c2fd7e7879d7d65884a5e26a57a48bc54af00"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"57057d0a7449d920cc485656c40cc560bd7c4ca1","unresolved":false,"context_lines":[{"line_number":357,"context_line":"            s +\u003d [(ip6tables_save, ip6tables_restore, self.ipv6)]"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        for save, restore, tables in s:"},{"line_number":360,"context_line":"            all_tables, _err \u003d save()"},{"line_number":361,"context_line":"            all_lines \u003d all_tables.split(\u0027\\n\u0027)"},{"line_number":362,"context_line":"            for table_name, table in six.iteritems(tables):"},{"line_number":363,"context_line":"                start, end \u003d self._find_table(all_lines, table_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_01dd6e42","line":360,"range":{"start_line":360,"start_character":24,"end_line":360,"end_character":28},"in_reply_to":"1af94dfe_1bc79b46","updated":"2016-03-15 11:57:48.000000000","message":"Yes, but that\u0027s a pre-existing bug in this code, so should be addressed in a separate patch","commit_id":"fa4c2fd7e7879d7d65884a5e26a57a48bc54af00"}],"vif_plug_linux_bridge/linux_net.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c6ab55dfbab85e252f4186fd27e51506562e5f81","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"@lockutils.synchronized(\u0027nova-lock_vlan\u0027, external\u003dTrue)"},{"line_number":65,"context_line":"def _ensure_vlan_privileged(vlan_num, bridge_interface, mac_address, mtu):"},{"line_number":66,"context_line":"    \"\"\"Create a vlan unless it already exists.\"\"\""},{"line_number":67,"context_line":"    interface \u003d \u0027vlan%s\u0027 % vlan_num"},{"line_number":68,"context_line":"    if not device_exists(interface):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_1b231b07","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":27},"updated":"2016-03-15 11:40:40.000000000","message":"should the @privsep.vif_plug.entrypoint decorator be added her also?\n\ni need to read more about how the new oslo libary works\nbut without marking this as privileged im not sure why you have changed the name.","commit_id":"fa4c2fd7e7879d7d65884a5e26a57a48bc54af00"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"57057d0a7449d920cc485656c40cc560bd7c4ca1","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"@lockutils.synchronized(\u0027nova-lock_vlan\u0027, external\u003dTrue)"},{"line_number":65,"context_line":"def _ensure_vlan_privileged(vlan_num, bridge_interface, mac_address, mtu):"},{"line_number":66,"context_line":"    \"\"\"Create a vlan unless it already exists.\"\"\""},{"line_number":67,"context_line":"    interface \u003d \u0027vlan%s\u0027 % vlan_num"},{"line_number":68,"context_line":"    if not device_exists(interface):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_a18c7a36","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":27},"in_reply_to":"1af94dfe_1b231b07","updated":"2016-03-15 11:57:48.000000000","message":"This method is only called by methods which are already decorated with @privsep.vif_plug.entrypoint. I changed the name to illustrate that this code will be running with elevated privileged","commit_id":"fa4c2fd7e7879d7d65884a5e26a57a48bc54af00"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"58c0c2cedff53fef6e47be877af30e12ad1fb97a","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"@lockutils.synchronized(\u0027nova-lock_vlan\u0027, external\u003dTrue)"},{"line_number":65,"context_line":"def _ensure_vlan_privileged(vlan_num, bridge_interface, mac_address, mtu):"},{"line_number":66,"context_line":"    \"\"\"Create a vlan unless it already exists.\"\"\""},{"line_number":67,"context_line":"    interface \u003d \u0027vlan%s\u0027 % vlan_num"},{"line_number":68,"context_line":"    if not device_exists(interface):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_c130a60a","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":27},"in_reply_to":"1af94dfe_a18c7a36","updated":"2016-03-15 12:07:45.000000000","message":"you added a leading _ to mark it as private so i guess that is a safe assumption to make. can you add a short comment to that effect though as ill probably forget that it is inheriting its privilege status from the caller if i look at this code in a few months.","commit_id":"fa4c2fd7e7879d7d65884a5e26a57a48bc54af00"}],"vif_plug_linux_bridge/privsep.py":[{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"d4351b7d17416cd515d7fa2d2312100d8e570431","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cfg_section\u003d\"vif_plug_linux_bridge_privileged\","},{"line_number":22,"context_line":"    pypath\u003d__name__ + \".vif_plug\","},{"line_number":23,"context_line":"    capabilities\u003d[c.CAP_SYS_ADMIN,"},{"line_number":24,"context_line":"                  c.CAP_NET_ADMIN],"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_d43e7828","line":24,"updated":"2016-04-04 01:12:21.000000000","message":"NET_ADMIN is obvious, but do we need SYS_ADMIN too?\n\nIn particular, creating/destroying network namespaces requires SYS_ADMIN, but I don\u0027t think os-vif does that?\n\n(SYS_ADMIN allows quite a lot of scary things, so would be good to avoid unless necessary)","commit_id":"28bac2c721e5ae4bbf7bbdbbb761785e85e10e30"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"74f8f1624fe883644178689ca3ffa09a0037a384","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cfg_section\u003d\"vif_plug_linux_bridge_privileged\","},{"line_number":22,"context_line":"    pypath\u003d__name__ + \".vif_plug\","},{"line_number":23,"context_line":"    capabilities\u003d[c.CAP_SYS_ADMIN,"},{"line_number":24,"context_line":"                  c.CAP_NET_ADMIN],"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_14b925ea","line":24,"in_reply_to":"ba0121b8_d43e7828","updated":"2016-04-04 11:45:08.000000000","message":"I think we can probably avoid it","commit_id":"28bac2c721e5ae4bbf7bbdbbb761785e85e10e30"}]}
