)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bee723f237119024167741a869b1589c1c86957c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel P. Berrange \u003cberrange@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-08 12:01:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"os_vif: add logging for each plugin that is loaded"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When debugging problems it is helpful to know which plugins"},{"line_number":10,"context_line":"have been loaded. Ensure this is reported by emitting info"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_0ac82573","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":50},"updated":"2016-06-08 15:18:11.000000000","message":"this read like you are doing logging on a per plugin basis rather then logging the name of each plugin loaded.\n\nperhaps the following would be clearer\nos_vif: log name of each plugin that is loaded","commit_id":"8d0cf252e0a4390fa95d2d9c50a523b6485fa7dd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f63734f51961939db4fb2b5abae5552b87de9b84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel P. Berrange \u003cberrange@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-09 11:35:31 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"os_vif: add logging for each plugin that is loaded"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When debugging problems it is helpful to know which plugins"},{"line_number":10,"context_line":"have been loaded. Ensure this is reported by emitting info"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_f7075216","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"updated":"2016-06-09 10:41:21.000000000","message":"i still think renaming this would be clearer \nbut its just a nit so im ok with this as it is.\ne.g.\n\nos_vif: log name of each plugin that is loaded","commit_id":"d78a33ee900bff4b47087383206f10bed03fcfc7"}],"os_vif/__init__.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bee723f237119024167741a869b1589c1c86957c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        for plugin_name in _EXT_MANAGER.names():"},{"line_number":44,"context_line":"            cls \u003d _EXT_MANAGER[plugin_name].plugin"},{"line_number":45,"context_line":"            obj \u003d cls.load(plugin_name)"},{"line_number":46,"context_line":"            LOG.info(\"Loaded VIF plugin class \u0027%s\u0027 with name \u0027%s\u0027\","},{"line_number":47,"context_line":"                     cls, plugin_name)"},{"line_number":48,"context_line":"            _EXT_MANAGER[plugin_name].obj \u003d obj"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4a07cd81","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":20},"updated":"2016-06-08 15:18:11.000000000","message":"should this be LOG.debug as it is introduced to simplify debugging or do you think that operators will want to see this also?","commit_id":"8d0cf252e0a4390fa95d2d9c50a523b6485fa7dd"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"99f028e89c06461b63d627fb470ae77c78f99e59","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        for plugin_name in _EXT_MANAGER.names():"},{"line_number":44,"context_line":"            cls \u003d _EXT_MANAGER[plugin_name].plugin"},{"line_number":45,"context_line":"            obj \u003d cls.load(plugin_name)"},{"line_number":46,"context_line":"            LOG.info(\"Loaded VIF plugin class \u0027%s\u0027 with name \u0027%s\u0027\","},{"line_number":47,"context_line":"                     cls, plugin_name)"},{"line_number":48,"context_line":"            _EXT_MANAGER[plugin_name].obj \u003d obj"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_cd4e373a","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":20},"in_reply_to":"7aa08908_4a07cd81","updated":"2016-06-08 15:24:22.000000000","message":"For the plugins that are built-in (ovs/linux-bridge) it is no big deal, but for people using the add-on plugins from external packages, I think it\u0027d be quite useful if we show that they\u0027re present on startup, hence my thought to use LOG.info rather than just debug.","commit_id":"8d0cf252e0a4390fa95d2d9c50a523b6485fa7dd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c6026eb5fb642846b4ffa351f55ce631499500a8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        for plugin_name in _EXT_MANAGER.names():"},{"line_number":44,"context_line":"            cls \u003d _EXT_MANAGER[plugin_name].plugin"},{"line_number":45,"context_line":"            obj \u003d cls.load(plugin_name)"},{"line_number":46,"context_line":"            LOG.info(\"Loaded VIF plugin class \u0027%s\u0027 with name \u0027%s\u0027\","},{"line_number":47,"context_line":"                     cls, plugin_name)"},{"line_number":48,"context_line":"            _EXT_MANAGER[plugin_name].obj \u003d obj"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_9466cc27","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":20},"in_reply_to":"7aa08908_cd4e373a","updated":"2016-06-09 10:39:17.000000000","message":"ok yes LOG.info works for me too i just was not sure if you wanted it to be visable on startup or not but i see the use in having it there also.","commit_id":"8d0cf252e0a4390fa95d2d9c50a523b6485fa7dd"}]}