)]}'
{"vif_plug_ovs/linux_net.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6259ba1a112bd13f3c61745c87ed8b82023defc0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   interface_type))"},{"line_number":69,"context_line":"    # Note at present there is no support for setting the"},{"line_number":70,"context_line":"    # mtu for vhost-user type ports."},{"line_number":71,"context_line":"    if mtu and interface_type !\u003d constants.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":72,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        LOG.debug(\"MTU not set on %(interface_name)s interface \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_2cfcb23d","line":71,"updated":"2016-06-10 08:47:57.000000000","message":"This is just a general bug fix, not really anything Windows specific in fact.","commit_id":"7a470d0babe8a743e7f567f757cf92df3f6db4ed"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"381fecc51313b695032f78e0e42501f309598565","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   interface_type))"},{"line_number":69,"context_line":"    # Note at present there is no support for setting the"},{"line_number":70,"context_line":"    # mtu for vhost-user type ports."},{"line_number":71,"context_line":"    if mtu and interface_type !\u003d constants.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":72,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        LOG.debug(\"MTU not set on %(interface_name)s interface \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_4cc5bb3b","line":71,"in_reply_to":"7aa08908_2cfcb23d","updated":"2016-06-10 09:53:06.000000000","message":"actully i think this should be covered by \nhttps://review.openstack.org/#/c/287709/\n\nill reach out to ihar and see if he wants me to rebase his mtu change","commit_id":"7a470d0babe8a743e7f567f757cf92df3f6db4ed"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6375d936962d96e27e0a8b867b915e512fbc2f65","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   interface_type))"},{"line_number":69,"context_line":"    # Note at present there is no support for setting the"},{"line_number":70,"context_line":"    # mtu for vhost-user type ports."},{"line_number":71,"context_line":"    if mtu and interface_type !\u003d constants.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":72,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        LOG.debug(\"MTU not set on %(interface_name)s interface \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_2f6e61c9","line":71,"updated":"2016-06-10 09:55:11.000000000","message":"Now you will generate a debug message every time no mtu is specified, I\u0027m not sure whether we would really want that much logging.","commit_id":"2c96373d5e5e2dd13b4ad09ad862ad50be7ec8a6"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"819e8f7e826eff0ee71ab5fd5c31a442ed0c6d36","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   interface_type))"},{"line_number":69,"context_line":"    # Note at present there is no support for setting the"},{"line_number":70,"context_line":"    # mtu for vhost-user type ports."},{"line_number":71,"context_line":"    if mtu and interface_type !\u003d constants.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":72,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        LOG.debug(\"MTU not set on %(interface_name)s interface \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_4fc92d79","line":71,"in_reply_to":"7aa08908_2f6e61c9","updated":"2016-06-10 09:57:48.000000000","message":"debug logging is just fine for this case - if it was INFO or higher then I\u0027d complain, but for debug level, anything is valid. It is useful to have explicit notice that we\u0027re skipping the mtu setting.","commit_id":"2c96373d5e5e2dd13b4ad09ad862ad50be7ec8a6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de10620f240644f3d23b108d5d4da384ba45ba41","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   interface_type))"},{"line_number":69,"context_line":"    # Note at present there is no support for setting the"},{"line_number":70,"context_line":"    # mtu for vhost-user type ports."},{"line_number":71,"context_line":"    if mtu and interface_type !\u003d constants.OVS_VHOSTUSER_INTERFACE_TYPE:"},{"line_number":72,"context_line":"        _set_device_mtu(dev, mtu)"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        LOG.debug(\"MTU not set on %(interface_name)s interface \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_2fb4a1f0","line":71,"in_reply_to":"7aa08908_2f6e61c9","updated":"2016-06-10 09:57:43.000000000","message":"it is a debug level message rather then info so it will not show in production normally.\n\nin general this will only be seen in development setups in which case i think its ok.","commit_id":"2c96373d5e5e2dd13b4ad09ad862ad50be7ec8a6"}],"vif_plug_ovs/privsep.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6259ba1a112bd13f3c61745c87ed8b82023defc0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"if sys.platform \u003d\u003d \u0027win32\u0027:"},{"line_number":29,"context_line":"    # NOTE(claudiub): oslo.privsep is not supported on Windows, as it uses"},{"line_number":30,"context_line":"    # some Linux-specific functionality (os.fork, socket.AF_UNIX)."},{"line_number":31,"context_line":"    vif_plug.set_client_mode(False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0ce2969f","line":31,"updated":"2016-06-10 08:47:57.000000000","message":"IMHO this is really the wrong place - if privsep helper can\u0027t work on windows, then change the client mode default in the olso.privsep codebase instead. This limitation isn\u0027t anything specific to vif_plug_ovs - all users are affected and its stupid to make every usage of privsep do the same change.","commit_id":"7a470d0babe8a743e7f567f757cf92df3f6db4ed"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"381fecc51313b695032f78e0e42501f309598565","unresolved":false,"context_lines":[{"line_number":28,"context_line":"if sys.platform \u003d\u003d \u0027win32\u0027:"},{"line_number":29,"context_line":"    # NOTE(claudiub): oslo.privsep is not supported on Windows, as it uses"},{"line_number":30,"context_line":"    # some Linux-specific functionality (os.fork, socket.AF_UNIX)."},{"line_number":31,"context_line":"    vif_plug.set_client_mode(False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0f5a852a","line":31,"in_reply_to":"7aa08908_0ce2969f","updated":"2016-06-10 09:53:06.000000000","message":"if we were to make this change here i think i would prefer it \nto be a config option rather then an explicit check against the os.","commit_id":"7a470d0babe8a743e7f567f757cf92df3f6db4ed"}],"vif_plug_ovs/tests/test_linux_net.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"381fecc51313b695032f78e0e42501f309598565","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.assertFalse(mock_set_device_mtu.called)"},{"line_number":158,"context_line":"        self.assertTrue(mock_vsctl.called)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    @mock.patch.object(linux_net, \u0027_ovs_vsctl\u0027)"},{"line_number":161,"context_line":"    @mock.patch.object(linux_net, \u0027_create_ovs_vif_cmd\u0027)"},{"line_number":162,"context_line":"    @mock.patch.object(linux_net, \u0027_set_device_mtu\u0027)"},{"line_number":163,"context_line":"    def test_ovs_vif_port_with_no_mtu(self, mock_set_device_mtu,"},{"line_number":164,"context_line":"                                      mock_create_cmd, mock_vsctl):"},{"line_number":165,"context_line":"        linux_net.create_ovs_vif_port("},{"line_number":166,"context_line":"            \u0027fake-bridge\u0027,"},{"line_number":167,"context_line":"            \u0027fake-dev\u0027, \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":168,"context_line":"            \"fake-instance-uuid\")"},{"line_number":169,"context_line":"        mock_create_cmd.assert_called_once_with(\u0027fake-bridge\u0027,"},{"line_number":170,"context_line":"            \u0027fake-dev\u0027, \u0027fake-iface-id\u0027, \u0027fake-mac\u0027,"},{"line_number":171,"context_line":"            \"fake-instance-uuid\", None)"},{"line_number":172,"context_line":"        self.assertFalse(mock_set_device_mtu.called)"},{"line_number":173,"context_line":"        self.assertTrue(mock_vsctl.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_4c3adb35","line":173,"range":{"start_line":160,"start_character":4,"end_line":173,"end_character":42},"updated":"2016-06-10 09:53:06.000000000","message":"test looks good to me","commit_id":"7a470d0babe8a743e7f567f757cf92df3f6db4ed"}]}
