)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"56d4794c533c042509911c0451c9236e70eb6c19","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maria Malyarova \u003csavoreux69@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-15 16:13:56 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplification of checking the value \"got\" to the limits \"get_common_version\" def. Furthermore a small changes in PEP8"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TrivialFix"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_d03479e0","line":7,"updated":"2016-07-15 13:17:27.000000000","message":"You\u0027ve mixed multiple changes in one commit here.\n\nThe condition checking logic change should be separate from the pep8 changes. \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes\n\nAlso don\u0027t try to explain the entire commit in a first line of commit message text. There should be a short first line, then blank, then a description\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"f43ca70d89cb4fa499c8934c440cf88829652058"},{"author":{"_account_id":22590,"name":"Maria Malyarova","email":"savoreux69@gmail.com","username":"gaassassins"},"change_message_id":"0af07a09fb674a7556ab5c2279298c379fc293f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maria Malyarova \u003csavoreux69@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-15 16:13:56 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplification of checking the value \"got\" to the limits \"get_common_version\" def. Furthermore a small changes in PEP8"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TrivialFix"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_33c86774","line":7,"in_reply_to":"1aa78d24_d03479e0","updated":"2016-07-15 13:41:30.000000000","message":"Thank you, Daniel! I\u0027ll fixed it.","commit_id":"f43ca70d89cb4fa499c8934c440cf88829652058"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7f6a8610a761c6bca75f75a1885c07b14775bfe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maria Malyarova \u003csavoreux69@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-15 16:13:56 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplification of checking the value \"got\" to the limits \"get_common_version\" def. Furthermore a small changes in PEP8"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TrivialFix"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_13b44b33","line":7,"in_reply_to":"1aa78d24_d03479e0","updated":"2016-07-15 13:41:13.000000000","message":"i belive there is alos a pep8 check that enforces the\nline lengths for the title at \u003c 70 characters\nand \u003c80 for the body of the commit message so this will not pass gating in its current form.\n\ngenerally its recommended to keep the title ~50 characters with no \".\" at the end.","commit_id":"f43ca70d89cb4fa499c8934c440cf88829652058"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43a28ae71ddd4674ca3a00c9fbbaf148b03f00ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplified if statement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Simplification of checking the value \"got\" to the limits \"get_common_version\""},{"line_number":10,"context_line":"TrivialFix"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If233b5f1e3162fde74e63e83e015be585d395ba2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_93b2fbe3","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":77},"updated":"2016-07-15 13:44:18.000000000","message":"this looks like its over 80 charaters so i think this will fail the pep8 check. other then that the simplification looks good.","commit_id":"d66f18690f7e22b252f1a09202ae6a7c2d59185a"},{"author":{"_account_id":22590,"name":"Maria Malyarova","email":"savoreux69@gmail.com","username":"gaassassins"},"change_message_id":"83484fdfd203868a619e603db2b17d135252341e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplified if statement"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Simplification of checking the value \"got\" to the limits \"get_common_version\""},{"line_number":10,"context_line":"TrivialFix"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If233b5f1e3162fde74e63e83e015be585d395ba2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_f3537f6a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":77},"in_reply_to":"1aa78d24_93b2fbe3","updated":"2016-07-15 13:47:08.000000000","message":"Got it. Done, thx u!","commit_id":"d66f18690f7e22b252f1a09202ae6a7c2d59185a"}],"os_vif/objects/host_info.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7f6a8610a761c6bca75f75a1885c07b14775bfe","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"from os_vif import exception"},{"line_number":13,"context_line":"from os_vif.objects import base as osv_base"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_versionedobjects import base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"@base.VersionedObjectRegistry.register"},{"line_number":19,"context_line":"class HostVIFInfo(osv_base.VersionedObject, base.ComparableVersionedObject):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_53bc13db","line":16,"range":{"start_line":12,"start_character":0,"end_line":16,"end_character":40},"updated":"2016-07-15 13:41:13.000000000","message":"i dont know if pep8 even suggest that you structure import in this order.\n\nthese are two seperate import groups for module within the same porject and module in an external project e.g. oslo.\n\nthe ordering i have seen im many openstack projects is \n\nsystem modules\nopenstack moules from other porjects\nmodules from local projects\n\nfor example \nhttps://github.com/openstack/nova/blob/7a8f1369c5dd9d6a6260ba0c168d06e9f0016d33/nova/virt/libvirt/vif.py#L20-L36\n\nso in general i dont see any reason to make this change.","commit_id":"f43ca70d89cb4fa499c8934c440cf88829652058"}]}