)]}'
{"os_vif/objects/network.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b6310dfb1e12ea8ed0ff6593b5c0257fac47dfb6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Represents a network.\"\"\""},{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    # Version 1.1: Added MTU field"},{"line_number":25,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"        \u0027id\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_6496b7f1","line":25,"updated":"2016-09-15 10:13:57.000000000","message":"don\u0027t we need a backporting rule for 1.0?","commit_id":"39b17bbc21efb1645d1722ce09e3e50ad80d5c2f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"1aea80d013d973ad37b7c1c4115433b2bb2d7eae","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Represents a network.\"\"\""},{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    # Version 1.1: Added MTU field"},{"line_number":25,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"        \u0027id\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_f7643be6","line":25,"in_reply_to":"7a8ec9b2_6496b7f1","updated":"2016-09-15 10:18:45.000000000","message":"I\u0027m not sure. I was looking at a bunch of nova objects that just add fields and they don\u0027t seem to have downgrade methods.\n\ne.g. https://github.com/openstack/nova/blob/master/nova/objects/instance_group.py#L122-L146","commit_id":"39b17bbc21efb1645d1722ce09e3e50ad80d5c2f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"37046e3d59215c3e1e86fe3758bddfd5b6346d9b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Represents a network.\"\"\""},{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    # Version 1.1: Added MTU field"},{"line_number":25,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"        \u0027id\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_a6a6ff0d","line":25,"in_reply_to":"7a8ec9b2_f596f34a","updated":"2016-09-15 11:52:24.000000000","message":"Done","commit_id":"39b17bbc21efb1645d1722ce09e3e50ad80d5c2f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"3b7fb1a93fa8a0bb1529d4262ea2bfaa840c2142","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"Represents a network.\"\"\""},{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    # Version 1.1: Added MTU field"},{"line_number":25,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    fields \u003d {"},{"line_number":28,"context_line":"        \u0027id\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_f596f34a","line":25,"in_reply_to":"7a8ec9b2_f7643be6","updated":"2016-09-15 11:03:00.000000000","message":"Yes, now that we\u0027ve done an os-vif release, we need to have teh back-levelling support to drop mtu when serializing to 1.0 version","commit_id":"39b17bbc21efb1645d1722ce09e3e50ad80d5c2f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cc7499323b664ab2eb130c6672a0650c17c128dd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":50,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":51,"context_line":"        if target_version \u003c (1, 1):"},{"line_number":52,"context_line":"            primitive.pop(\u0027mtu\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_7fcf0029","line":52,"updated":"2016-09-15 20:34:20.000000000","message":"These objects have never been passed over the wire and therefore there is currently no \"older\" Nova asking for \"newer\" os-vif objects, so I\u0027m not sure this is absolutely necessary actually. But probably doesn\u0027t hurt.","commit_id":"f3130fe8e23fb07532bb3d740fffaf07481c1e70"}],"vif_plug_linux_bridge/linux_bridge.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b6310dfb1e12ea8ed0ff6593b5c0257fac47dfb6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if not network.multi_host and network.should_provide_bridge:"},{"line_number":98,"context_line":"            if network.should_provide_vlan:"},{"line_number":99,"context_line":"                iface \u003d self.config.vlan_interface or network.bridge_interface"},{"line_number":100,"context_line":"                if vif.network and vif.network.mtu:"},{"line_number":101,"context_line":"                    mtu \u003d vif.network.mtu"},{"line_number":102,"context_line":"                else:"},{"line_number":103,"context_line":"                    mtu \u003d self.config.network_device_mtu"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_c4ba2b6e","line":100,"range":{"start_line":100,"start_character":19,"end_line":100,"end_character":30},"updated":"2016-09-15 10:13:57.000000000","message":"nit: already captured as \u0027network\u0027 in line 95.","commit_id":"39b17bbc21efb1645d1722ce09e3e50ad80d5c2f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"37046e3d59215c3e1e86fe3758bddfd5b6346d9b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if not network.multi_host and network.should_provide_bridge:"},{"line_number":98,"context_line":"            if network.should_provide_vlan:"},{"line_number":99,"context_line":"                iface \u003d self.config.vlan_interface or network.bridge_interface"},{"line_number":100,"context_line":"                if vif.network and vif.network.mtu:"},{"line_number":101,"context_line":"                    mtu \u003d vif.network.mtu"},{"line_number":102,"context_line":"                else:"},{"line_number":103,"context_line":"                    mtu \u003d self.config.network_device_mtu"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_063ed3b7","line":100,"range":{"start_line":100,"start_character":19,"end_line":100,"end_character":30},"in_reply_to":"7a8ec9b2_c4ba2b6e","updated":"2016-09-15 11:52:24.000000000","message":"Done","commit_id":"39b17bbc21efb1645d1722ce09e3e50ad80d5c2f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b552c64900e70096ed75150311259df01320dd64","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if not network.multi_host and network.should_provide_bridge:"},{"line_number":98,"context_line":"            if network.should_provide_vlan:"},{"line_number":99,"context_line":"                iface \u003d self.config.vlan_interface or network.bridge_interface"},{"line_number":100,"context_line":"                if network and network.mtu:"},{"line_number":101,"context_line":"                    mtu \u003d vif.network.mtu"},{"line_number":102,"context_line":"                else:"},{"line_number":103,"context_line":"                    mtu \u003d self.config.network_device_mtu"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_88a03145","line":100,"updated":"2016-09-15 12:20:54.000000000","message":"I think you could drop the \"network and\" part here, given how much network.something is being used in the enclosing if statements","commit_id":"c7eea4401b6e09f61f5654bf24cfdf575ae0c130"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b552c64900e70096ed75150311259df01320dd64","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if network.should_provide_vlan:"},{"line_number":99,"context_line":"                iface \u003d self.config.vlan_interface or network.bridge_interface"},{"line_number":100,"context_line":"                if network and network.mtu:"},{"line_number":101,"context_line":"                    mtu \u003d vif.network.mtu"},{"line_number":102,"context_line":"                else:"},{"line_number":103,"context_line":"                    mtu \u003d self.config.network_device_mtu"},{"line_number":104,"context_line":"                linux_net.ensure_vlan_bridge(network.vlan,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_089501dd","line":101,"updated":"2016-09-15 12:20:54.000000000","message":"Just network.mtu as in the line above?","commit_id":"c7eea4401b6e09f61f5654bf24cfdf575ae0c130"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cc7499323b664ab2eb130c6672a0650c17c128dd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if not network.multi_host and network.should_provide_bridge:"},{"line_number":98,"context_line":"            if network.should_provide_vlan:"},{"line_number":99,"context_line":"                iface \u003d self.config.vlan_interface or network.bridge_interface"},{"line_number":100,"context_line":"                mtu \u003d network.mtu or self.config.network_device_mtu"},{"line_number":101,"context_line":"                linux_net.ensure_vlan_bridge(network.vlan,"},{"line_number":102,"context_line":"                                             bridge_name, iface, mtu\u003dmtu)"},{"line_number":103,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_7f338062","line":100,"updated":"2016-09-15 20:34:20.000000000","message":"This should probably be:\n\n mtu \u003d self.config.network_device_mtu\n if hasattr(network, \u0027mtu\u0027) and network.obj_attr_is_set(\u0027mtu\u0027):\n     mtu \u003d network.mtu\n\nHowever these objects aren\u0027t being passed over the wire so I\u0027m not sure it\u0027s really necessary...","commit_id":"f3130fe8e23fb07532bb3d740fffaf07481c1e70"}],"vif_plug_ovs/ovs.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cc7499323b664ab2eb130c6672a0650c17c128dd","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if vif.network and vif.network.mtu:"},{"line_number":87,"context_line":"            mtu \u003d vif.network.mtu"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            mtu \u003d self.config.network_device_mtu"},{"line_number":90,"context_line":"        linux_net.create_ovs_vif_port("},{"line_number":91,"context_line":"            vif.network.bridge,"},{"line_number":92,"context_line":"            vif_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_9febec77","line":89,"updated":"2016-09-15 20:34:20.000000000","message":"in the other plugin you do:\n\n mtu \u003d network.mtu or self.config.network_device_mtu\n\nmight be nice to be consistent, but meh :)","commit_id":"f3130fe8e23fb07532bb3d740fffaf07481c1e70"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cc7499323b664ab2eb130c6672a0650c17c128dd","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            if vif.network and vif.network.mtu:"},{"line_number":122,"context_line":"                mtu \u003d vif.network.mtu"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                mtu \u003d self.config.network_device_mtu"},{"line_number":125,"context_line":"            linux_net.create_veth_pair(v1_name, v2_name, mtu)"},{"line_number":126,"context_line":"            linux_net.add_bridge_port(vif.bridge_name, v1_name)"},{"line_number":127,"context_line":"            linux_net.ensure_ovs_bridge(vif.network.bridge,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_1ff8bc48","line":124,"updated":"2016-09-15 20:34:20.000000000","message":"ditto","commit_id":"f3130fe8e23fb07532bb3d740fffaf07481c1e70"}]}