)]}'
{"os_vif/objects/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ed5054f815e44f7d259f96933eb1b67d0a2528de","unresolved":false,"context_lines":[{"line_number":112,"context_line":"class VIFVHostUser(VIFBase):"},{"line_number":113,"context_line":"    # For libvirt drivers, this maps to type\u003d\u0027vhostuser\u0027"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    fields \u003d {"},{"line_number":118,"context_line":"        # Name of the vhostuser port to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_6be11bd0","line":115,"range":{"start_line":115,"start_character":4,"end_line":115,"end_character":19},"updated":"2016-10-25 19:01:18.000000000","message":"since we have had a release of os-vif i belive we will need to bump the version to 1.1 and have correct dowgade code to remove the filed for v1.0 objects. dan/jay  can you confim that is correct?","commit_id":"84d69c179add43c32fc4afd9f8b9ef06aa2d1acb"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"407b69e1958ee5d1d3211396fc954c5c9a2f18a1","unresolved":false,"context_lines":[{"line_number":112,"context_line":"class VIFVHostUser(VIFBase):"},{"line_number":113,"context_line":"    # For libvirt drivers, this maps to type\u003d\u0027vhostuser\u0027"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    fields \u003d {"},{"line_number":118,"context_line":"        # Name of the vhostuser port to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_6088ade8","line":115,"in_reply_to":"ba5da102_4c793f2f","updated":"2016-10-27 08:44:06.000000000","message":"Yes so we probably don\u0027t have to remove that field for a target under version 1.1","commit_id":"84d69c179add43c32fc4afd9f8b9ef06aa2d1acb"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"97a8fedac765ed9a369102aac8533657763f6557","unresolved":false,"context_lines":[{"line_number":112,"context_line":"class VIFVHostUser(VIFBase):"},{"line_number":113,"context_line":"    # For libvirt drivers, this maps to type\u003d\u0027vhostuser\u0027"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    fields \u003d {"},{"line_number":118,"context_line":"        # Name of the vhostuser port to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_4c793f2f","line":115,"range":{"start_line":115,"start_character":4,"end_line":115,"end_character":19},"in_reply_to":"da6895a0_6be11bd0","updated":"2016-10-26 09:03:32.000000000","message":"Yes, please update the version number and add a note about what is updated in version 1.1 of the object schema. We\u0027re not yet passing any objects over the wire yet, so technically speaking nothing is going to break if you don\u0027t increment the version, but it\u0027s good practice to get into.","commit_id":"84d69c179add43c32fc4afd9f8b9ef06aa2d1acb"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d00e0596a83115481018c7db7d3006178118dac3","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # UNIX socket access permissions"},{"line_number":125,"context_line":"        \u0027mode\u0027: osv_fields.VIFVHostUserModeField(),"},{"line_number":126,"context_line":"    }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"@base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_00d7ce23","line":126,"updated":"2016-10-28 12:43:44.000000000","message":"We\u0027ll need an obj_make_compatible method to drop it for 1.0 compat","commit_id":"355f7902ed614e62c33d410b3164790362145230"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02847fbdff3b531e538c845fb7b578923dd0ced5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":138,"context_line":"        super(VIFBase, self).obj_make_compatible(primitive, target_version)"},{"line_number":139,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":140,"context_line":"        if (target_version \u003c (1, 1)"},{"line_number":141,"context_line":"           and \u0027vif_name\u0027 in primitive[\u0027versioned_object.data\u0027]):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_f9d98c84","line":138,"updated":"2016-10-31 16:38:26.000000000","message":"super(VIFVHostUser, self)...","commit_id":"e6950fc38620cd2301eaa8ae0d470644d810c17c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02847fbdff3b531e538c845fb7b578923dd0ced5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":140,"context_line":"        if (target_version \u003c (1, 1)"},{"line_number":141,"context_line":"           and \u0027vif_name\u0027 in primitive[\u0027versioned_object.data\u0027]):"},{"line_number":142,"context_line":"                del primitive[\u0027versioned_object.data\u0027][\u0027vif_name\u0027]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"@base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_19e9e014","line":142,"updated":"2016-10-31 16:38:26.000000000","message":"You don\u0027t need to check the \u0027versioned_object.data\u0027 key. Just check the primitive top-level dict:\n\n if target_version \u003c (1, 1) and \u0027vif_name\u0027 in primitive:\n     del primitive[\u0027vif_name\u0027]\n\nHere\u0027s an example from Nova you can use to find more information on this method:\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L102","commit_id":"e6950fc38620cd2301eaa8ae0d470644d810c17c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"26b70c2ae6a4ee2d54f9321222d746f89eeb12cb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":140,"context_line":"        if (target_version \u003c (1, 1)"},{"line_number":141,"context_line":"           and \u0027vif_name\u0027 in primitive[\u0027versioned_object.data\u0027]):"},{"line_number":142,"context_line":"                del primitive[\u0027versioned_object.data\u0027][\u0027vif_name\u0027]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"@base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_a70b0e7c","line":142,"in_reply_to":"ba5da102_085ecc11","updated":"2016-11-28 16:02:26.000000000","message":"Jay is right, this should not have to dig down through the namespacing level. See this example in a base o.vo test:\n\nhttps://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/tests/test_objects.py#L114-L119\n\nI haven\u0027t pulled down your code to see why you think you need this, but I think that if you do, something else is wrong.","commit_id":"e6950fc38620cd2301eaa8ae0d470644d810c17c"},{"author":{"_account_id":17671,"name":"Francesco Santoro","email":"fraroot@gmail.com","username":"francesco.santoro"},"change_message_id":"9940e6dd9fe4ac5e0ab1be261adba5da86392bcc","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":140,"context_line":"        if (target_version \u003c (1, 1)"},{"line_number":141,"context_line":"           and \u0027vif_name\u0027 in primitive[\u0027versioned_object.data\u0027]):"},{"line_number":142,"context_line":"                del primitive[\u0027versioned_object.data\u0027][\u0027vif_name\u0027]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"@base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_085ecc11","line":142,"in_reply_to":"ba5da102_19e9e014","updated":"2016-11-01 15:39:01.000000000","message":"Based on my understanding, here I need this approach because I suppose \u0027primitive\u0027 is in the format returned by the ovo VersionedObject class ( https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L537 ) that embeds the fields dictionary in a more complex structure.\nIn the example you linked you don\u0027t have to check the \u0027versioned_object.data\u0027 key because the \u0027primitive\u0027 is computed using this different method (https://github.com/openstack/nova/blob/master/nova/objects/base.py#L316) that simply returns the fields dict.\nSo here I see two possible approaches: keep the current implementation or implement a different obj_to_primitive method for the VIFBase class.\nPlease correct me if I am wrong.","commit_id":"e6950fc38620cd2301eaa8ae0d470644d810c17c"}],"releasenotes/notes/extend-vhostuser-object-fada14a1457d4e56.yaml":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"18d211fa9be2fdb7bea2ed01559223d4b31860f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The vhostuser vif object has been modified to add the name of the"},{"line_number":4,"context_line":"    vhostuser port. Previously to this modification, it was responsability"},{"line_number":5,"context_line":"    of ovs plugin to compute such name. This should not be nomore necessary"},{"line_number":6,"context_line":"    with this new field. Because of this new field the VIFVHostUser object"},{"line_number":7,"context_line":"    version has been updated accordingly (to 1.1)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5da102_405b862e","line":4,"updated":"2016-10-28 12:35:20.000000000","message":"s/responsability/responsibility/","commit_id":"355f7902ed614e62c33d410b3164790362145230"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"18d211fa9be2fdb7bea2ed01559223d4b31860f9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The vhostuser vif object has been modified to add the name of the"},{"line_number":4,"context_line":"    vhostuser port. Previously to this modification, it was responsability"},{"line_number":5,"context_line":"    of ovs plugin to compute such name. This should not be nomore necessary"},{"line_number":6,"context_line":"    with this new field. Because of this new field the VIFVHostUser object"},{"line_number":7,"context_line":"    version has been updated accordingly (to 1.1)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5da102_c0479649","line":5,"updated":"2016-10-28 12:35:20.000000000","message":"s/nomore//","commit_id":"355f7902ed614e62c33d410b3164790362145230"}]}
