)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a06c1f52826028c2972c38eb4835d6541a26ddd5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add host port profile info class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change introduces a new HostPortProfileInfo"},{"line_number":10,"context_line":"  class to model the support port profile of each"},{"line_number":11,"context_line":"  os-vif vif object."},{"line_number":12,"context_line":"- This change splits oslo version object version"},{"line_number":13,"context_line":"  tests into a common test moodule."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a1ced50_ecb83fe8","line":10,"updated":"2017-03-16 17:21:58.000000000","message":"did you mean to say \"to model the *supported* port profile\"? or \"to model the port profile\"?","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f09f06919711be988fcf75ade6abbee24ff399ae","unresolved":false,"context_lines":[{"line_number":7,"context_line":"add host port profile info class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change introduces a new HostPortProfileInfo"},{"line_number":10,"context_line":"  class to model the support port profile of each"},{"line_number":11,"context_line":"  os-vif vif object."},{"line_number":12,"context_line":"- This change splits oslo version object version"},{"line_number":13,"context_line":"  tests into a common test moodule."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a1ced50_d7b30c09","line":10,"in_reply_to":"1a1ced50_ecb83fe8","updated":"2017-03-16 17:36:29.000000000","message":"to model the *supported* port profile\n\ni would like to ajust the describe method in each of the plugins to declare what port profiles are supported by each vif\nhttps://github.com/openstack/os-vif/blob/414a35768d9bbeb09dd73163a2bae441534e2ca6/vif_plug_ovs/ovs.py#L67-L83","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"}],"os_vif/exception.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ecf6d3b0bb25c477aa4f3f51156924f2b5b55819","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class NoSupportedVIFVersion(ExceptionBase):"},{"line_number":69,"context_line":"    msg_fmt \u003d _(\"VIF class %(name)s versions %(got_versions)s \""},{"line_number":70,"context_line":"                \"do not satisfy min\u003d%(min_version)s max\u003d%(max_version)s\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_2924e1c5","line":69,"range":{"start_line":69,"start_character":29,"end_line":69,"end_character":33},"updated":"2017-09-04 14:26:19.000000000","message":"unrelated?","commit_id":"b7b46d09d90544d44e5f84bd44d2d11448ab1aaa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e12b047450c536bce6c845edb9cbe3d25cd3425","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class NoSupportedVIFVersion(ExceptionBase):"},{"line_number":69,"context_line":"    msg_fmt \u003d _(\"VIF class %(name)s versions %(got_versions)s \""},{"line_number":70,"context_line":"                \"do not satisfy min\u003d%(min_version)s max\u003d%(max_version)s\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_2f94e143","line":69,"range":{"start_line":69,"start_character":29,"end_line":69,"end_character":33},"in_reply_to":"7f287b81_2924e1c5","updated":"2017-09-04 15:18:54.000000000","message":"no see https://review.openstack.org/#/c/441590/7/os_vif/objects/host_info.py line 39\n\nthe key name changed for vif_name to name so this is needed.","commit_id":"b7b46d09d90544d44e5f84bd44d2d11448ab1aaa"}],"os_vif/objects/host_info.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a06c1f52826028c2972c38eb4835d6541a26ddd5","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        # object name of the subclass of os_vif.objects.vif.VIFPortProfileBase"},{"line_number":32,"context_line":"        \"port_profile_name\": fields.StringField(),"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        # String representing the earliest version of @name"},{"line_number":35,"context_line":"        # that the plugin understands"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_6cefefb0","line":32,"updated":"2017-03-16 17:21:58.000000000","message":"suggest naming this field \"profile_object_name\" to be consistent with the HostVIFInfo object and to be more clear about what the field contains.","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f09f06919711be988fcf75ade6abbee24ff399ae","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        # object name of the subclass of os_vif.objects.vif.VIFPortProfileBase"},{"line_number":32,"context_line":"        \"port_profile_name\": fields.StringField(),"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        # String representing the earliest version of @name"},{"line_number":35,"context_line":"        # that the plugin understands"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_f772c8ac","line":32,"in_reply_to":"1a1ced50_6cefefb0","updated":"2017-03-16 17:36:29.000000000","message":"am yes that meakses sense to me ill change when i resping.","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a06c1f52826028c2972c38eb4835d6541a26ddd5","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_common_version(self):"},{"line_number":44,"context_line":"        def _vers_tuple(ver):"},{"line_number":45,"context_line":"            return tuple([int(x) for x in ver.split(\".\")])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        reg \u003d base.VersionedObjectRegistry.obj_classes()"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_8cb50bd2","line":45,"updated":"2017-03-16 17:21:58.000000000","message":"nit: might be worth pulling this out into a utils function, since it\u0027s copied from line 108...","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f09f06919711be988fcf75ade6abbee24ff399ae","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def get_common_version(self):"},{"line_number":44,"context_line":"        def _vers_tuple(ver):"},{"line_number":45,"context_line":"            return tuple([int(x) for x in ver.split(\".\")])"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        reg \u003d base.VersionedObjectRegistry.obj_classes()"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_9736f4b2","line":45,"in_reply_to":"1a1ced50_8cb50bd2","updated":"2017-03-16 17:36:29.000000000","message":"will do","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a06c1f52826028c2972c38eb4835d6541a26ddd5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            maxwant \u003d _vers_tuple(self.max_version)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            if minwant \u003c\u003d got \u003c\u003d maxwant:"},{"line_number":61,"context_line":"                return regobj.VERSION"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        raise exception.NoSupportedPortProfileVersion("},{"line_number":64,"context_line":"            port_profile_name\u003dself.port_profile_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_ac1647a5","line":61,"updated":"2017-03-16 17:21:58.000000000","message":"Can probably more the above into a utils function too, since it\u0027s duped code from below...","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f09f06919711be988fcf75ade6abbee24ff399ae","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            maxwant \u003d _vers_tuple(self.max_version)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            if minwant \u003c\u003d got \u003c\u003d maxwant:"},{"line_number":61,"context_line":"                return regobj.VERSION"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        raise exception.NoSupportedPortProfileVersion("},{"line_number":64,"context_line":"            port_profile_name\u003dself.port_profile_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_57555cc4","line":61,"in_reply_to":"1a1ced50_ac1647a5","updated":"2017-03-16 17:36:29.000000000","message":"will do","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a06c1f52826028c2972c38eb4835d6541a26ddd5","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    obj_relationships \u003d {"},{"line_number":80,"context_line":"        \u0027port_profile_info\u0027: ((\u00271.1\u0027, None),)"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    fields \u003d {"},{"line_number":84,"context_line":"        # object name of the subclass of os_vif.objects.vif.VIFBase"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_ac7d67e9","line":81,"updated":"2017-03-16 17:21:58.000000000","message":"I don\u0027t believe this is needed with modern o.vo?","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"908c0ab62e221ff90807495d3c59d0dd5158b728","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    obj_relationships \u003d {"},{"line_number":80,"context_line":"        \u0027port_profile_info\u0027: ((\u00271.1\u0027, None),)"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    fields \u003d {"},{"line_number":84,"context_line":"        # object name of the subclass of os_vif.objects.vif.VIFBase"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_06ea1aab","line":81,"in_reply_to":"1a1ced50_1741243a","updated":"2017-08-01 16:59:50.000000000","message":"Sean, you are dealing with this conversion in \"obj_make_compatible\".\n\nIf version \u003c 1.1, you delete port_profile_info.\n\nThere is no need for this here.","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f09f06919711be988fcf75ade6abbee24ff399ae","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    obj_relationships \u003d {"},{"line_number":80,"context_line":"        \u0027port_profile_info\u0027: ((\u00271.1\u0027, None),)"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    fields \u003d {"},{"line_number":84,"context_line":"        # object name of the subclass of os_vif.objects.vif.VIFBase"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_1741243a","line":81,"in_reply_to":"1a1ced50_ac7d67e9","updated":"2017-03-16 17:36:29.000000000","message":"there are 2 ways of doing it currently.\nthis or with metadata.\n\nwithouth this i was getting an error and i did not find examples or the other method.","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b05c2a6935de218fac38bc253d0c90aa4b109fa","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    obj_relationships \u003d {"},{"line_number":80,"context_line":"        \u0027port_profile_info\u0027: ((\u00271.1\u0027, None),)"},{"line_number":81,"context_line":"    }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    fields \u003d {"},{"line_number":84,"context_line":"        # object name of the subclass of os_vif.objects.vif.VIFBase"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_16c8f01f","line":81,"in_reply_to":"df3967d1_06ea1aab","updated":"2017-08-02 11:02:28.000000000","message":"yes but i was still getting an error without this.","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a06c1f52826028c2972c38eb4835d6541a26ddd5","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    obj_relationships \u003d {"},{"line_number":141,"context_line":"        \u0027vif_info\u0027: ((\u00271.1\u0027, \u00271.0\u0027),),"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    fields \u003d {"},{"line_number":145,"context_line":"        # name of the plugin"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_0c267b16","line":142,"updated":"2017-03-16 17:21:58.000000000","message":"This shouldn\u0027t be needed?","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f09f06919711be988fcf75ade6abbee24ff399ae","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    obj_relationships \u003d {"},{"line_number":141,"context_line":"        \u0027vif_info\u0027: ((\u00271.1\u0027, \u00271.0\u0027),),"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    fields \u003d {"},{"line_number":145,"context_line":"        # name of the plugin"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_97e8b418","line":142,"in_reply_to":"1a1ced50_0c267b16","updated":"2017-03-16 17:36:29.000000000","message":"this one specifically i think can be omitted but the one above is required to work around an error that is trown by ovo if its not present.","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"908c0ab62e221ff90807495d3c59d0dd5158b728","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    obj_relationships \u003d {"},{"line_number":141,"context_line":"        \u0027vif_info\u0027: ((\u00271.1\u0027, \u00271.0\u0027),),"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    fields \u003d {"},{"line_number":145,"context_line":"        # name of the plugin"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_5109fe92","line":142,"in_reply_to":"1a1ced50_97e8b418","updated":"2017-08-01 16:59:50.000000000","message":"The object itself didn\u0027t change, only one of the field objects.","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b05c2a6935de218fac38bc253d0c90aa4b109fa","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    obj_relationships \u003d {"},{"line_number":141,"context_line":"        \u0027vif_info\u0027: ((\u00271.1\u0027, \u00271.0\u0027),),"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    fields \u003d {"},{"line_number":145,"context_line":"        # name of the plugin"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_f6656c46","line":142,"in_reply_to":"df3967d1_5109fe92","updated":"2017-08-02 11:02:28.000000000","message":"yes that is correct but we do need version bump whenever that is done.\nwe may not need the obj_relationship though as i dont think this was throwing an error i just added it to be consitent with HostVIFInfo where it was needed.","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d596be80b44d4ae0477e7bbac89bcfb049bfdf5","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    obj_relationships \u003d {"},{"line_number":141,"context_line":"        \u0027vif_info\u0027: ((\u00271.1\u0027, \u00271.0\u0027),),"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    fields \u003d {"},{"line_number":145,"context_line":"        # name of the plugin"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_673ae434","line":142,"in_reply_to":"df3967d1_f6656c46","updated":"2017-08-02 12:36:52.000000000","message":"I understand this, but we should be strict handling OVO versions.\n\nThere are many examples in Nova code, for example, about bumping the version of a field object (HostVIFInfo in this case) and not increasing the version of the container object (HostPluginInfo here).\n\nThere is no need for that. Any possible compatibility conversion will be made when handling HostVIFInfo.","commit_id":"30c5ebe4f137cf36cccdbaa6cda538d2dc5900d3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1be80e6ba2267f5504ceaebe05e2cbd7ee4cffa6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"max_version\": fields.StringField(),"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # list of supported PortProfile objects and versions."},{"line_number":97,"context_line":"        \"port_profile_info\": fields.ListOfObjectsField(\"HostPortProfileInfo\")"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_30618206","line":97,"updated":"2017-08-14 15:18:15.000000000","message":"I\u0027d prefer to see this named \"supported_port_profiles\" to indicate that its a list of port profile classes that are supported by the host.","commit_id":"0c2857eacae1e19d8f4a9a60327c011b541e3963"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9b2f3c9ad05bec1d4744482665d64e0176c294c7","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"max_version\": fields.StringField(),"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # list of supported PortProfile objects and versions."},{"line_number":97,"context_line":"        \"port_profile_info\": fields.ListOfObjectsField(\"HostPortProfileInfo\")"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_d6be76d3","line":97,"in_reply_to":"9f436f4f_04d2c300","updated":"2017-08-16 12:10:49.000000000","message":"I\u0027m in semi-vacation state hehehe.\n\nI\u0027ll change it now.","commit_id":"0c2857eacae1e19d8f4a9a60327c011b541e3963"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b024fa09a4b0bf483f4073d46295e328a275473c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"max_version\": fields.StringField(),"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # list of supported PortProfile objects and versions."},{"line_number":97,"context_line":"        \"port_profile_info\": fields.ListOfObjectsField(\"HostPortProfileInfo\")"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_04d2c300","line":97,"in_reply_to":"9f436f4f_30618206","updated":"2017-08-14 15:37:53.000000000","message":"yes that makes sense to me too.\nrodolfo is on vaction for the next two weeks but if i get a chance before he is back ill make that change.","commit_id":"0c2857eacae1e19d8f4a9a60327c011b541e3963"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bd2312a5e4e069b6f40540a6e2ea227fccb62a5e","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"max_version\": fields.StringField(),"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # list of supported PortProfile objects and versions."},{"line_number":97,"context_line":"        \"port_profile_info\": fields.ListOfObjectsField(\"HostPortProfileInfo\")"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f2577a7_3a7e5d19","line":97,"updated":"2017-09-12 19:01:55.000000000","message":"can we call this \"supported_port_profiles\" please?","commit_id":"a83635f0837e961c97dc365b51be7a57d29db6f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6668dc5476235800d2fe1e63c04f05d95252b19b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"max_version\": fields.StringField(),"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # list of supported PortProfile objects and versions."},{"line_number":97,"context_line":"        \"port_profile_info\": fields.ListOfObjectsField(\"HostPortProfileInfo\")"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f2577a7_b25b7a52","line":97,"in_reply_to":"5f2577a7_3a7e5d19","updated":"2017-09-13 14:08:40.000000000","message":"Done","commit_id":"a83635f0837e961c97dc365b51be7a57d29db6f8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0e1dfb32fd8448c465ce1ce6097e5b773f098ce3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"max_version\": fields.StringField(),"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # list of supported PortProfile objects and versions."},{"line_number":97,"context_line":"        \"port_profile_info\": fields.ListOfObjectsField(\"HostPortProfileInfo\")"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f2577a7_aed68e26","line":97,"in_reply_to":"5f2577a7_3a7e5d19","updated":"2017-09-12 19:11:26.000000000","message":"ya i think thats fair better to change this now then have to do a version bump later with compatiblity code.","commit_id":"a83635f0837e961c97dc365b51be7a57d29db6f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6668dc5476235800d2fe1e63c04f05d95252b19b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"max_version\": fields.StringField(),"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # list of supported PortProfile objects and versions."},{"line_number":97,"context_line":"        \"port_profile_info\": fields.ListOfObjectsField(\"HostPortProfileInfo\")"},{"line_number":98,"context_line":"    }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f2577a7_925abe4c","line":97,"in_reply_to":"5f2577a7_aed68e26","updated":"2017-09-13 14:08:40.000000000","message":"Done","commit_id":"a83635f0837e961c97dc365b51be7a57d29db6f8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bc4124845ef58089d370f6599848188132f2f758","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                      target_version)"},{"line_number":104,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":105,"context_line":"        if target_version \u003c (1, 1) and \u0027port_profile_info\u0027 in primitive:"},{"line_number":106,"context_line":"            del primitive[\u0027port_profile_info\u0027]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def get_common_version(self):"},{"line_number":109,"context_line":"        return _get_common_version(self.vif_object_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f2577a7_7ee03997","line":106,"updated":"2017-09-13 15:53:49.000000000","message":"oops, forgot to change the above...","commit_id":"38a63801e2f66a13df3415f3fd26e188b9ea77f8"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4a44d8eef4502968633e1bba47470127c1620d11","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                      target_version)"},{"line_number":104,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":105,"context_line":"        if target_version \u003c (1, 1) and \u0027port_profile_info\u0027 in primitive:"},{"line_number":106,"context_line":"            del primitive[\u0027port_profile_info\u0027]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def get_common_version(self):"},{"line_number":109,"context_line":"        return _get_common_version(self.vif_object_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f2577a7_1e3c95e0","line":106,"in_reply_to":"5f2577a7_7ee03997","updated":"2017-09-13 16:00:57.000000000","message":"I changed it... I swear!","commit_id":"38a63801e2f66a13df3415f3fd26e188b9ea77f8"}],"os_vif/tests/unit/test_object_versions.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f94168057c66771b9e0dd003445370812e32daec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_c2d06722","line":1,"updated":"2017-08-02 08:26:53.000000000","message":"@Sean, because this change could be considered as unrelated to this patch, I submitted a second patch to rehome the OVO unit tests:\nhttps://review.openstack.org/#/c/489922/","commit_id":"735fdc91edbae37f9262e401f3509d8243bd0bba"}]}