)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af3bb5a31a4024939728dedfdaa13d67004fa73d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vif_plug_ovs: Skip setting MTU on Windows when plugging devices"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Windows does not allow to set MTU only from"},{"line_number":10,"context_line":"the inside of the VM."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The concept of namespaces does not exist on Windows,"},{"line_number":13,"context_line":"we will rely on the DHCP server to instruct the VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_eebbedc1","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":21},"updated":"2017-03-06 10:52:51.000000000","message":"so i dont think this say what you intend it to say.\n\nwindows does not allow ... only from inside the vm. literally means windows allow you to set the mtu from outside of the vm.","commit_id":"3f95e7d3e94dc72e2c60babb4b30e588a8a90463"},{"author":{"_account_id":17019,"name":"Alin Balutoiu","email":"abalutoiu@cloudbasesolutions.com","username":"abalutoiu"},"change_message_id":"dd9680fc3f4c92db1433139f50b0b5f6ed19fb0e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vif_plug_ovs: Skip setting MTU on Windows when plugging devices"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Windows does not allow to set MTU only from"},{"line_number":10,"context_line":"the inside of the VM."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The concept of namespaces does not exist on Windows,"},{"line_number":13,"context_line":"we will rely on the DHCP server to instruct the VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_08e751ac","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":21},"in_reply_to":"ba2be162_eebbedc1","updated":"2017-03-06 13:48:48.000000000","message":"You\u0027re right, I will update the commit message. Windows allows to set the MTU only from inside of the VM.","commit_id":"3f95e7d3e94dc72e2c60babb4b30e588a8a90463"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af3bb5a31a4024939728dedfdaa13d67004fa73d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Windows does not allow to set MTU only from"},{"line_number":10,"context_line":"the inside of the VM."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The concept of namespaces does not exist on Windows,"},{"line_number":13,"context_line":"we will rely on the DHCP server to instruct the VM"},{"line_number":14,"context_line":"to set the MTU value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I16b33fedd9773c37a0368264aecb5581153ba404"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_2ee985b7","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":21},"updated":"2017-03-06 10:52:51.000000000","message":"network namespace has no relevence here. all vm tap devices on linux are in the root namespace, linux network namespaces are only used for the dhcp servers and l3 router instances.","commit_id":"3f95e7d3e94dc72e2c60babb4b30e588a8a90463"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"079416632a44e4076de32fabc55312eb35671d9d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vif_plug_ovs: Skip setting MTU on Windows when plugging devices"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Windows does not allow to set MTU only from"},{"line_number":10,"context_line":"the inside of the VM."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We will rely on the DHCP server to instruct the VM"},{"line_number":13,"context_line":"to set the MTU value on Windows."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1654616"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a30ddce_af7458cf","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":32},"updated":"2017-03-07 16:17:08.000000000","message":"- HyperV with ovs does not support set the MTU of a Virtual interface externally to the VM.\n\n- This change disable the use of ip tool to set the MTU on the guest interface which will always fail on windows.\n\n- On windows based compute nodes MTU advertisement and configuration will be delegated to the guest os via the dhcp mechanism.","commit_id":"821fced4085b6f3684aa97eaa250bea8637d080a"}],"vif_plug_ovs/linux_net.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af3bb5a31a4024939728dedfdaa13d67004fa73d","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    if interface_type not in ["},{"line_number":176,"context_line":"        constants.OVS_VHOSTUSER_INTERFACE_TYPE,"},{"line_number":177,"context_line":"        constants.OVS_VHOSTUSER_CLIENT_INTERFACE_TYPE]:"},{"line_number":178,"context_line":"        if sys.platform !\u003d constants.PLATFORM_WIN32:"},{"line_number":179,"context_line":"            # Windows does not allow to set MTU only from the inside of the VM."},{"line_number":180,"context_line":"            # (The concept of namespaces does not exist on Windows, we will"},{"line_number":181,"context_line":"            # rely on the DHCP server to instruct the VM to set the MTU value)"},{"line_number":182,"context_line":"            _set_device_mtu(dev, mtu)"},{"line_number":183,"context_line":"    elif _ovs_supports_mtu_requests(timeout\u003dtimeout):"},{"line_number":184,"context_line":"        _set_mtu_request(dev, mtu, timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_0e404106","line":181,"range":{"start_line":178,"start_character":7,"end_line":181,"end_character":78},"updated":"2017-03-06 10:52:51.000000000","message":"how is this comment relevent?\n\nthis does not set the mtu inside the vm it set it externally on the tap device, also when you rely on the DHCP server to instruct the vm to set the MTU that happens by the VMs network stack setting the MTU form inside the vm...","commit_id":"3f95e7d3e94dc72e2c60babb4b30e588a8a90463"},{"author":{"_account_id":17019,"name":"Alin Balutoiu","email":"abalutoiu@cloudbasesolutions.com","username":"abalutoiu"},"change_message_id":"dd9680fc3f4c92db1433139f50b0b5f6ed19fb0e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    if interface_type not in ["},{"line_number":176,"context_line":"        constants.OVS_VHOSTUSER_INTERFACE_TYPE,"},{"line_number":177,"context_line":"        constants.OVS_VHOSTUSER_CLIENT_INTERFACE_TYPE]:"},{"line_number":178,"context_line":"        if sys.platform !\u003d constants.PLATFORM_WIN32:"},{"line_number":179,"context_line":"            # Windows does not allow to set MTU only from the inside of the VM."},{"line_number":180,"context_line":"            # (The concept of namespaces does not exist on Windows, we will"},{"line_number":181,"context_line":"            # rely on the DHCP server to instruct the VM to set the MTU value)"},{"line_number":182,"context_line":"            _set_device_mtu(dev, mtu)"},{"line_number":183,"context_line":"    elif _ovs_supports_mtu_requests(timeout\u003dtimeout):"},{"line_number":184,"context_line":"        _set_mtu_request(dev, mtu, timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_155a05f2","line":181,"range":{"start_line":178,"start_character":7,"end_line":181,"end_character":78},"in_reply_to":"ba2be162_0e404106","updated":"2017-03-06 13:48:48.000000000","message":"I will update the comment, you are not allowed to change the MTU of the VM on Windows unless you do it from inside the VM. You can\u0027t set it externally.","commit_id":"3f95e7d3e94dc72e2c60babb4b30e588a8a90463"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af3bb5a31a4024939728dedfdaa13d67004fa73d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            # Windows does not allow to set MTU only from the inside of the VM."},{"line_number":180,"context_line":"            # (The concept of namespaces does not exist on Windows, we will"},{"line_number":181,"context_line":"            # rely on the DHCP server to instruct the VM to set the MTU value)"},{"line_number":182,"context_line":"            _set_device_mtu(dev, mtu)"},{"line_number":183,"context_line":"    elif _ovs_supports_mtu_requests(timeout\u003dtimeout):"},{"line_number":184,"context_line":"        _set_mtu_request(dev, mtu, timeout\u003dtimeout)"},{"line_number":185,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_eea68dbf","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":27},"updated":"2017-03-06 10:52:51.000000000","message":"a better solution would be to update _set_device_mtu to use netsh on window to set the mtu or better use a cross platform python lib to set it.","commit_id":"3f95e7d3e94dc72e2c60babb4b30e588a8a90463"},{"author":{"_account_id":17019,"name":"Alin Balutoiu","email":"abalutoiu@cloudbasesolutions.com","username":"abalutoiu"},"change_message_id":"dd9680fc3f4c92db1433139f50b0b5f6ed19fb0e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            # Windows does not allow to set MTU only from the inside of the VM."},{"line_number":180,"context_line":"            # (The concept of namespaces does not exist on Windows, we will"},{"line_number":181,"context_line":"            # rely on the DHCP server to instruct the VM to set the MTU value)"},{"line_number":182,"context_line":"            _set_device_mtu(dev, mtu)"},{"line_number":183,"context_line":"    elif _ovs_supports_mtu_requests(timeout\u003dtimeout):"},{"line_number":184,"context_line":"        _set_mtu_request(dev, mtu, timeout\u003dtimeout)"},{"line_number":185,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_1543e513","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":27},"in_reply_to":"ba2be162_eea68dbf","updated":"2017-03-06 13:48:48.000000000","message":"You are not allowed to set the MTU from outside of the VM. You can\u0027t update externally the MTU for a VM. Even trying to set the MTU with netsh won\u0027t work because you cannot \u0027see\u0027 the VM network adapter on the host. The only interfaces you can \u0027see\u0027 on the host are the External adapters pinned under the switch (they are specified when you create the switch) and the Internal adapters (shared adapters on the host, OVS type Internal).","commit_id":"3f95e7d3e94dc72e2c60babb4b30e588a8a90463"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"079416632a44e4076de32fabc55312eb35671d9d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        constants.OVS_VHOSTUSER_INTERFACE_TYPE,"},{"line_number":177,"context_line":"        constants.OVS_VHOSTUSER_CLIENT_INTERFACE_TYPE]:"},{"line_number":178,"context_line":"        if sys.platform !\u003d constants.PLATFORM_WIN32:"},{"line_number":179,"context_line":"            # Windows allows to set the MTU only from the inside of the VM."},{"line_number":180,"context_line":"            # We will rely on the DHCP server to instruct the VM to"},{"line_number":181,"context_line":"            # set the MTU value."},{"line_number":182,"context_line":"            _set_device_mtu(dev, mtu)"},{"line_number":183,"context_line":"    elif _ovs_supports_mtu_requests(timeout\u003dtimeout):"},{"line_number":184,"context_line":"        _set_mtu_request(dev, mtu, timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_c2908398","line":181,"range":{"start_line":179,"start_character":12,"end_line":181,"end_character":32},"updated":"2017-03-07 16:17:08.000000000","message":"# HyperV with ovs does not support external programing of virtual interface MTUs via netsh or other windows tools.\n# when plugin an interface on windows we therefor skip programing the MTU and fallback to DHCP advertisement.","commit_id":"821fced4085b6f3684aa97eaa250bea8637d080a"}]}