)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0784110f68c5d05cb2c7aee70eb4b28b0d956ffa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove bring up linux bridge local port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When adding port to linux bridge the kerenl brings up"},{"line_number":10,"context_line":"the local port. This patch removes bringing up the"},{"line_number":11,"context_line":"local port before we add it to linux bridge."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_5f156b9b","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":16},"updated":"2017-03-27 10:55:08.000000000","message":"a port","commit_id":"ed9394e663bd1054ec38ca0c98f3f17779951e64"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0784110f68c5d05cb2c7aee70eb4b28b0d956ffa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove bring up linux bridge local port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When adding port to linux bridge the kerenl brings up"},{"line_number":10,"context_line":"the local port. This patch removes bringing up the"},{"line_number":11,"context_line":"local port before we add it to linux bridge."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_9f49b3d1","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":43},"updated":"2017-03-27 10:55:08.000000000","message":"kernel","commit_id":"ed9394e663bd1054ec38ca0c98f3f17779951e64"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d17a407b03e9a769435e6f62312b9669d941150a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When adding port to linux bridge the kerenl brings up"},{"line_number":10,"context_line":"the local port. This patch removes bringing up the"},{"line_number":11,"context_line":"local port before we add it to linux bridge."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1597287"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_ff8ae618","line":11,"updated":"2017-03-27 18:13:26.000000000","message":"Agree with Stephen that it would be useful to describe *why* we are doing this (potential security reasons).","commit_id":"ed9394e663bd1054ec38ca0c98f3f17779951e64"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f441378ecd78a4abd73b7e16dfaadc0501dc86cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-28 13:05:00 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Explain why we bring up the lb in hybrd mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1597287"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_a32f7c3d","line":7,"updated":"2017-03-28 14:21:26.000000000","message":"s/hybrd/hybrid/ :)","commit_id":"83688e2c28dacd613471600046449e69a72a0db5"}],"vif_plug_ovs/linux_net.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d17a407b03e9a769435e6f62312b9669d941150a","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"@privsep.vif_plug.entrypoint"},{"line_number":167,"context_line":"def add_bridge_port(bridge, dev):"},{"line_number":168,"context_line":"    processutils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, bridge, \u0027up\u0027)"},{"line_number":169,"context_line":"    processutils.execute(\u0027brctl\u0027, \u0027addif\u0027, bridge, dev)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_1f9a2a6d","side":"PARENT","line":168,"updated":"2017-03-27 18:13:26.000000000","message":"So, where/when will the bridge actually be brought up if this is removed? Or is this implying the link-layer doesn\u0027t need to be brought up at all in order for the OVS port pairs to function properly?","commit_id":"414a35768d9bbeb09dd73163a2bae441534e2ca6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6452e31d510f4aec88d4e3ff16d7efc79d1463c8","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"@privsep.vif_plug.entrypoint"},{"line_number":167,"context_line":"def add_bridge_port(bridge, dev):"},{"line_number":168,"context_line":"    processutils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, bridge, \u0027up\u0027)"},{"line_number":169,"context_line":"    processutils.execute(\u0027brctl\u0027, \u0027addif\u0027, bridge, dev)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_1a55981d","side":"PARENT","line":168,"in_reply_to":"ffe62b97_1f9a2a6d","updated":"2017-03-27 18:36:42.000000000","message":"my understanding is that you should never need to bring up the linux bridge port. the vm tap and both ends of the veth pair that connect the linux bridge to the ovs bridge need to be up but no traffic should ever transit the linux bridge local port that gets created when you create a linux bridge.\n\nthat said i am not as familar with linux bridge as i am with ovs so its possible that linux bridge will not forward and traffic if the bridge interface is not up.","commit_id":"414a35768d9bbeb09dd73163a2bae441534e2ca6"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f441378ecd78a4abd73b7e16dfaadc0501dc86cd","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"@privsep.vif_plug.entrypoint"},{"line_number":166,"context_line":"def add_bridge_port(bridge, dev):"},{"line_number":167,"context_line":"    # we bring up the brdige to allow it to switch packets"},{"line_number":168,"context_line":"    processutils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, bridge, \u0027up\u0027)"},{"line_number":169,"context_line":"    processutils.execute(\u0027brctl\u0027, \u0027addif\u0027, bridge, dev)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_a3d41c21","line":167,"updated":"2017-03-28 14:21:26.000000000","message":"s/brdige/bridge/","commit_id":"83688e2c28dacd613471600046449e69a72a0db5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e1a9095e9194cf1af2af7ac62b980040b61e7faf","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"@privsep.vif_plug.entrypoint"},{"line_number":166,"context_line":"def add_bridge_port(bridge, dev):"},{"line_number":167,"context_line":"    # we bring up the brdige to allow it to switch packets"},{"line_number":168,"context_line":"    processutils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, bridge, \u0027up\u0027)"},{"line_number":169,"context_line":"    processutils.execute(\u0027brctl\u0027, \u0027addif\u0027, bridge, dev)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_5dce532d","line":168,"range":{"start_line":167,"start_character":3,"end_line":168,"end_character":59},"updated":"2017-03-28 13:51:34.000000000","message":"actully can you move this to the ensure bridge fuction.\nthis only needs to be done when we create a bridge not\neverytime we add a port.","commit_id":"83688e2c28dacd613471600046449e69a72a0db5"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f441378ecd78a4abd73b7e16dfaadc0501dc86cd","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"@privsep.vif_plug.entrypoint"},{"line_number":166,"context_line":"def add_bridge_port(bridge, dev):"},{"line_number":167,"context_line":"    # we bring up the brdige to allow it to switch packets"},{"line_number":168,"context_line":"    processutils.execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, bridge, \u0027up\u0027)"},{"line_number":169,"context_line":"    processutils.execute(\u0027brctl\u0027, \u0027addif\u0027, bridge, dev)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_23e80ce0","line":168,"range":{"start_line":167,"start_character":3,"end_line":168,"end_character":59},"in_reply_to":"ffe62b97_5dce532d","updated":"2017-03-28 14:21:26.000000000","message":"Yeah, agreed with Sean on the move to _ensure_bridge()","commit_id":"83688e2c28dacd613471600046449e69a72a0db5"}]}
