)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6e0d03783441a79a5aa61d990f66a636cf7765ab","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed \"dhcp_server\" field in Subnet object from IPAddressField"},{"line_number":10,"context_line":"to ListOfIPAddressField, because a subnet can have more than one"},{"line_number":11,"context_line":"DHCP server."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The field is renamed to \"dhcp_servers\"."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_41859159","line":11,"updated":"2017-10-23 08:08:38.000000000","message":"Could you refer that this field is currently not used in Nova.","commit_id":"3e0f9b51bb4d3547ecb7866b21023bd398fe378d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"652383132b5b80565e8bd085ea8c3e11be000aae","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changed \"dhcp_server\" field in Subnet object from IPAddressField"},{"line_number":10,"context_line":"to ListOfIPAddressField, because a subnet can have more than one"},{"line_number":11,"context_line":"DHCP server."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The field is renamed to \"dhcp_servers\"."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_dcf606fa","line":11,"in_reply_to":"3f4b6375_41859159","updated":"2017-10-23 08:56:42.000000000","message":"Sure, I think I need to make it clear that \"os_vif.Subnet.dhcp_server\" is not used in Nova","commit_id":"3e0f9b51bb4d3547ecb7866b21023bd398fe378d"}],"os_vif/objects/subnet.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a6ef2763ce53f3ec4e87d1a700e97244147bd38e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027dns\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":32,"context_line":"        \u0027gateway\u0027: fields.IPAddressField(),"},{"line_number":33,"context_line":"        \u0027routes\u0027: fields.ObjectField(\"RouteList\"),"},{"line_number":34,"context_line":"        \u0027dhcp_servers\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_1238223b","line":34,"updated":"2017-10-20 19:38:33.000000000","message":"How is this compatible without a major version bump on the object?","commit_id":"3e0f9b51bb4d3547ecb7866b21023bd398fe378d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e2ec1cc8e708e7837cab01d3a922b375cc96fce5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027dns\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":32,"context_line":"        \u0027gateway\u0027: fields.IPAddressField(),"},{"line_number":33,"context_line":"        \u0027routes\u0027: fields.ObjectField(\"RouteList\"),"},{"line_number":34,"context_line":"        \u0027dhcp_servers\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_5217baa4","line":34,"updated":"2017-10-20 19:39:27.000000000","message":"This is not a compatible change. You need to bump the major version in order to make changes like this. If you don\u0027t want to do that, then add another field, use that in new code, and pop the first one off the list to populate the old field in case of backport.","commit_id":"3e0f9b51bb4d3547ecb7866b21023bd398fe378d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6e0d03783441a79a5aa61d990f66a636cf7765ab","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027dns\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":32,"context_line":"        \u0027gateway\u0027: fields.IPAddressField(),"},{"line_number":33,"context_line":"        \u0027routes\u0027: fields.ObjectField(\"RouteList\"),"},{"line_number":34,"context_line":"        \u0027dhcp_servers\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_a16565e3","line":34,"in_reply_to":"3f4b6375_5217baa4","updated":"2017-10-23 08:08:38.000000000","message":"This field is not used in Nova code, then we basically don\u0027t share a os-vif object between services so *currently* we could live without any version change. We update VERSION to have a history of the changes only.","commit_id":"3e0f9b51bb4d3547ecb7866b21023bd398fe378d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"af3c012dfce475cd4fea40eadcc7fb2758193367","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027dns\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":32,"context_line":"        \u0027gateway\u0027: fields.IPAddressField(),"},{"line_number":33,"context_line":"        \u0027routes\u0027: fields.ObjectField(\"RouteList\"),"},{"line_number":34,"context_line":"        \u0027dhcp_servers\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_ed0fa834","line":34,"in_reply_to":"3f4b6375_7c4b9258","updated":"2017-10-24 13:53:53.000000000","message":"Is anyone serializing it anywhere? If so, then it\u0027s not a compatible change.\n\nIf they\u0027re not, then there is no reason to bump the minor version. It\u0027s not a compatible change, thus no minor version bump because you can\u0027t create a compatible old version of this.\n\nEither way, this is wrong.","commit_id":"3e0f9b51bb4d3547ecb7866b21023bd398fe378d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"652383132b5b80565e8bd085ea8c3e11be000aae","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027dns\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":32,"context_line":"        \u0027gateway\u0027: fields.IPAddressField(),"},{"line_number":33,"context_line":"        \u0027routes\u0027: fields.ObjectField(\"RouteList\"),"},{"line_number":34,"context_line":"        \u0027dhcp_servers\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_7c4b9258","line":34,"in_reply_to":"3f4b6375_a16565e3","updated":"2017-10-23 08:56:42.000000000","message":"As Sahid said, this field is not used. Although every mayor change (like this one) should bump the mayor version:\n- There is no need because no one is using it [1].\n- This library is still under development to achieve a full Neutron-Nova communication.\n\n[1] http://codesearch.openstack.org/?q\u003ddhcp_server\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dnova","commit_id":"3e0f9b51bb4d3547ecb7866b21023bd398fe378d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"16d3ee670110e425f1b14b65decf002502e5700e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027dns\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":32,"context_line":"        \u0027gateway\u0027: fields.IPAddressField(),"},{"line_number":33,"context_line":"        \u0027routes\u0027: fields.ObjectField(\"RouteList\"),"},{"line_number":34,"context_line":"        \u0027dhcp_servers\u0027: osv_fields.ListOfIPAddressField(),"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_70eb8b12","line":34,"in_reply_to":"3f4b6375_ed0fa834","updated":"2017-10-24 14:01:33.000000000","message":"\u003e Is anyone serializing it anywhere? If so, then it\u0027s not a compatible change.\n\nDan, again, as we said that field is not used, anywhere.\n\n\u003e If they\u0027re not, then there is no reason to bump the minor version. It\u0027s not a compatible change, thus no minor version bump because you can\u0027t create a compatible old version of this.\n\nWell as I said we do prefer to bump the version so we keep the history to the changes done in the os-vif objects. There are no problem with that.","commit_id":"3e0f9b51bb4d3547ecb7866b21023bd398fe378d"}]}