)]}'
{"vif_plug_ovs/linux_net.py":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"f1e00f9c6bd9c79803cab19ed9c8fd9d2e9d677b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"def _create_ovs_vif_cmd(bridge, dev, iface_id, mac,"},{"line_number":66,"context_line":"                        instance_id, interface_type\u003dNone,"},{"line_number":67,"context_line":"                        vhost_server_path\u003dNone):"},{"line_number":68,"context_line":"    cmd \u003d [\u0027--\u0027, \u0027--may-exist\u0027, \u0027add-port\u0027, bridge, dev,"},{"line_number":69,"context_line":"            \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev,"},{"line_number":70,"context_line":"            \u0027external-ids:iface-id\u003d%s\u0027 % iface_id,"},{"line_number":71,"context_line":"            \u0027external-ids:iface-status\u003dactive\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_08c34aef","line":68,"updated":"2018-03-01 10:01:50.000000000","message":"Just noting for my own understanding, from the man page of `ovs-vsctl`:\n\nThe `[--may-exist] add-port` \"creates on \u0027bridge\u0027 a new port named \u0027port\u0027 from the network device of the same name.\u0027\n\n\"Without --may-exist, attempting to create a port that exists is an error. With --may-exist, this command does nothing if port already exists on bridge and is not a bonded port.\"","commit_id":"dadc65c0fae857020f75c8180f159f72cd66c7bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c964f86eb8552236b21b00b60476e1754710bc6e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"def _create_ovs_vif_cmd(bridge, dev, iface_id, mac,"},{"line_number":66,"context_line":"                        instance_id, interface_type\u003dNone,"},{"line_number":67,"context_line":"                        vhost_server_path\u003dNone):"},{"line_number":68,"context_line":"    cmd \u003d [\u0027--\u0027, \u0027--may-exist\u0027, \u0027add-port\u0027, bridge, dev,"},{"line_number":69,"context_line":"            \u0027--\u0027, \u0027set\u0027, \u0027Interface\u0027, dev,"},{"line_number":70,"context_line":"            \u0027external-ids:iface-id\u003d%s\u0027 % iface_id,"},{"line_number":71,"context_line":"            \u0027external-ids:iface-status\u003dactive\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_e5096fdd","line":68,"in_reply_to":"1f9dbf25_08c34aef","updated":"2018-03-06 13:28:19.000000000","message":"not quite\nthat is what the docs would tend to indicate but in reallity the --may-exists just means the add-port becomes a no-op if the port exists however the set command will still be executed. this is the desired behaviour but the --may-exists does not make the entire transaction a no-op just the add-port.","commit_id":"dadc65c0fae857020f75c8180f159f72cd66c7bd"}]}