)]}'
{"doc/source/user/plugins/linux-bridge.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8626b3cceb8d9f96c72248e33040057a538267d8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The Linux Bridge plugin, ``vif_plug_linux_bridge``, is an `os-vif` VIF plugin"},{"line_number":6,"context_line":"for the Linux Bridge network backend. It is one of three plugins provided as part"},{"line_number":7,"context_line":"of `os-vif` itself, the others being :doc:`ovs` and :doc:`noop`."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Supported VIF Types"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_d2cd895e","line":6,"range":{"start_line":6,"start_character":76,"end_line":6,"end_character":81},"updated":"2018-07-05 16:18:07.000000000","message":"nit: wrapping","commit_id":"cb729c3dfa16e221ed69fc77b82b2da6e4aee4a5"}],"doc/source/user/plugins/noop.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e71a7fb3a617bd761e696b1745e6b60bbdf5a813","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The no-op plugin provides support for the following VIF types:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"`VIFVHostUser`"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  Configuration where a guest exposes a UNIX socket for its control plane. This"},{"line_number":18,"context_line":"  configuration is used with the a userspace dataplane such as vpp or snabb switch."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_7a977a49","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":14},"updated":"2018-05-15 09:14:12.000000000","message":"`` ?","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"22fde85c3ed450777ea86fda168d04e9f565aeb9","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The no-op plugin provides support for the following VIF types:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"`VIFVHostUser`"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  Configuration where a guest exposes a UNIX socket for its control plane. This"},{"line_number":18,"context_line":"  configuration is used with the a userspace dataplane such as vpp or snabb switch."}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_f862b2ad","line":15,"range":{"start_line":15,"start_character":13,"end_line":15,"end_character":14},"in_reply_to":"5f7c97a3_7a977a49","updated":"2018-05-15 10:37:13.000000000","message":"based on http://git.openstack.org/cgit/openstack/os-vif/tree/doc/source/user/plugins/ovs.rst and http://git.openstack.org/cgit/openstack/os-vif/tree/doc/source/user/plugins/linux-bridge.rst we use single \"`\" should i fix them everywhere as a sperate patch?","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e71a7fb3a617bd761e696b1745e6b60bbdf5a813","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The no-op plugin provides support for the following VIF types:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"`VIFVHostUser`"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  Configuration where a guest exposes a UNIX socket for its control plane. This"},{"line_number":18,"context_line":"  configuration is used with the a userspace dataplane such as vpp or snabb switch."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_baa99290","line":16,"updated":"2018-05-15 09:14:12.000000000","message":"Can\u0027t have whitespace here or it won\u0027t render as a definition list","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"22fde85c3ed450777ea86fda168d04e9f565aeb9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The no-op plugin provides support for the following VIF types:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"`VIFVHostUser`"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  Configuration where a guest exposes a UNIX socket for its control plane. This"},{"line_number":18,"context_line":"  configuration is used with the a userspace dataplane such as vpp or snabb switch."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_183d2e8e","line":16,"in_reply_to":"5f7c97a3_baa99290","updated":"2018-05-15 10:37:13.000000000","message":"if that is true then this is also wrong here \nhttp://git.openstack.org/cgit/openstack/os-vif/tree/doc/source/user/plugins/ovs.rst#n28\nas i copied this directly then edited the last sentence to remove dpdk.","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"35349caba29e6a29c8ab2b357e3388d9d0e265c0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"`VIFVHostUser`"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  Configuration where a guest exposes a UNIX socket for its control plane. This"},{"line_number":18,"context_line":"  configuration is used with the a userspace dataplane such as vpp or snabb switch."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  Refer to :ref:`vif-vhostuser` for more information."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_0f750264","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":36},"updated":"2018-05-14 09:33:23.000000000","message":"nit: probably a mistake here, no?","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8e7f4fb366e4a25a0862f7e6d25f4e72051b5e7b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"`VIFVHostUser`"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  Configuration where a guest exposes a UNIX socket for its control plane. This"},{"line_number":18,"context_line":"  configuration is used with the a userspace dataplane such as vpp or snabb switch."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  Refer to :ref:`vif-vhostuser` for more information."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_ca3298f2","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":36},"in_reply_to":"5f7c97a3_0f750264","updated":"2018-05-14 10:13:29.000000000","message":"yes it should be \"a\"","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8626b3cceb8d9f96c72248e33040057a538267d8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"The no-op plugin provides support for the following VIF types:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"`VIFVHostUser`"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  Configuration where a guest exposes a UNIX socket for its control plane. This"},{"line_number":18,"context_line":"  configuration is used with a userspace dataplane such as vpp or snabb switch."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_f2ca0544","line":16,"updated":"2018-07-05 16:18:07.000000000","message":"You need to drop this newline to ensure it\u0027s rendered as a definition list.\n\n**EDIT:** I see I called this out in PS1 and we\u0027re going to fix after the fact.","commit_id":"cb729c3dfa16e221ed69fc77b82b2da6e4aee4a5"}],"os_vif/tests/unit/test_os_vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8626b3cceb8d9f96c72248e33040057a538267d8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import mock"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from oslo_config import cfg"},{"line_number":16,"context_line":"from stevedore import extension"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b23ecd23","line":14,"updated":"2018-07-05 16:18:07.000000000","message":"This was correct (mock is not stdlib, unittest.mock is since Python 3.3.)","commit_id":"cb729c3dfa16e221ed69fc77b82b2da6e4aee4a5"}],"releasenotes/notes/add-no-op-plugin-763a6703e7328a24.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8626b3cceb8d9f96c72248e33040057a538267d8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    with network backends that do not require  any action to be preformed"},{"line_number":6,"context_line":"    when a network interfaces is plugged. This pluggin allow for use of"},{"line_number":7,"context_line":"    the generic vhost user vif type without ovs."},{"line_number":8,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_f238c53b","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":4},"updated":"2018-07-05 16:18:07.000000000","message":"This needs to go","commit_id":"cb729c3dfa16e221ed69fc77b82b2da6e4aee4a5"}],"vif_plug_noop/noop.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"35349caba29e6a29c8ab2b357e3388d9d0e265c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Derived from nova/virt/libvirt/vif.py"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (C) 2011 Midokura KK"},{"line_number":4,"context_line":"# Copyright (C) 2011 Nicira, Inc"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cfbcea07","line":1,"updated":"2018-05-14 09:33:23.000000000","message":"nit: I would have put this comment after the copyright block","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e71a7fb3a617bd761e696b1745e6b60bbdf5a813","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Derived from nova/virt/libvirt/vif.py"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (C) 2011 Midokura KK"},{"line_number":4,"context_line":"# Copyright (C) 2011 Nicira, Inc"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_da9a4e60","line":1,"in_reply_to":"5f7c97a3_cfbcea07","updated":"2018-05-15 09:14:12.000000000","message":"As would I, but this is taken from vif_plug_ovs/ovs.py, I\u0027m guessing","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"22fde85c3ed450777ea86fda168d04e9f565aeb9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Derived from nova/virt/libvirt/vif.py"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (C) 2011 Midokura KK"},{"line_number":4,"context_line":"# Copyright (C) 2011 Nicira, Inc"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f83072a1","line":1,"in_reply_to":"5f7c97a3_da9a4e60","updated":"2018-05-15 10:37:13.000000000","message":"yep i copied the file and deleted 95% of the code to leave just the minimum required since it was faster.\n\nill just remove this line as im really not porting any code form nova since its a noop implementation.","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e71a7fb3a617bd761e696b1745e6b60bbdf5a813","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Derived from nova/virt/libvirt/vif.py"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (C) 2011 Midokura KK"},{"line_number":4,"context_line":"# Copyright (C) 2011 Nicira, Inc"},{"line_number":5,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":6,"context_line":"# All Rights Reserved."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9aa05692","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":37},"updated":"2018-05-15 09:14:12.000000000","message":"nit: Intel? This is mostly new code","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8626b3cceb8d9f96c72248e33040057a538267d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Derived from nova/virt/libvirt/vif.py"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (C) 2011 Midokura KK"},{"line_number":4,"context_line":"# Copyright (C) 2011 Nicira, Inc"},{"line_number":5,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":6,"context_line":"# All Rights Reserved."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_722d95fb","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":37},"in_reply_to":"5f7c97a3_18a76ebf","updated":"2018-07-05 16:18:07.000000000","message":"I\u0027d have straight up replaced it since it\u0027s new code, but whatever works :)","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"22fde85c3ed450777ea86fda168d04e9f565aeb9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Derived from nova/virt/libvirt/vif.py"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (C) 2011 Midokura KK"},{"line_number":4,"context_line":"# Copyright (C) 2011 Nicira, Inc"},{"line_number":5,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":6,"context_line":"# All Rights Reserved."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_18a76ebf","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":37},"in_reply_to":"5f7c97a3_9aa05692","updated":"2018-05-15 10:37:13.000000000","message":"i could add\n# Copyright 2018 Intel\n\nbut i think i should proably leave the other copyrights?\n\ni generally do not add intel copyright to new files in favor of having no copyright header or attributing it to the Openstack foundation as the ccla/icla grants the openstacks foundation rights to the copyright.","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e71a7fb3a617bd761e696b1745e6b60bbdf5a813","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \"\"\"A no op plugin"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    The no op plugin  can be used for any vif type that requires"},{"line_number":28,"context_line":"    no action to be preformed on the backend network when a vif"},{"line_number":29,"context_line":"    is plugged. currently only the VIFVHostUser VIF type is supported."},{"line_number":30,"context_line":"    This pluggin enable the use of generic vhost user without ovs."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dab32ee8","line":28,"range":{"start_line":28,"start_character":20,"end_line":28,"end_character":29},"updated":"2018-05-15 09:14:12.000000000","message":"performed","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e71a7fb3a617bd761e696b1745e6b60bbdf5a813","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    The no op plugin  can be used for any vif type that requires"},{"line_number":28,"context_line":"    no action to be preformed on the backend network when a vif"},{"line_number":29,"context_line":"    is plugged. currently only the VIFVHostUser VIF type is supported."},{"line_number":30,"context_line":"    This pluggin enable the use of generic vhost user without ovs."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9ac9365a","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":17},"updated":"2018-05-15 09:14:12.000000000","message":"C","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e71a7fb3a617bd761e696b1745e6b60bbdf5a813","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    The no op plugin  can be used for any vif type that requires"},{"line_number":28,"context_line":"    no action to be preformed on the backend network when a vif"},{"line_number":29,"context_line":"    is plugged. currently only the VIFVHostUser VIF type is supported."},{"line_number":30,"context_line":"    This pluggin enable the use of generic vhost user without ovs."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dae80eb4","line":30,"range":{"start_line":30,"start_character":9,"end_line":30,"end_character":23},"updated":"2018-05-15 09:14:12.000000000","message":"plugin allows for","commit_id":"ae51029f09acacc5b3ec595a237b09966e29c22d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e7802b75e60dc2bf7210d98285b4d2aae8357e94","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":36,"context_line":"            vif_info\u003d["},{"line_number":37,"context_line":"                objects.host_info.HostVIFInfo("},{"line_number":38,"context_line":"                    vif_object_name\u003dobjects.vif.VIFVHostUser.__name__,"},{"line_number":39,"context_line":"                    min_version\u003d\"1.0\","},{"line_number":40,"context_line":"                    max_version\u003d\"1.0\","},{"line_number":41,"context_line":"                    supported_port_profiles\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_35111af9","line":38,"updated":"2018-07-09 10:57:47.000000000","message":"The problem I have is this, it makes a strong dependence. also I would like to be sure we will never be in a situation where we may want to tweak a bit the host that for vhostuser.","commit_id":"ba61a981171b3514219eb6ecf306e421f99ce127"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4f4fad0442d505fc46f6cb878dfca7da0afed1fb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":36,"context_line":"            vif_info\u003d["},{"line_number":37,"context_line":"                objects.host_info.HostVIFInfo("},{"line_number":38,"context_line":"                    vif_object_name\u003dobjects.vif.VIFVHostUser.__name__,"},{"line_number":39,"context_line":"                    min_version\u003d\"1.0\","},{"line_number":40,"context_line":"                    max_version\u003d\"1.0\","},{"line_number":41,"context_line":"                    supported_port_profiles\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ba7e7218","line":38,"in_reply_to":"5f7c97a3_35111af9","updated":"2018-07-09 14:15:29.000000000","message":"the vif Info object is designed to say which vif objects are allowed to be used with this plugin and what port profile are valid for that vif type with this plugin.\n\nany plugin that does not declare which vif types and port profiles can be used with it in this way is violating our api as this is a requirement for all plugins.\n\nits intended to allow scheduling based on vif types in the future and to allow negotiation between nova and neutron in the future.","commit_id":"ba61a981171b3514219eb6ecf306e421f99ce127"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"113f17c89ffe2b4f385cdcd0d930ae67f9a3e108","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":36,"context_line":"            vif_info\u003d["},{"line_number":37,"context_line":"                objects.host_info.HostVIFInfo("},{"line_number":38,"context_line":"                    vif_object_name\u003dobjects.vif.VIFVHostUser.__name__,"},{"line_number":39,"context_line":"                    min_version\u003d\"1.0\","},{"line_number":40,"context_line":"                    max_version\u003d\"1.0\","},{"line_number":41,"context_line":"                    supported_port_profiles\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ffbe06cc","line":38,"in_reply_to":"5f7c97a3_6edb387c","updated":"2018-07-10 09:07:03.000000000","message":"\u003e i would disagree.\n \u003e this is being created for generic vhost-user yes however\n \u003e having a generic noop plugin is useful for functional testing\n \u003e and its also useful for any other vif type in the future that does\n \u003e not require os-vif to preform plugining.\n\nNot really as indicated the plugin is currently designed to work only with a vhostuser vif. It is not generic as we could imagine for a noop thing. I understand the desire of that plugin but based on our orignal design that can\u0027t work.\n\nBeside of that I think it makes sense to maintain the vhostuser plugin.\n\n \u003e calico i believe would be one such case as the tap of the vm\n \u003e created by qemu does not need to be wired up by os-vif to any\n \u003e network backend. calico will install kernel routes itself when it\n \u003e detects the network interface is created. in that case we would add\n \u003e an addtional viftype to model that to this plugin rather then\n \u003e crating a new plugin.\n\nCalico should probably maintain their own plugin","commit_id":"ba61a981171b3514219eb6ecf306e421f99ce127"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"cf4b2ede87e0159beec6cf6b7a9ef5f11410938d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":36,"context_line":"            vif_info\u003d["},{"line_number":37,"context_line":"                objects.host_info.HostVIFInfo("},{"line_number":38,"context_line":"                    vif_object_name\u003dobjects.vif.VIFVHostUser.__name__,"},{"line_number":39,"context_line":"                    min_version\u003d\"1.0\","},{"line_number":40,"context_line":"                    max_version\u003d\"1.0\","},{"line_number":41,"context_line":"                    supported_port_profiles\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d825765c","line":38,"in_reply_to":"5f7c97a3_ba7e7218","updated":"2018-07-09 15:37:01.000000000","message":"Yes thanks I know that. My thinking is we don\u0027t really have other vif type that are going to use this NoOpPlugin we should probably have it called VhostUser. and I would say it makes sense to maintain such plugin.","commit_id":"ba61a981171b3514219eb6ecf306e421f99ce127"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ae2519c5761a25cb5438ac7ad2eea54f8d89f0ce","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":36,"context_line":"            vif_info\u003d["},{"line_number":37,"context_line":"                objects.host_info.HostVIFInfo("},{"line_number":38,"context_line":"                    vif_object_name\u003dobjects.vif.VIFVHostUser.__name__,"},{"line_number":39,"context_line":"                    min_version\u003d\"1.0\","},{"line_number":40,"context_line":"                    max_version\u003d\"1.0\","},{"line_number":41,"context_line":"                    supported_port_profiles\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6edb387c","line":38,"in_reply_to":"5f7c97a3_d825765c","updated":"2018-07-09 16:46:54.000000000","message":"i would disagree.\nthis is being created for generic vhost-user yes however\nhaving a generic noop plugin is useful for functional testing\nand its also useful for any other vif type in the future that does not require os-vif to preform plugining. \n\ncalico i believe would be one such case as the tap of the vm created by qemu does not need to be wired up by os-vif to any network backend. calico will install kernel routes itself when it detects the network interface is created. in that case we would add an addtional viftype to model that to this plugin rather then crating a new plugin.","commit_id":"ba61a981171b3514219eb6ecf306e421f99ce127"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a28b4c213f40e29e520e96d1b83e3b11a5b1dd25","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":36,"context_line":"            vif_info\u003d["},{"line_number":37,"context_line":"                objects.host_info.HostVIFInfo("},{"line_number":38,"context_line":"                    vif_object_name\u003dobjects.vif.VIFVHostUser.__name__,"},{"line_number":39,"context_line":"                    min_version\u003d\"1.0\","},{"line_number":40,"context_line":"                    max_version\u003d\"1.0\","},{"line_number":41,"context_line":"                    supported_port_profiles\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_73e78e47","line":38,"in_reply_to":"5f7c97a3_e862c9a6","updated":"2018-07-10 12:17:38.000000000","message":"\u003e we should not have a plugin for vhostuser.\n\u003e plugins model the mechanism by which a virtual interface is\n \nOh yes you made a good point, vhostuser should no be the plugin. I had in my head something different.","commit_id":"ba61a981171b3514219eb6ecf306e421f99ce127"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d90571c3d8ebbffb8f0ca30da78025498985ebe0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":36,"context_line":"            vif_info\u003d["},{"line_number":37,"context_line":"                objects.host_info.HostVIFInfo("},{"line_number":38,"context_line":"                    vif_object_name\u003dobjects.vif.VIFVHostUser.__name__,"},{"line_number":39,"context_line":"                    min_version\u003d\"1.0\","},{"line_number":40,"context_line":"                    max_version\u003d\"1.0\","},{"line_number":41,"context_line":"                    supported_port_profiles\u003d[])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e862c9a6","line":38,"in_reply_to":"5f7c97a3_ffbe06cc","updated":"2018-07-10 11:39:11.000000000","message":"we should not have a plugin for vhostuser.\nplugins model the mechanism by which a virtual interface is connected to a specific implentation of a backend. \n\nvif_types model the common info relating to a virtual or physical interface that is independent of the backend that they are attached too.\n\nvhostuser is a vif_type not a plugin.\nCalico could maintain there own plugin but\nthey could also simply add viftype to the list.\n\ni dont see any reason why a generic noop plugin would violate the original design of os-vif but a dedicated vhostuser plugin would.","commit_id":"ba61a981171b3514219eb6ecf306e421f99ce127"}]}