)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"feadea2cf5f901d99651d3c2885f2b5a5437e2a7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Mooney \u003cwork@seanmooney.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-07-18 14:51:45 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add upper_constraitns support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change enforces the use of upper_constratins"},{"line_number":10,"context_line":"  in tox envs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_fd140d44","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":20},"updated":"2018-07-18 14:08:20.000000000","message":"nt","commit_id":"19ebc76ebd003e69146fd244d1e0ea3690d0ab13"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"feadea2cf5f901d99651d3c2885f2b5a5437e2a7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add upper_constraitns support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- This change enforces the use of upper_constratins"},{"line_number":10,"context_line":"  in tox envs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2badb5a3cd5f1ab2a66d3ebd97432b77985ada1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_1d122956","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":50},"updated":"2018-07-18 14:08:20.000000000","message":"int","commit_id":"19ebc76ebd003e69146fd244d1e0ea3690d0ab13"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37a48ea27e71c8b0f51a95195474ba3101c17926","unresolved":false,"context_lines":[{"line_number":8,"context_line":"install_command \u003d pip install -U {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"deps \u003d -c {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":12,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":13,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":14,"context_line":"whitelist_externals \u003d bash"},{"line_number":15,"context_line":"commands \u003d stestr run --black-regex \".tests.functional\" {posargs}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"5f7c97a3_dd9cb1c0","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":42},"updated":"2018-07-18 14:09:40.000000000","message":"nit: I\u0027d rather these get moved to their own line","commit_id":"19ebc76ebd003e69146fd244d1e0ea3690d0ab13"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37a48ea27e71c8b0f51a95195474ba3101c17926","unresolved":false,"context_lines":[{"line_number":11,"context_line":"deps \u003d -c {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":12,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":13,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":14,"context_line":"whitelist_externals \u003d bash"},{"line_number":15,"context_line":"commands \u003d stestr run --black-regex \".tests.functional\" {posargs}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[testenv:pep8]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5f7c97a3_fd5bad1f","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":26},"updated":"2018-07-18 14:09:40.000000000","message":"unrelated, but this is no longer used, it seems","commit_id":"19ebc76ebd003e69146fd244d1e0ea3690d0ab13"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37a48ea27e71c8b0f51a95195474ba3101c17926","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[testenv:lower-constraints]"},{"line_number":71,"context_line":"basepython \u003d python3"},{"line_number":72,"context_line":"deps \u003d"},{"line_number":73,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":74,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":75,"context_line":"  -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5f7c97a3_1daea9e3","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":37},"updated":"2018-07-18 14:09:40.000000000","message":"We need it here too","commit_id":"19ebc76ebd003e69146fd244d1e0ea3690d0ab13"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"078296a0463ff473456683ff620c2176b5c24a7f","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[testenv:lower-constraints]"},{"line_number":71,"context_line":"basepython \u003d python3"},{"line_number":72,"context_line":"deps \u003d"},{"line_number":73,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":74,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":75,"context_line":"  -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5f7c97a3_3dd92583","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":37},"in_reply_to":"5f7c97a3_1daea9e3","updated":"2018-07-18 14:10:15.000000000","message":"...should probably use \u0027{[testenv]deps}\u0027 too","commit_id":"19ebc76ebd003e69146fd244d1e0ea3690d0ab13"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fc0ca740638717cd43598c21d9d9c6806a3dfc09","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[testenv:lower-constraints]"},{"line_number":71,"context_line":"basepython \u003d python3"},{"line_number":72,"context_line":"deps \u003d"},{"line_number":73,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":74,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":75,"context_line":"  -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5f7c97a3_ddd3515e","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":37},"in_reply_to":"5f7c97a3_1daea9e3","updated":"2018-07-18 14:10:28.000000000","message":"Why? The lower-constraints job uses lower-constraints, not upper-constraints.","commit_id":"19ebc76ebd003e69146fd244d1e0ea3690d0ab13"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c047c216a14800961a6b68cf62f79fc24f15fab2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"[testenv:venv]"},{"line_number":22,"context_line":"basepython \u003d python3"},{"line_number":23,"context_line":"commands \u003d {posargs}"},{"line_number":24,"context_line":"deps \u003d"},{"line_number":25,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":26,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":27,"context_line":"  -r{toxinidir}/doc/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5f7c97a3_fdb08d43","line":24,"updated":"2018-07-18 14:09:53.000000000","message":"and here","commit_id":"fe086f2c2481abd745568076db3eb93f3fb1f4f5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c047c216a14800961a6b68cf62f79fc24f15fab2","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"[testenv:docs]"},{"line_number":37,"context_line":"basepython \u003d python3"},{"line_number":38,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":39,"context_line":"commands \u003d sphinx-build -W doc/source doc/build"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:releasenotes]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5f7c97a3_9da2b9fa","line":38,"updated":"2018-07-18 14:09:53.000000000","message":"and here?","commit_id":"fe086f2c2481abd745568076db3eb93f3fb1f4f5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c047c216a14800961a6b68cf62f79fc24f15fab2","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"[testenv:releasenotes]"},{"line_number":42,"context_line":"basepython \u003d python3"},{"line_number":43,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":44,"context_line":"commands \u003d sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[testenv:lower-constraints]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5f7c97a3_3d94c58b","line":43,"updated":"2018-07-18 14:09:53.000000000","message":"?","commit_id":"fe086f2c2481abd745568076db3eb93f3fb1f4f5"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6264134fba9d414f41afcc19dfb603811fa81c8b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"install_command \u003d pip install -U {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"   CONSTRAINTS_CMD\u003d-c {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":12,"context_line":"deps \u003d {env:CONSTRAINTS_CMD}"},{"line_number":13,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":14,"context_line":"       -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":4,"id":"5f7c97a3_66062a77","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":18},"updated":"2018-07-18 16:11:54.000000000","message":"it\u0027s less of a CMD and more of an OPT or PARAM or ARG.","commit_id":"d93bb7c61fd2e303712dd7abd62df398b78d4e75"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e5c3a8c12324ca174c4461f88fb9fae9c65c7538","unresolved":false,"context_lines":[{"line_number":8,"context_line":"install_command \u003d pip install -U {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"   CONSTRAINTS_CMD\u003d-c {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":12,"context_line":"deps \u003d {env:CONSTRAINTS_CMD}"},{"line_number":13,"context_line":"       -r{toxinidir}/requirements.txt"},{"line_number":14,"context_line":"       -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":4,"id":"5f7c97a3_f4e5ff07","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":18},"in_reply_to":"5f7c97a3_66062a77","updated":"2018-07-18 21:54:23.000000000","message":"fair i\u0027ll update","commit_id":"d93bb7c61fd2e303712dd7abd62df398b78d4e75"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6264134fba9d414f41afcc19dfb603811fa81c8b","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[testenv:releasenotes]"},{"line_number":44,"context_line":"basepython \u003d python3"},{"line_number":45,"context_line":"deps \u003d {env:CONSTRAINTS_CMD} "},{"line_number":46,"context_line":"       -r{toxinidir}/doc/requirements.txt"},{"line_number":47,"context_line":"commands \u003d sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"5f7c97a3_2624b20d","line":45,"range":{"start_line":45,"start_character":28,"end_line":45,"end_character":29},"updated":"2018-07-18 16:11:54.000000000","message":"\u003cgasp!\u003e","commit_id":"d93bb7c61fd2e303712dd7abd62df398b78d4e75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b404c08f4adc9ece81fced608cb6d09960be9323","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[testenv:releasenotes]"},{"line_number":44,"context_line":"basepython \u003d python3"},{"line_number":45,"context_line":"deps \u003d {env:CONSTRAINTS_CMD} "},{"line_number":46,"context_line":"       -r{toxinidir}/doc/requirements.txt"},{"line_number":47,"context_line":"commands \u003d sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"5f7c97a3_e65b1a20","line":45,"range":{"start_line":45,"start_character":28,"end_line":45,"end_character":29},"updated":"2018-07-18 16:51:53.000000000","message":"eeeewww","commit_id":"d93bb7c61fd2e303712dd7abd62df398b78d4e75"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e5c3a8c12324ca174c4461f88fb9fae9c65c7538","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"[testenv:releasenotes]"},{"line_number":44,"context_line":"basepython \u003d python3"},{"line_number":45,"context_line":"deps \u003d {env:CONSTRAINTS_CMD} "},{"line_number":46,"context_line":"       -r{toxinidir}/doc/requirements.txt"},{"line_number":47,"context_line":"commands \u003d sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"5f7c97a3_147afb23","line":45,"range":{"start_line":45,"start_character":28,"end_line":45,"end_character":29},"in_reply_to":"5f7c97a3_e65b1a20","updated":"2018-07-18 21:54:23.000000000","message":"because of your comment i see noting but a yellow comment marker.... totally not a space there. who said there was :P","commit_id":"d93bb7c61fd2e303712dd7abd62df398b78d4e75"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e5c3a8c12324ca174c4461f88fb9fae9c65c7538","unresolved":false,"context_lines":[{"line_number":46,"context_line":"       -r{toxinidir}/doc/requirements.txt"},{"line_number":47,"context_line":"commands \u003d sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasenotes/source releasenotes/build/html"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"[testenv:lower-constraints]"},{"line_number":50,"context_line":"basepython \u003d python3"},{"line_number":51,"context_line":"deps \u003d"},{"line_number":52,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":53,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":54,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":55,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":"commands \u003d"},{"line_number":57,"context_line":"  stestr run --black-regex \".tests.functional\" {posargs}"},{"line_number":58,"context_line":"  sphinx-build -W doc/source doc/build"}],"source_content_type":"text/x-properties","patch_set":4,"id":"5f7c97a3_948b6b15","line":55,"range":{"start_line":49,"start_character":0,"end_line":55,"end_character":36},"updated":"2018-07-18 21:54:23.000000000","message":"why did this fail?\nthe test result really dont help\nhttp://logs.openstack.org/82/583582/4/check/openstack-tox-lower-constraints/7f49f8b/testr_results.html.gz\ngoes to look deeper.","commit_id":"d93bb7c61fd2e303712dd7abd62df398b78d4e75"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52221ef4ece19affe7e2a6057d39524178dda69a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"setenv \u003d"},{"line_number":10,"context_line":"  VIRTUAL_ENV\u003d{envdir}"},{"line_number":11,"context_line":"  CONSTRAINTS_OPT\u003d-c {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}"},{"line_number":12,"context_line":"deps \u003d"},{"line_number":13,"context_line":"  {env:CONSTRAINTS_OPT}"},{"line_number":14,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":15,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":16,"context_line":"whitelist_externals \u003d bash"}],"source_content_type":"text/x-properties","patch_set":6,"id":"5f7c97a3_ecaf669a","line":13,"range":{"start_line":12,"start_character":6,"end_line":13,"end_character":23},"updated":"2018-07-19 10:16:24.000000000","message":"wasting vertical space like this annoys the hell out of me but i want this merged so fine i nomally dont look at this file anyway but normally i would -1 for adding the new line in this case.","commit_id":"96b5a11d35d74faf7c9866dceef66984dbcddae6"}]}
