)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"parameter while invoking the ovs-vsctl command. The support should be added."},{"line_number":21,"context_line":"This would enhance the functionality of os-vif, since it would support a"},{"line_number":22,"context_line":"scenario when OVS DB server is listening over a TCP socket connection and"},{"line_number":23,"context_line":"will be on functional parity with Neutron."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[0] http://www.openvswitch.org/support/dist-docs/ovsdb-server.1.html"},{"line_number":26,"context_line":"[1] https://docs.openstack.org/neutron/pike/configuration/openvswitch-agent.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_e10c5645","line":23,"updated":"2018-07-31 12:45:15.000000000","message":"Please don\u0027t just copy/paste the bug report as the commit message.\n\nThere are a couple problems with that.\n\n1) You copy/pasted it as-is, which in your editor caused the lines beginning with # to be removed from the commit message. Therefore above, on line 13 of the commit message, it just cuts off what you wanted to use as an example.\n\n2) The commit message is supposed to describe the *why* and the *how* of what the patch actually does. It is not intended to be a repeat of the feature request.\n\nFor instance, you copy/pasted this part of the feature request from the bug:\n\n\"Today, there is no support to pass the ovsdb_connection\nparameter while invoking the ovs-vsctl command. The support should be added. This would enhance the functionality of os-vif, since it would support a scenario when OVS DB server is listening over a TCP socket connection and will be on functional parity with Neutron.\"\n\nBut that\u0027s precisely what this patch is supposed to add. So, you should say that this patch is adding X functionality to fill Y gap.","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"}],"vif_plug_ovs/ovs.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9c6629ee","line":58,"range":{"start_line":58,"start_character":29,"end_line":58,"end_character":32},"updated":"2018-07-31 12:45:15.000000000","message":"TCP","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dc6821bd","line":58,"range":{"start_line":58,"start_character":77,"end_line":58,"end_character":78},"updated":"2018-07-31 12:45:15.000000000","message":"please add a space after period.","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5d6ab817","line":58,"range":{"start_line":58,"start_character":29,"end_line":58,"end_character":32},"in_reply_to":"5f7c97a3_9c6629ee","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_fd5e2477","line":58,"range":{"start_line":58,"start_character":77,"end_line":58,"end_character":78},"in_reply_to":"5f7c97a3_dc6821bd","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bc33e5f6","line":59,"range":{"start_line":59,"start_character":43,"end_line":59,"end_character":47},"updated":"2018-07-31 12:45:15.000000000","message":"UNIX","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1c73f9b5","line":59,"range":{"start_line":59,"start_character":72,"end_line":59,"end_character":73},"updated":"2018-07-31 12:45:15.000000000","message":"please add a space after period.","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9c3869d4","line":59,"updated":"2018-07-31 12:45:15.000000000","message":"please add a space between \"None\" and (default)","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1d62003e","line":59,"range":{"start_line":59,"start_character":72,"end_line":59,"end_character":73},"in_reply_to":"5f7c97a3_1c73f9b5","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_bd542c57","line":59,"in_reply_to":"5f7c97a3_9c3869d4","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cfg.StrOpt(\u0027ovsdb_connection\u0027,"},{"line_number":57,"context_line":"                   default\u003dNone,"},{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dd57a858","line":59,"range":{"start_line":59,"start_character":43,"end_line":59,"end_character":47},"in_reply_to":"5f7c97a3_bc33e5f6","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"},{"line_number":63,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":64,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7c29cd80","line":61,"range":{"start_line":61,"start_character":29,"end_line":61,"end_character":33},"updated":"2018-07-31 12:45:15.000000000","message":"will","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                   help\u003d\u0027The tcp socket connection for communicating with OVS.\u0027"},{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"},{"line_number":63,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":64,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7d52146a","line":61,"range":{"start_line":61,"start_character":29,"end_line":61,"end_character":33},"in_reply_to":"5f7c97a3_7c29cd80","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"},{"line_number":63,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":64,"context_line":"    )"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_dc4fc166","line":62,"range":{"start_line":62,"start_character":52,"end_line":62,"end_character":55},"updated":"2018-07-31 12:45:15.000000000","message":"TCP","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                   \u0027\"None\"(default) is for unix domain socket connection.\u0027"},{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"},{"line_number":63,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":64,"context_line":"    )"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9d4db0c6","line":62,"range":{"start_line":62,"start_character":52,"end_line":62,"end_character":55},"in_reply_to":"5f7c97a3_dc4fc166","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"},{"line_number":63,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":64,"context_line":"    )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5c43b140","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":47},"updated":"2018-07-31 12:45:15.000000000","message":"remove this line. you aren\u0027t deprecating anything.","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                   \u0027If set to \"tcp:IP:PORT\" eg tcp:127.0.0.1:6640, ovs-vsctl \u0027"},{"line_number":61,"context_line":"                   \u0027commands with use the tcp:IP:PORT parameter for \u0027"},{"line_number":62,"context_line":"                   \u0027communicating with OVSDB over a tcp socket.\u0027,"},{"line_number":63,"context_line":"                   deprecated_group\u003d\"DEFAULT\"),"},{"line_number":64,"context_line":"    )"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5d439897","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":47},"in_reply_to":"5f7c97a3_5c43b140","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c475f7a927f5e4d0d43dd3cc17c2d3b846ad70d7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        mtu \u003d self._get_mtu(vif)"},{"line_number":132,"context_line":"        linux_net.update_ovs_vif_port(vif_name, mtu,"},{"line_number":133,"context_line":"                                      timeout\u003dself.config.ovs_vsctl_timeout,"},{"line_number":134,"context_line":"                                      ovsdb_connection\u003d"},{"line_number":135,"context_line":"                                      self.config.ovsdb_connection)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @staticmethod"},{"line_number":138,"context_line":"    def _get_vif_datapath_type(vif, datapath\u003dconstants.OVS_DATAPATH_SYSTEM):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1c81b94d","line":135,"range":{"start_line":134,"start_character":38,"end_line":135,"end_character":67},"updated":"2018-07-31 12:45:15.000000000","message":"here and throughout, please do one of the following.\n\n1) don\u0027t indent the parameters aligned to the column after the opening parentheses. Instead, do this:\n\n linux_net.update_ovs_vif_port(vif_name, mtu,\n     timeout\u003dself.config.ovs_vsctl_timeout,\n     ovsdb_connection\u003dself.config.ovsdb_connection)\n\n2) Use a smaller local variable and avoid the need to add a newline after ovsdb_connection\u003d :\n \n ovsdb_conn \u003d self.config.ovsdb_connection\n linux_net.update_ovs_vif_port(vif_name, mtu,\n                               timeout\u003dself.config.ovs_vsctl_timeout,\n                               ovsdb_connection\u003dovsdb_conn)","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        mtu \u003d self._get_mtu(vif)"},{"line_number":132,"context_line":"        linux_net.update_ovs_vif_port(vif_name, mtu,"},{"line_number":133,"context_line":"                                      timeout\u003dself.config.ovs_vsctl_timeout,"},{"line_number":134,"context_line":"                                      ovsdb_connection\u003d"},{"line_number":135,"context_line":"                                      self.config.ovsdb_connection)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @staticmethod"},{"line_number":138,"context_line":"    def _get_vif_datapath_type(vif, datapath\u003dconstants.OVS_DATAPATH_SYSTEM):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1dc76013","line":135,"range":{"start_line":134,"start_character":38,"end_line":135,"end_character":67},"in_reply_to":"5f7c97a3_1c81b94d","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"}],"vif_plug_ovs/tests/unit/test_plugin.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7d1e1550f221659c3c3af2e9aca95a9282d59822","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            self.vif_ovs.port_profile.interface_id,"},{"line_number":129,"context_line":"            self.vif_ovs.address, self.instance.uuid,"},{"line_number":130,"context_line":"            plugin.config.network_device_mtu,"},{"line_number":131,"context_line":"            ovsdb_connection\u003dplugin.config.ovsdb_connection,"},{"line_number":132,"context_line":"            timeout\u003dplugin.config.ovs_vsctl_timeout,"},{"line_number":133,"context_line":"            interface_type\u003dconstants.OVS_VHOSTUSER_INTERFACE_TYPE)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_5c2e518d","line":131,"range":{"start_line":131,"start_character":29,"end_line":131,"end_character":59},"updated":"2018-07-31 12:40:08.000000000","message":"The value here is None so we don\u0027t really assert anything. It could be nice if you can set osvdb_connection to the non default value","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            self.vif_ovs.port_profile.interface_id,"},{"line_number":129,"context_line":"            self.vif_ovs.address, self.instance.uuid,"},{"line_number":130,"context_line":"            plugin.config.network_device_mtu,"},{"line_number":131,"context_line":"            ovsdb_connection\u003dplugin.config.ovsdb_connection,"},{"line_number":132,"context_line":"            timeout\u003dplugin.config.ovs_vsctl_timeout,"},{"line_number":133,"context_line":"            interface_type\u003dconstants.OVS_VHOSTUSER_INTERFACE_TYPE)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9864de4e","line":131,"range":{"start_line":131,"start_character":29,"end_line":131,"end_character":59},"in_reply_to":"5f7c97a3_5c2e518d","updated":"2018-08-01 09:38:59.000000000","message":"Sahid,\nSee Line 288 in\nhttps://review.openstack.org/#/c/587378/1/vif_plug_ovs/tests/unit/test_linux_net.py \nWill this be enough? \nActually we are trying our best to get this merged in Rocky. So, requesting you to accept without it if possible. If required I will send out another patch to include it too once this gets merged.","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7d1e1550f221659c3c3af2e9aca95a9282d59822","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        plugin.plug(self.vif_ovs, self.instance)"},{"line_number":159,"context_line":"        dp_type \u003d ovs.OvsPlugin._get_vif_datapath_type(self.vif_ovs)"},{"line_number":160,"context_line":"        ensure_ovs_bridge.assert_called_once_with(self.vif_ovs.network.bridge,"},{"line_number":161,"context_line":"                                              dp_type,"},{"line_number":162,"context_line":"                                              ovsdb_connection\u003dNone,"},{"line_number":163,"context_line":"                                              timeout\u003d120)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @mock.patch.object(linux_net, \u0027set_interface_state\u0027)"},{"line_number":166,"context_line":"    @mock.patch.object(linux_net, \u0027ensure_ovs_bridge\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3c4d9570","line":163,"range":{"start_line":161,"start_character":0,"end_line":163,"end_character":57},"updated":"2018-07-31 12:40:08.000000000","message":"supernit: alignment","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"6e1a5b1ebb7349f6b01aa5f9b43f0c5893621e55","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        plugin.plug(self.vif_ovs, self.instance)"},{"line_number":159,"context_line":"        dp_type \u003d ovs.OvsPlugin._get_vif_datapath_type(self.vif_ovs)"},{"line_number":160,"context_line":"        ensure_ovs_bridge.assert_called_once_with(self.vif_ovs.network.bridge,"},{"line_number":161,"context_line":"                                              dp_type,"},{"line_number":162,"context_line":"                                              ovsdb_connection\u003dNone,"},{"line_number":163,"context_line":"                                              timeout\u003d120)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @mock.patch.object(linux_net, \u0027set_interface_state\u0027)"},{"line_number":166,"context_line":"    @mock.patch.object(linux_net, \u0027ensure_ovs_bridge\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9875be35","line":163,"range":{"start_line":161,"start_character":0,"end_line":163,"end_character":57},"in_reply_to":"5f7c97a3_3c4d9570","updated":"2018-08-01 09:38:59.000000000","message":"Done","commit_id":"e14d810d2ba9ae30f98ab6a93b2b18413e00ecd9"}]}