)]}'
{"doc/source/user/vif-types.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5eafdff3996c9d3343449a6a2dfe435f4cda29c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"VIFPortProfileOVSRepresentor"},{"line_number":123,"context_line":"----------------------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"This class has been deprecated in favor of `VIFPortProfileRepresentor`."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"VIFPortProfileFPBridge"},{"line_number":128,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_d4d2c3cf","line":125,"range":{"start_line":125,"start_character":1,"end_line":125,"end_character":71},"updated":"2018-10-08 12:16:45.000000000","message":"im not convinced this is correct to do.\ni think we proably sould keep using the ovs specific profile for ovs ...","commit_id":"a929abf3c1ae827af0d69d77d98eed284ee9f949"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5eafdff3996c9d3343449a6a2dfe435f4cda29c","unresolved":false,"context_lines":[{"line_number":149,"context_line":":term:`VF` representor. If `representor_name` is specified, it indicates a"},{"line_number":150,"context_line":"desire to rename the representor to the given name on plugging."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"In addition to the above, it also provides the metadata required to enable"},{"line_number":153,"context_line":"plugging with other port types. Currently, metadata from the following port"},{"line_number":154,"context_line":"profiles is included:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"* :term:`Open vSwitch`"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"VIF network objects"},{"line_number":159,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_d4fba345","line":156,"range":{"start_line":152,"start_character":0,"end_line":156,"end_character":22},"updated":"2018-10-08 12:16:45.000000000","message":"... basically the port profiles are ment to be specific to a singel network backend not generic.\nthe generic info should be in the viftypes and the backend specific info should be in the profiles.","commit_id":"a929abf3c1ae827af0d69d77d98eed284ee9f949"}],"os_vif/objects/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5eafdff3996c9d3343449a6a2dfe435f4cda29c","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"@base.VersionedObjectRegistry.register"},{"line_number":234,"context_line":"class VIFPortProfileRepresentor(VIFPortProfileOpenVSwitch):"},{"line_number":235,"context_line":"    # Port profile info for generic networks using a representor"},{"line_number":236,"context_line":"    # Version 1.0: Initial release of VIFPortProfileOVSRepresentor"},{"line_number":237,"context_line":"    # Version 1.1: VIFPortProfileOpenVSwitch updated to 1.1"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9451ab33","line":234,"range":{"start_line":234,"start_character":0,"end_line":234,"end_character":59},"updated":"2018-10-08 12:16:45.000000000","message":"ust a side note. while this did not contain any ovs specific info today by removing ovs i never can in the future. so if we ever need to pass ovs specific info to the vif plugin for representor ports we will need to revert to useing the VIFPortProfileOVSRepresentor instead for ovs.","commit_id":"a929abf3c1ae827af0d69d77d98eed284ee9f949"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5eafdff3996c9d3343449a6a2dfe435f4cda29c","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":251,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":252,"context_line":"        if target_version \u003c (1, 1):"},{"line_number":253,"context_line":"            super(VIFPortProfileRepresentor, self).obj_make_compatible("},{"line_number":254,"context_line":"                primitive, \"1.0\")"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"VIFPortProfileOVSRepresentor \u003d moved_class(VIFPortProfileRepresentor,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_7402cf0e","line":254,"range":{"start_line":253,"start_character":11,"end_line":254,"end_character":33},"updated":"2018-10-08 12:16:45.000000000","message":"this needs to be the ovs profile as we actually change the class on downgrade.\n\nthat said dont think i have ever seen a rename before with ovo so i would like dan smith or jay to comment on wether this is even allowed semantically\n\nits generally safe in programming to cast form derived to base but this case we are effectivly casting from base to derived.","commit_id":"a929abf3c1ae827af0d69d77d98eed284ee9f949"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5eafdff3996c9d3343449a6a2dfe435f4cda29c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            super(VIFPortProfileRepresentor, self).obj_make_compatible("},{"line_number":254,"context_line":"                primitive, \"1.0\")"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"VIFPortProfileOVSRepresentor \u003d moved_class(VIFPortProfileRepresentor,"},{"line_number":258,"context_line":"                                           \u0027VIFPortProfileOVSRepresentor\u0027,"},{"line_number":259,"context_line":"                                           __name__)"},{"line_number":260,"context_line":"base.VersionedObjectRegistry.register(VIFPortProfileOVSRepresentor)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"@base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d480839f","line":260,"range":{"start_line":256,"start_character":0,"end_line":260,"end_character":67},"updated":"2018-10-08 12:16:45.000000000","message":"im not gonig to -1 on this but im not convinced this actually buy us anything.","commit_id":"a929abf3c1ae827af0d69d77d98eed284ee9f949"}],"os_vif/tests/unit/test_vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5eafdff3996c9d3343449a6a2dfe435f4cda29c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self._test_vif(objects.vif.VIFGeneric,"},{"line_number":49,"context_line":"                       vif_name\u003d\"vif123\")"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_vif_generic_offloads(self):"},{"line_number":52,"context_line":"        prof \u003d objects.vif.VIFPortProfileRepresentor("},{"line_number":53,"context_line":"            representor_name\u003d\"tap123\","},{"line_number":54,"context_line":"            representor_address\u003d\"0002:24:12.3\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_a736fbe7","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":33},"updated":"2018-10-08 12:16:45.000000000","message":"i know we used this type for hardware offloaded/accclerated ovs but the port porfile itself has nothing to do with offloads. this is just a profile for vf representor based networking which is really just a form of sriov where we create a seperate netdev that remains on the host for the contol plane. so i would prefer not to use the term offloads here as unless we actully add support for enableing and disabling offloads (TSO,GSO...) in the future via metadata in this profile it has nothing to do with the offloads that are available.","commit_id":"a929abf3c1ae827af0d69d77d98eed284ee9f949"}]}
