)]}'
{"os_vif/objects/vif.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ccc9b2ff8f72179fd0f03f9c0fab318bad278855","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \u0027representor_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # The PCI address of the Virtual Function"},{"line_number":198,"context_line":"        \u0027representor_address\u0027: fields.PCIAddressField(nullable\u003dTrue),"},{"line_number":199,"context_line":"    }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_0bfe5838","line":198,"updated":"2018-11-08 09:34:47.000000000","message":"A representor could be something else than a PCI address, example a UUID in case of MDEV. So I would suggest we find a different way to model this.","commit_id":"66805679554c7b1fd807ddbcd5ce3d63db89975c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24c2845a2521443dd20066e33c14e32377b6b1bd","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \u0027representor_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # The PCI address of the Virtual Function"},{"line_number":198,"context_line":"        \u0027representor_address\u0027: fields.PCIAddressField(nullable\u003dTrue),"},{"line_number":199,"context_line":"    }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d968c18a","line":198,"in_reply_to":"3f79a3b5_0bfe5838","updated":"2018-11-15 16:51:13.000000000","message":"in the mdev case you have both a switch dev VF representor and and mdev the mdev does not replace teh VF representor netdev.\n\nthe mdev is provded to qemu for use with vhost-vifo and the representor netdev is attached to the network backed.\n\nthis port profile is specifically for switchdev vf representors not mdevs so if we ever need to pass an mdev to os vif we can do so with a different port profile.","commit_id":"66805679554c7b1fd807ddbcd5ce3d63db89975c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"79d86ede4d3b82090a17f10afcfb12cf29bf4368","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \u0027representor_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # The PCI address of the Virtual Function"},{"line_number":198,"context_line":"        \u0027representor_address\u0027: fields.PCIAddressField(nullable\u003dTrue),"},{"line_number":199,"context_line":"    }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f78c883b","line":198,"in_reply_to":"3f79a3b5_d968c18a","updated":"2018-11-19 08:56:46.000000000","message":"\u003e this port profile is specifically for switchdev vf representors not mdevs so if we ever need to pass an mdev to os vif we can do so with a different port profile.\n\nThat is my point. This name is too general, so we should use a specific name for that one (including some kind of VF prefix/suffix). When we will implement the mdev one we\u0027ll be consistent.","commit_id":"66805679554c7b1fd807ddbcd5ce3d63db89975c"}]}