)]}'
{"os_vif/internal/command/ip/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e1397fe73ca705e3400b3d94b9d72af9803487f6","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def _get_impl():"},{"line_number":23,"context_line":"    if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":24,"context_line":"        impl \u003d \u0027os_vif.internal.command.ip.windows.impl_netifaces.Netifaces\u0027"},{"line_number":25,"context_line":"    else:"},{"line_number":26,"context_line":"        impl \u003d \u0027os_vif.internal.command.ip.linux.impl_pyroute2.PyRoute2\u0027"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a4aa836a","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":76},"updated":"2018-11-01 09:43:21.000000000","message":"I was going to suggest nesting the imports here but this is the same and arguably nicer","commit_id":"ebbd866bc7ef4f9c4b1c78ef756e4ad699f81936"}],"os_vif/internal/command/ip/linux/impl_pyroute2.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e1397fe73ca705e3400b3d94b9d72af9803487f6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from oslo_utils import excutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if os.name !\u003d \u0027nt\u0027:"},{"line_number":19,"context_line":"    from pyroute2 import iproute"},{"line_number":20,"context_line":"    from pyroute2.netlink import exceptions as ipexc"},{"line_number":21,"context_line":"    from pyroute2.netlink.rtnl import ifinfmsg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e4b07be2","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":19},"updated":"2018-11-01 09:43:21.000000000","message":"Is this necessary given the changes in the other file?","commit_id":"ebbd866bc7ef4f9c4b1c78ef756e4ad699f81936"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"80a80d97f84dc879cba2cf4d2632dbdca321cda6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from oslo_utils import excutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if os.name !\u003d \u0027nt\u0027:"},{"line_number":19,"context_line":"    from pyroute2 import iproute"},{"line_number":20,"context_line":"    from pyroute2.netlink import exceptions as ipexc"},{"line_number":21,"context_line":"    from pyroute2.netlink.rtnl import ifinfmsg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_844bc7b0","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":19},"in_reply_to":"3f79a3b5_04db3720","updated":"2018-11-01 10:02:08.000000000","message":"This file is under ip/linux directory and you are handling properly the importation in [1]. We don\u0027t need this.\n\n[1] https://review.openstack.org/#/c/614728/1/os_vif/internal/command/ip/linux/impl_pyroute2.py","commit_id":"ebbd866bc7ef4f9c4b1c78ef756e4ad699f81936"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f209a0c240b8678e7b027680f2d9b73356f90e1e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from oslo_utils import excutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if os.name !\u003d \u0027nt\u0027:"},{"line_number":19,"context_line":"    from pyroute2 import iproute"},{"line_number":20,"context_line":"    from pyroute2.netlink import exceptions as ipexc"},{"line_number":21,"context_line":"    from pyroute2.netlink.rtnl import ifinfmsg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e444fb78","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":19},"in_reply_to":"3f79a3b5_844bc7b0","updated":"2018-11-01 10:09:45.000000000","message":"Ok, I\u0027m dropping this check. I was just thinking that someone may end up importing this somewhere else, by mistake.","commit_id":"ebbd866bc7ef4f9c4b1c78ef756e4ad699f81936"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"037f4a5be92f92c12378dc0a45c02e2d85ba748b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_log import log as logging"},{"line_number":16,"context_line":"from oslo_utils import excutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if os.name !\u003d \u0027nt\u0027:"},{"line_number":19,"context_line":"    from pyroute2 import iproute"},{"line_number":20,"context_line":"    from pyroute2.netlink import exceptions as ipexc"},{"line_number":21,"context_line":"    from pyroute2.netlink.rtnl import ifinfmsg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_04db3720","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":19},"in_reply_to":"3f79a3b5_e4b07be2","updated":"2018-11-01 09:48:05.000000000","message":"At the moment, no. I was just extra cautious.","commit_id":"ebbd866bc7ef4f9c4b1c78ef756e4ad699f81936"}]}
