)]}'
{"os_vif/tests/functional/internal/command/ip/test_impl_pyroute2.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d06d5f63cc0667baea58b9e6896a8ab7a4ebf33","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        device \u003d \"test_dev_9\""},{"line_number":188,"context_line":"        link \u003d \"test_devlink_2\""},{"line_number":189,"context_line":"        self.add_device(link, \u0027dummy\u0027)"},{"line_number":190,"context_line":"        self.addCleanup(self.del_device, \u0027dummy\u0027)"},{"line_number":191,"context_line":"        self.addCleanup(self.del_device, \u0027test_devlink_2\u0027)"},{"line_number":192,"context_line":"        for _ in range(300):"},{"line_number":193,"context_line":"            _ip_cmd_add(device, \u0027vlan\u0027, link\u003dlink, vlan_id\u003d100)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_faa8d2db","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":48},"updated":"2019-01-16 17:41:51.000000000","message":"we dont create a device with the name of dummy in this test.\nso \n\nthis should be \nself.addCleanup(self.del_device, link)","commit_id":"c0fe9070866637232eac6d81927547eea18a525f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4d06d5f63cc0667baea58b9e6896a8ab7a4ebf33","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        link \u003d \"test_devlink_2\""},{"line_number":189,"context_line":"        self.add_device(link, \u0027dummy\u0027)"},{"line_number":190,"context_line":"        self.addCleanup(self.del_device, \u0027dummy\u0027)"},{"line_number":191,"context_line":"        self.addCleanup(self.del_device, \u0027test_devlink_2\u0027)"},{"line_number":192,"context_line":"        for _ in range(300):"},{"line_number":193,"context_line":"            _ip_cmd_add(device, \u0027vlan\u0027, link\u003dlink, vlan_id\u003d100)"},{"line_number":194,"context_line":"            _ip_cmd_delete(device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_9aaf46e2","line":191,"range":{"start_line":191,"start_character":9,"end_line":191,"end_character":58},"updated":"2019-01-16 17:41:51.000000000","message":"and then this is not needed.","commit_id":"c0fe9070866637232eac6d81927547eea18a525f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"879aacf0f2b75727bb51b35f53412e10c5684a72","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        device \u003d \"test_dev_9\""},{"line_number":188,"context_line":"        link \u003d \"test_devlink_2\""},{"line_number":189,"context_line":"        self.add_device(link, \u0027dummy\u0027)"},{"line_number":190,"context_line":"        self.addCleanup(self.del_device, link)"},{"line_number":191,"context_line":"        for _ in range(300):"},{"line_number":192,"context_line":"            _ip_cmd_add(device, \u0027vlan\u0027, link\u003dlink, vlan_id\u003d100)"},{"line_number":193,"context_line":"            _ip_cmd_delete(device)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_36700c73","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":46},"updated":"2019-01-21 12:51:00.000000000","message":"This should be both for link and device:\n\nself.addCleanup(self.del_device, device)\nself.addCleanup(self.del_device, link)","commit_id":"ae431d20d3815231442b0e25b2b14ec76b3ea06d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"636af0f710ad6b2d52cc6a3a98063e96fdc21df4","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        device \u003d \"test_dev_9\""},{"line_number":188,"context_line":"        link \u003d \"test_devlink_2\""},{"line_number":189,"context_line":"        self.add_device(link, \u0027dummy\u0027)"},{"line_number":190,"context_line":"        self.addCleanup(self.del_device, link)"},{"line_number":191,"context_line":"        for _ in range(300):"},{"line_number":192,"context_line":"            _ip_cmd_add(device, \u0027vlan\u0027, link\u003dlink, vlan_id\u003d100)"},{"line_number":193,"context_line":"            _ip_cmd_delete(device)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_f6fe04ad","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":46},"in_reply_to":"9fdfeff1_36700c73","updated":"2019-01-21 12:53:19.000000000","message":"No, the cleanup of the \"test_dev_9\" device happens on line 193..","commit_id":"ae431d20d3815231442b0e25b2b14ec76b3ea06d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"42babb7b7f4aa7063197293a48873524b06b140c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        device \u003d \"test_dev_9\""},{"line_number":188,"context_line":"        link \u003d \"test_devlink_2\""},{"line_number":189,"context_line":"        self.add_device(link, \u0027dummy\u0027)"},{"line_number":190,"context_line":"        self.addCleanup(self.del_device, link)"},{"line_number":191,"context_line":"        for _ in range(300):"},{"line_number":192,"context_line":"            _ip_cmd_add(device, \u0027vlan\u0027, link\u003dlink, vlan_id\u003d100)"},{"line_number":193,"context_line":"            _ip_cmd_delete(device)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_36e32c08","line":190,"range":{"start_line":190,"start_character":8,"end_line":190,"end_character":46},"in_reply_to":"9fdfeff1_f6fe04ad","updated":"2019-01-21 12:56:18.000000000","message":"This is if the test runs smoothly. The cleanup is added in a case something goes wrong, to avoid leaving any unneeded device in the system.","commit_id":"ae431d20d3815231442b0e25b2b14ec76b3ea06d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e0238f8916c4fba330f9af58fa9cc591c37ce4b7","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        device \u003d \"test_dev_9\""},{"line_number":188,"context_line":"        link \u003d \"test_devlink_2\""},{"line_number":189,"context_line":"        self.add_device(link, \u0027dummy\u0027)"},{"line_number":190,"context_line":"        self.addCleanup(self.del_device, device)"},{"line_number":191,"context_line":"        self.addCleanup(self.del_device, link)"},{"line_number":192,"context_line":"        for _ in range(300):"},{"line_number":193,"context_line":"            _ip_cmd_add(device, \u0027vlan\u0027, link\u003dlink, vlan_id\u003d100)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_96d21834","line":190,"updated":"2019-01-21 12:54:17.000000000","message":"No, this happens on line 194, AFAICT.","commit_id":"bf8ad81638728e22165d2f4d42baff25fc9164bd"}]}
