)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9c209aa775f3e5a86afce8c6d255ba4772150cfc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Alvarez \u003cdalvarez@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-18 13:15:17 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t set iface-id when creating an OVS port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After this patch [0], os-vif will always create the OVS interface"},{"line_number":10,"context_line":"in the OVSDB during plug. Later, libvirtd will attempt to create"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfdaf3ff_8ceb6dda","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":18},"updated":"2019-01-18 14:04:26.000000000","message":"the iface-id is required by neutron to be able to corralate the","commit_id":"ecafd828f41f43ea0183d1b0048f026ae75e5ab1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3584cbabe22f4ac31f871ee9842b0430e4f46d56","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Alvarez \u003cdalvarez@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-18 13:15:17 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t set iface-id when creating an OVS port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After this patch [0], os-vif will always create the OVS interface"},{"line_number":10,"context_line":"in the OVSDB during plug. Later, libvirtd will attempt to create"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfdaf3ff_39a2be4c","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":18},"in_reply_to":"bfdaf3ff_8ceb6dda","updated":"2019-01-18 14:52:13.000000000","message":"ignore this i explained it in the top level comment instead.","commit_id":"ecafd828f41f43ea0183d1b0048f026ae75e5ab1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3584cbabe22f4ac31f871ee9842b0430e4f46d56","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[0] https://review.openstack.org/#/c/602384/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Closes-Bug: #1728600"},{"line_number":29,"context_line":"Related-Bug: #1808171"},{"line_number":30,"context_line":"Related-Bug: #1811405"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfdaf3ff_b9f8ee48","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":20},"updated":"2019-01-18 14:52:13.000000000","message":"by the way even if this was merged i dont think it close this bug. i think there i as a systematic problem in some test where it is assume if a port status is active a vm is reachable via its private/floating ip. \n\nthis should not be assumed to be true as there is an interint race in any test that makes that assumtion which then proceed to connect to the vm. if the test is merarly waiting for the prot to be active to observe sideffect via the api then that is fine but there is a delay and therfor a race between the port status being active and the guest os geting an ip via dhcp, starting the ssh deamon and being accssable remotely.\n\nso this should probably be partial-bug or related bug but not closes.","commit_id":"ecafd828f41f43ea0183d1b0048f026ae75e5ab1"}],"vif_plug_ovs/ovs.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9c209aa775f3e5a86afce8c6d255ba4772150cfc","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \"\"\"Create a per-VIF OVS port.\"\"\""},{"line_number":233,"context_line":"        self.ovsdb.ensure_ovs_bridge(vif.network.bridge,"},{"line_number":234,"context_line":"                                     self._get_vif_datapath_type(vif))"},{"line_number":235,"context_line":"        # Don\u0027t set the iface-id on the Interface yet, libvirtd will do it"},{"line_number":236,"context_line":"        # for us later."},{"line_number":237,"context_line":"        vif.port_profile.interface_id \u003d None"},{"line_number":238,"context_line":"        self._create_vif_port(vif, vif.vif_name, instance_info)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _plug_vf_passthrough(self, vif, instance_info):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_acd19125","line":237,"range":{"start_line":235,"start_character":8,"end_line":237,"end_character":44},"updated":"2019-01-18 14:04:26.000000000","message":"we want to remove libvirt form pluging entirly so this would be a step backwards form that goal.","commit_id":"ecafd828f41f43ea0183d1b0048f026ae75e5ab1"}],"vif_plug_ovs/ovsdb/ovsdb_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7888f49c35cd66b81efadfbaa9acd33a66deef2b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def create_ovs_vif_port(self, bridge, dev, iface_id, mac, instance_id,"},{"line_number":66,"context_line":"                            mtu\u003dNone, interface_type\u003dNone,"},{"line_number":67,"context_line":"                            vhost_server_path\u003dNone, tag\u003dNone):"},{"line_number":68,"context_line":"        external_ids \u003d {\u0027iface-id\u0027: iface_id,"},{"line_number":69,"context_line":"                        \u0027iface-status\u0027: \u0027active\u0027,"},{"line_number":70,"context_line":"                        \u0027attached-mac\u0027: mac,"},{"line_number":71,"context_line":"                        \u0027vm-uuid\u0027: instance_id}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_ac42f13c","side":"PARENT","line":68,"updated":"2019-01-18 12:04:47.000000000","message":"This function is called by _create_vif_port. The last one is used in VF, vhostuser, generic OVS and hybrid one.\n\nI don\u0027t think we can change the way we are creating a vif port but instead, what we should do is to create a new vif type, something like VIFOVN (not this name specifically). Using this type you can specify you need to connect to OVN and then you can set or no the iface-id.","commit_id":"6515dc836fd3022a4f68ecd3478fcb1829b82cd0"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"b953b6f34b2e07b9586ddc1141542dd70c67a266","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def create_ovs_vif_port(self, bridge, dev, iface_id, mac, instance_id,"},{"line_number":66,"context_line":"                            mtu\u003dNone, interface_type\u003dNone,"},{"line_number":67,"context_line":"                            vhost_server_path\u003dNone, tag\u003dNone):"},{"line_number":68,"context_line":"        external_ids \u003d {\u0027iface-status\u0027: \u0027active\u0027,"},{"line_number":69,"context_line":"                        \u0027attached-mac\u0027: mac,"},{"line_number":70,"context_line":"                        \u0027vm-uuid\u0027: instance_id}"},{"line_number":71,"context_line":"        col_values \u003d [(\u0027external_ids\u0027, external_ids)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfdaf3ff_0c0c5d39","line":68,"updated":"2019-01-18 11:59:55.000000000","message":"This function is called by \"_create_vif_port()\" . _create_vif_port is called in multiple places.\n\nIn the patch https://review.openstack.org/#/c/602384/, a new function is added _plug_vif_generic().\n\nI think it makes sense to set  the iface-id to None, if create_ovs_vif_port() function is called by _plug_vif_generic() so that you don\u0027t affect the other code paths.","commit_id":"55bdf49a44ad01874ebde61279985c44536e82c8"}]}