)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"217ce5fbfce4bc6b77c9143d7eb9c27a7d17949e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"do not always plug ovs ports."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of resovleing bug #1734320 the os-vif ovs plugin"},{"line_number":10,"context_line":"was modifed to allways plug vif to ovs in all code paths."},{"line_number":11,"context_line":"This change revert that behavior as it has been determined"},{"line_number":12,"context_line":"that libvirt will recreate the port which introduces new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfdaf3ff_325f3373","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":21},"updated":"2019-01-18 17:05:10.000000000","message":"nit: resolving","commit_id":"c60c9ae547189ac6bcf3532e3cc913013431f574"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"217ce5fbfce4bc6b77c9143d7eb9c27a7d17949e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"do not always plug ovs ports."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of resovleing bug #1734320 the os-vif ovs plugin"},{"line_number":10,"context_line":"was modifed to allways plug vif to ovs in all code paths."},{"line_number":11,"context_line":"This change revert that behavior as it has been determined"},{"line_number":12,"context_line":"that libvirt will recreate the port which introduces new"},{"line_number":13,"context_line":"issues for neutron and breaks the intent of the os-vif change."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfdaf3ff_d257c757","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":22},"updated":"2019-01-18 17:05:10.000000000","message":"nit: always","commit_id":"c60c9ae547189ac6bcf3532e3cc913013431f574"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"29de4eda0ba2896b4c4327996015a2747bbc552e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"do not always plug ovs ports."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of resolving bug #1734320 the os-vif ovs plugin"},{"line_number":10,"context_line":"was modifed to always plug vif to ovs in all code paths."},{"line_number":11,"context_line":"This change revert that behavior as it has been determined"},{"line_number":12,"context_line":"that libvirt will recreate the port which introduces new"},{"line_number":13,"context_line":"issues for neutron and breaks the intent of the os-vif change."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_921a3a15","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":11},"updated":"2019-01-18 18:37:36.000000000","message":"modified","commit_id":"b44628090f3dcb4b71c09aafb9ddb2c41e98aefa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"29de4eda0ba2896b4c4327996015a2747bbc552e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of resolving bug #1734320 the os-vif ovs plugin"},{"line_number":10,"context_line":"was modifed to always plug vif to ovs in all code paths."},{"line_number":11,"context_line":"This change revert that behavior as it has been determined"},{"line_number":12,"context_line":"that libvirt will recreate the port which introduces new"},{"line_number":13,"context_line":"issues for neutron and breaks the intent of the os-vif change."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_b2173eee","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":18},"updated":"2019-01-18 18:37:36.000000000","message":"reverts","commit_id":"b44628090f3dcb4b71c09aafb9ddb2c41e98aefa"}],"releasenotes/notes/revert-always-plug-port-for-ovs-hybrid-plug-false-dc015985cbc5443b.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"217ce5fbfce4bc6b77c9143d7eb9c27a7d17949e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    that that change introduced another bug due to an interaction with"},{"line_number":7,"context_line":"    libvirt. It was understood that libvirt would not recreate the ovs port"},{"line_number":8,"context_line":"    if it was present on the ovs bridge when spawning a vm however on"},{"line_number":9,"context_line":"    inspection of the libvirt code this is not the case. in this release"},{"line_number":10,"context_line":"    we have reverted the change to os-vif and libvirt will be the only"},{"line_number":11,"context_line":"    entity to create the ovs port when vif_type is set to ovs and"},{"line_number":12,"context_line":"    hybrid_plug is set to false in the neutron port binding details."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfdaf3ff_72ce1b2f","line":9,"range":{"start_line":9,"start_character":57,"end_line":9,"end_character":59},"updated":"2019-01-18 17:05:10.000000000","message":"nit: Uppercase \"I\"","commit_id":"c60c9ae547189ac6bcf3532e3cc913013431f574"}],"vif_plug_ovs/ovs.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"29de4eda0ba2896b4c4327996015a2747bbc552e","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \"\"\"Create a per-VIF OVS port.\"\"\""},{"line_number":233,"context_line":"        self.ovsdb.ensure_ovs_bridge(vif.network.bridge,"},{"line_number":234,"context_line":"                                     self._get_vif_datapath_type(vif))"},{"line_number":235,"context_line":"        # Note(sean-k-mooney): as part of a partial revert of"},{"line_number":236,"context_line":"        # change Iaf15fa7a678ec2624f7c12f634269c465fbad930"},{"line_number":237,"context_line":"        # (always create ovs port during plug), we removes calling"},{"line_number":238,"context_line":"        # self._create_vif_port(vif, vif.vif_name, instance_info)."}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_12b5eaee","line":235,"range":{"start_line":235,"start_character":10,"end_line":235,"end_character":14},"updated":"2019-01-18 18:37:36.000000000","message":"NOTE","commit_id":"b44628090f3dcb4b71c09aafb9ddb2c41e98aefa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"29de4eda0ba2896b4c4327996015a2747bbc552e","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                     self._get_vif_datapath_type(vif))"},{"line_number":235,"context_line":"        # Note(sean-k-mooney): as part of a partial revert of"},{"line_number":236,"context_line":"        # change Iaf15fa7a678ec2624f7c12f634269c465fbad930"},{"line_number":237,"context_line":"        # (always create ovs port during plug), we removes calling"},{"line_number":238,"context_line":"        # self._create_vif_port(vif, vif.vif_name, instance_info)."},{"line_number":239,"context_line":"        # Calling _create_vif_port here was intended to ensure"},{"line_number":240,"context_line":"        # that the vif was wired up by neutron before the vm was"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_92ef9ae8","line":237,"range":{"start_line":237,"start_character":51,"end_line":237,"end_character":58},"updated":"2019-01-18 18:37:36.000000000","message":"s/removes/stopped/","commit_id":"b44628090f3dcb4b71c09aafb9ddb2c41e98aefa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"29de4eda0ba2896b4c4327996015a2747bbc552e","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        # self._create_vif_port(vif, vif.vif_name, instance_info)."},{"line_number":239,"context_line":"        # Calling _create_vif_port here was intended to ensure"},{"line_number":240,"context_line":"        # that the vif was wired up by neutron before the vm was"},{"line_number":241,"context_line":"        # spawned on boot or livemigration to partially resovle"},{"line_number":242,"context_line":"        # #1734320. When the \"always create ovs port during plug\" change"},{"line_number":243,"context_line":"        # was written it was understood by me that libvirt would not"},{"line_number":244,"context_line":"        # modify ovs if the port exists but infact it deleates and"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_b2ec1ef4","line":241,"range":{"start_line":241,"start_character":56,"end_line":241,"end_character":63},"updated":"2019-01-18 18:37:36.000000000","message":"resolve","commit_id":"b44628090f3dcb4b71c09aafb9ddb2c41e98aefa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"29de4eda0ba2896b4c4327996015a2747bbc552e","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        # spawned on boot or livemigration to partially resovle"},{"line_number":242,"context_line":"        # #1734320. When the \"always create ovs port during plug\" change"},{"line_number":243,"context_line":"        # was written it was understood by me that libvirt would not"},{"line_number":244,"context_line":"        # modify ovs if the port exists but infact it deleates and"},{"line_number":245,"context_line":"        # recreates the port. This both undoes the effort to resolve"},{"line_number":246,"context_line":"        # bug #1734320 and intoduces other issues for neutron."},{"line_number":247,"context_line":"        # this comment will be removed when we actully fix #1734320 in"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_d2ce8282","line":244,"range":{"start_line":244,"start_character":54,"end_line":244,"end_character":62},"updated":"2019-01-18 18:37:36.000000000","message":"deletes","commit_id":"b44628090f3dcb4b71c09aafb9ddb2c41e98aefa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"29de4eda0ba2896b4c4327996015a2747bbc552e","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        # spawned on boot or livemigration to partially resovle"},{"line_number":242,"context_line":"        # #1734320. When the \"always create ovs port during plug\" change"},{"line_number":243,"context_line":"        # was written it was understood by me that libvirt would not"},{"line_number":244,"context_line":"        # modify ovs if the port exists but infact it deleates and"},{"line_number":245,"context_line":"        # recreates the port. This both undoes the effort to resolve"},{"line_number":246,"context_line":"        # bug #1734320 and intoduces other issues for neutron."},{"line_number":247,"context_line":"        # this comment will be removed when we actully fix #1734320 in"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_32ba6ede","line":244,"range":{"start_line":244,"start_character":44,"end_line":244,"end_character":50},"updated":"2019-01-18 18:37:36.000000000","message":"in fact","commit_id":"b44628090f3dcb4b71c09aafb9ddb2c41e98aefa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fb11746c673489204ef3aa83cf88a697c9494b71","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                   choices\u003dlist(ovsdb_api.interface_map),"},{"line_number":69,"context_line":"                   default\u003d\u0027vsctl\u0027,"},{"line_number":70,"context_line":"                   help\u003d\u0027The interface for interacting with the OVSDB\u0027),"},{"line_number":71,"context_line":"        # NOTE(sean-k-mooney): This value is a bool for two reasons."},{"line_number":72,"context_line":"        # First I want to allow this config option to be reusable with"},{"line_number":73,"context_line":"        # non ml2/ovs deployment in the future if required, as such I do not"},{"line_number":74,"context_line":"        # want to encode how the isolation is done in the config option."}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_98901998","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":14},"updated":"2019-01-18 20:09:46.000000000","message":"since i was fixing the new note i fixed them all in this file to be consistent.\ntechnically this is unrelated but its a trivial fix that likely would not get done otherwise.","commit_id":"86ad3cb24279a6d8dbe29901b2c70eb62f8d33a7"}]}