)]}'
{"os_vif/objects/vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f25065251a716a771093b2122a14f579c767c955","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Version 1.0: Initial version"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # Whether device supports bandwidth configuration or not. This is based on"},{"line_number":30,"context_line":"    # libvirt support and taken from:"},{"line_number":31,"context_line":"    #"},{"line_number":32,"context_line":"    # https://github.com/libvirt/libvirt/blob/568a41722/src/conf/netdev_bandwidth_conf.h#L38"},{"line_number":33,"context_line":"    SUPPORTS_BW_CONFIG \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    fields \u003d {"},{"line_number":36,"context_line":"        # Unique identifier of the VIF port"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_8092c057","line":33,"range":{"start_line":29,"start_character":4,"end_line":33,"end_character":30},"updated":"2019-02-20 02:26:57.000000000","message":"we can add libvirt specifc info to the os-vif objects.\n\nthe same objects are used by kuryr and hyperv.\nthis fundementally breaks the abstract.\n\nit is true that the VIF is intended to model the hypervior side of the connect between the instance and the network backend but the vif should be independent of a specific virt driver.","commit_id":"185d0437e3991da9706e40564bc8722aadc044be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5e99c8a4774d95e287a64bb127298a113b2d9827","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    # Version 1.0: Initial version"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # Whether device supports bandwidth configuration or not. This is based on"},{"line_number":30,"context_line":"    # libvirt support and taken from:"},{"line_number":31,"context_line":"    #"},{"line_number":32,"context_line":"    # https://github.com/libvirt/libvirt/blob/568a41722/src/conf/netdev_bandwidth_conf.h#L38"},{"line_number":33,"context_line":"    SUPPORTS_BW_CONFIG \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    fields \u003d {"},{"line_number":36,"context_line":"        # Unique identifier of the VIF port"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_80ce4059","line":33,"range":{"start_line":29,"start_character":4,"end_line":33,"end_character":30},"in_reply_to":"9fdfeff1_8092c057","updated":"2019-02-20 02:33:14.000000000","message":"if we were to add this at all it should state for which hypervior and really shoudl be part of the standard fields of the object rather then hackig it into a class atibute.","commit_id":"185d0437e3991da9706e40564bc8722aadc044be"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e0b60bfc6d9a1a3df33b1f5442a2d53422a2d655","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    # the plugin"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":70,"context_line":"    SUPPORTS_BW_CONFIG \u003d True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    fields \u003d {"},{"line_number":73,"context_line":"        # Name of the device to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_00b394ea","line":70,"updated":"2019-02-14 13:25:51.000000000","message":"Do we need to assign this variable again if the value is True? This class (and the next ones) inherits from VIFBase","commit_id":"185d0437e3991da9706e40564bc8722aadc044be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c30e6c34c89cab9e77f31d9e276a7c13b47cbc00","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    # the plugin"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":70,"context_line":"    SUPPORTS_BW_CONFIG \u003d True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    fields \u003d {"},{"line_number":73,"context_line":"        # Name of the device to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_6bf12195","line":70,"in_reply_to":"9fdfeff1_00b394ea","updated":"2019-02-14 14:09:14.000000000","message":"You would need to override it to set a different value from the parent class, so like this, but not in the cases where te value is still False like VIFDirect.","commit_id":"185d0437e3991da9706e40564bc8722aadc044be"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"60602a27b375810b17eaef56942292241c226141","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    # the plugin"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":70,"context_line":"    SUPPORTS_BW_CONFIG \u003d True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    fields \u003d {"},{"line_number":73,"context_line":"        # Name of the device to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_16299535","line":70,"in_reply_to":"9fdfeff1_6bf12195","updated":"2019-02-14 17:59:42.000000000","message":"My bad, just the opposite, where the value is \"False\".","commit_id":"185d0437e3991da9706e40564bc8722aadc044be"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c30e6c34c89cab9e77f31d9e276a7c13b47cbc00","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    # For libvirt drivers, this maps to type\u003d\u0027direct\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":115,"context_line":"    SUPPORTS_BW_CONFIG \u003d False"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    fields \u003d {"},{"line_number":118,"context_line":"        # Name of the device to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_cb3b6d35","line":115,"updated":"2019-02-14 14:09:14.000000000","message":"Isn\u0027t direct supported?\n\nhttps://github.com/libvirt/libvirt/blob/568a41722/src/conf/netdev_bandwidth_conf.h#L43","commit_id":"185d0437e3991da9706e40564bc8722aadc044be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5e99c8a4774d95e287a64bb127298a113b2d9827","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    # For libvirt drivers, this maps to type\u003d\u0027direct\u0027"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":115,"context_line":"    SUPPORTS_BW_CONFIG \u003d False"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    fields \u003d {"},{"line_number":118,"context_line":"        # Name of the device to create"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_807ba027","line":115,"in_reply_to":"9fdfeff1_cb3b6d35","updated":"2019-02-20 02:33:14.000000000","message":"direct would correspond to macvtap sriov which would support bandwith shaping yes.\n\nthe vf and vf netdev remain bound to the host so libvirt can use tc to enforce bandwith limits on it.","commit_id":"185d0437e3991da9706e40564bc8722aadc044be"}]}