)]}'
{"os_vif/internal/command/__init__.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"97441465d4ca3c0e1277b5f9048a7e354cd9e2fa","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"versionutils.report_deprecated_feature("},{"line_number":22,"context_line":"    LOG, \u0027Implicit loading of IP library from \"os_vif.internal.command\" is \u0027"},{"line_number":23,"context_line":"         \u0027deprecated and will be removed in R release.\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ip \u003d ip_lib"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_ae228fa1","line":23,"range":{"start_line":23,"start_character":43,"end_line":23,"end_character":46},"updated":"2019-03-28 11:49:05.000000000","message":"R as in rocky?\n\nthis is also an internal api so we dont need a depercation cyle. noting out side of os-vif can import this.","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86fff44a0431f960549dcb511a93a4ac55e02757","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"versionutils.report_deprecated_feature("},{"line_number":22,"context_line":"    LOG, \u0027Implicit loading of IP library from \"os_vif.internal.command\" is \u0027"},{"line_number":23,"context_line":"         \u0027deprecated and will be removed in R release.\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ip \u003d ip_lib"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_5832d05f","line":23,"range":{"start_line":23,"start_character":43,"end_line":23,"end_character":46},"in_reply_to":"5fc1f717_ae228fa1","updated":"2019-03-28 14:32:56.000000000","message":"My bad, I need to re learn the alphabet: T -\u003e U\n\nAnyway, because of other comments, I\u0027ll remove this file.","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"97441465d4ca3c0e1277b5f9048a7e354cd9e2fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":8,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_log import log as logging"},{"line_number":14,"context_line":"from oslo_log import versionutils"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from os_vif.internal.ip.api import ip as ip_lib"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"versionutils.report_deprecated_feature("},{"line_number":22,"context_line":"    LOG, \u0027Implicit loading of IP library from \"os_vif.internal.command\" is \u0027"},{"line_number":23,"context_line":"         \u0027deprecated and will be removed in R release.\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ip \u003d ip_lib"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_ce77db9f","line":25,"range":{"start_line":1,"start_character":0,"end_line":25,"end_character":11},"updated":"2019-03-28 11:49:05.000000000","message":"in general i think doing anything in the __init__.py is a code smell so let not do this and import ip_lib from \nos_vif.internal.ip.api instead where it is needed","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"}],"os_vif/internal/ip/api.py":[{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"af5faa394aba84eec634d1858b91f3607b74aafa","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"ip \u003d ip_lib_class()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_11ad9130","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":2},"updated":"2019-04-16 12:11:14.000000000","message":"I have no objection to this, I just find it funny that this object is:\n\n  os_vif.internal.ip.api.ip\n\n:-)","commit_id":"c7114d4779792148054c263f213e8861ad44b2ce"}],"os_vif/internal/ip/ip_command.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"97441465d4ca3c0e1277b5f9048a7e354cd9e2fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fc1f717_4e6bebb5","updated":"2019-03-28 11:49:05.000000000","message":"we should move eveything in this file into \napi.py\n\nas far as i am concnered this absract base class defines the ip api.","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"65bd9f251a770ccef0d68dbc87362658655759e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fc1f717_b6bf455f","in_reply_to":"5fc1f717_38aee42d","updated":"2019-03-28 15:39:42.000000000","message":"we can break that but ok lets leave that for later","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86fff44a0431f960549dcb511a93a4ac55e02757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fc1f717_38aee42d","in_reply_to":"5fc1f717_4e6bebb5","updated":"2019-03-28 14:32:56.000000000","message":"I know you asked for this but I can\u0027t. If I move this into api.py, then we\u0027ll have an import circular dependency between api and linux.impl_pyroute2/windows.impl_netifaces","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"}],"releasenotes/notes/remove-ip-proxy-methods-0d3cab1804fa187e.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"97441465d4ca3c0e1277b5f9048a7e354cd9e2fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the IP proxy methods in ``os_vif.internal.command.ip``, because"},{"line_number":5,"context_line":"    both Windows and Linyx IP implementations have the same interface,"},{"line_number":6,"context_line":"    ``IpCommand``. Method calls (set, add, delete, exists) must be the same for"},{"line_number":7,"context_line":"    both IP classes, making those proxy calls unnecessary."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Removed a nesting level for internal IP commands. Now those commands are"},{"line_number":11,"context_line":"    located in ``os_vif.internal.ip``. A reference will be keep in the old"},{"line_number":12,"context_line":"    location until R release."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_ce003b04","line":12,"range":{"start_line":1,"start_character":1,"end_line":12,"end_character":29},"updated":"2019-03-28 11:49:05.000000000","message":"im not sure this is required.\nthis is an internal api that no one can import outside of this repo.\n\nwho is the intended consume of this release note.","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b82610dfad481f8b34d188d59a8c82a7f96dc3cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the IP proxy methods in ``os_vif.internal.command.ip``, because"},{"line_number":5,"context_line":"    both Windows and Linyx IP implementations have the same interface,"},{"line_number":6,"context_line":"    ``IpCommand``. Method calls (set, add, delete, exists) must be the same for"},{"line_number":7,"context_line":"    both IP classes, making those proxy calls unnecessary."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Removed a nesting level for internal IP commands. Now those commands are"},{"line_number":11,"context_line":"    located in ``os_vif.internal.ip``. A reference will be keep in the old"},{"line_number":12,"context_line":"    location until R release."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_7bd1c6cb","line":12,"range":{"start_line":1,"start_character":1,"end_line":12,"end_character":29},"in_reply_to":"5fc1f717_1857685a","updated":"2019-03-28 15:00:36.000000000","message":"Hum I think I did not have followed the point were we wanted to have this to be used by the plugins that we maintain only. That does not really make sense.\n\nBut well based on [1] it seems clear that is only used internally. Sorry Rodolfo for the extra work.","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86fff44a0431f960549dcb511a93a4ac55e02757","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the IP proxy methods in ``os_vif.internal.command.ip``, because"},{"line_number":5,"context_line":"    both Windows and Linyx IP implementations have the same interface,"},{"line_number":6,"context_line":"    ``IpCommand``. Method calls (set, add, delete, exists) must be the same for"},{"line_number":7,"context_line":"    both IP classes, making those proxy calls unnecessary."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Removed a nesting level for internal IP commands. Now those commands are"},{"line_number":11,"context_line":"    located in ``os_vif.internal.ip``. A reference will be keep in the old"},{"line_number":12,"context_line":"    location until R release."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_1857685a","line":12,"range":{"start_line":1,"start_character":1,"end_line":12,"end_character":29},"in_reply_to":"5fc1f717_65328560","updated":"2019-03-28 14:32:56.000000000","message":"Sean I right. That\u0027s why we implemented [1].\n\nBecause this is an internal refactor, we don\u0027t need the reno.\n\n[1] https://review.openstack.org/#/c/484386/31/os_vif/internal/__init__.py","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"48c7cf66535a53f62b5fcf161a7c35f9c4c8e1b5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the IP proxy methods in ``os_vif.internal.command.ip``, because"},{"line_number":5,"context_line":"    both Windows and Linyx IP implementations have the same interface,"},{"line_number":6,"context_line":"    ``IpCommand``. Method calls (set, add, delete, exists) must be the same for"},{"line_number":7,"context_line":"    both IP classes, making those proxy calls unnecessary."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Removed a nesting level for internal IP commands. Now those commands are"},{"line_number":11,"context_line":"    located in ``os_vif.internal.ip``. A reference will be keep in the old"},{"line_number":12,"context_line":"    location until R release."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_a2b31fe9","line":12,"range":{"start_line":1,"start_character":1,"end_line":12,"end_character":29},"in_reply_to":"5fc1f717_7bd1c6cb","updated":"2019-04-03 13:07:07.000000000","message":"No problem, this is the game!","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a10b66add9c8b35bd6a46d2b2d495ee8d498a62a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the IP proxy methods in ``os_vif.internal.command.ip``, because"},{"line_number":5,"context_line":"    both Windows and Linyx IP implementations have the same interface,"},{"line_number":6,"context_line":"    ``IpCommand``. Method calls (set, add, delete, exists) must be the same for"},{"line_number":7,"context_line":"    both IP classes, making those proxy calls unnecessary."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Removed a nesting level for internal IP commands. Now those commands are"},{"line_number":11,"context_line":"    located in ``os_vif.internal.ip``. A reference will be keep in the old"},{"line_number":12,"context_line":"    location until R release."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_65328560","line":12,"range":{"start_line":1,"start_character":1,"end_line":12,"end_character":29},"in_reply_to":"5fc1f717_852211a2","updated":"2019-03-28 13:50:42.000000000","message":"no that was not the aim.\ni asked rodolfo to open that bug initally\nim right now im pretty stongly agains creating an os-viflib\nrepo in the future.\n\nwhat i propsoed was reusing this only for in tree plugins and \nproviding a cookie cutter template to create future plugins.","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"af5faa394aba84eec634d1858b91f3607b74aafa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the IP proxy methods in ``os_vif.internal.command.ip``, because"},{"line_number":5,"context_line":"    both Windows and Linyx IP implementations have the same interface,"},{"line_number":6,"context_line":"    ``IpCommand``. Method calls (set, add, delete, exists) must be the same for"},{"line_number":7,"context_line":"    both IP classes, making those proxy calls unnecessary."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Removed a nesting level for internal IP commands. Now those commands are"},{"line_number":11,"context_line":"    located in ``os_vif.internal.ip``. A reference will be keep in the old"},{"line_number":12,"context_line":"    location until R release."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fce034c_91f3c173","line":12,"range":{"start_line":1,"start_character":1,"end_line":12,"end_character":29},"in_reply_to":"5fc1f717_a2b31fe9","updated":"2019-04-16 12:11:14.000000000","message":"You could also change the \"features:\" section to something like \"other:\" and change the note to read it\u0027s an internal refactor, but even that is a bit overkill for an internal change. Worse, there\u0027s a risk people import os-vif internals and rely on them.","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d95b68ed9752755d4204ce4525910e97fd01085d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the IP proxy methods in ``os_vif.internal.command.ip``, because"},{"line_number":5,"context_line":"    both Windows and Linyx IP implementations have the same interface,"},{"line_number":6,"context_line":"    ``IpCommand``. Method calls (set, add, delete, exists) must be the same for"},{"line_number":7,"context_line":"    both IP classes, making those proxy calls unnecessary."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Removed a nesting level for internal IP commands. Now those commands are"},{"line_number":11,"context_line":"    located in ``os_vif.internal.ip``. A reference will be keep in the old"},{"line_number":12,"context_line":"    location until R release."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_852211a2","line":12,"range":{"start_line":1,"start_character":1,"end_line":12,"end_character":29},"in_reply_to":"5fc1f717_ce003b04","updated":"2019-03-28 13:31:30.000000000","message":"It is actually intended to be used outside of this repo. The aim was to factorize the code here to avoid duplicate in plugins to at some point providing some sort of os-viflib.","commit_id":"15dbf23f0333088acb6525f8a3212557ee289b60"}]}
