)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"54be616040e7379c8a37a5f21a899c24cff1ad17","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent \"qbr\" Linux Bridge from replying to ARP messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Linux Bridge inbetween the VM TAP interface and OVS should [1][2]:"},{"line_number":10,"context_line":"- Reply only if the target IP address is local address configured"},{"line_number":11,"context_line":"  on the incoming interface."},{"line_number":12,"context_line":"- Always use the best local address."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]http://kb.linuxvirtualserver.org/wiki/Using_arp_announce/arp_ignore_to_disable_ARP"},{"line_number":15,"context_line":"[2]http://linux-ip.net/html/ether-arp.html#ether-arp-flux"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_59c10c80","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":36},"updated":"2019-04-24 11:31:18.000000000","message":"the change looks fine but i dont understatnd why this woudl ever have an ip.\n\nwe do not assing it one ever therefor it should never respond to arp message unless something on the hsot has assgined it an ip which is arguabley the real soruce of the bug.","commit_id":"dee5f0ebc693af278deae69225c235ac9fc69024"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fdb6f41d4b9bf45101c88032b6ee581e83c606db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent \"qbr\" Linux Bridge from replying to ARP messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Linux Bridge inbetween the VM TAP interface and OVS should [1][2]:"},{"line_number":10,"context_line":"- Reply only if the target IP address is local address configured"},{"line_number":11,"context_line":"  on the incoming interface."},{"line_number":12,"context_line":"- Always use the best local address."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]http://kb.linuxvirtualserver.org/wiki/Using_arp_announce/arp_ignore_to_disable_ARP"},{"line_number":15,"context_line":"[2]http://linux-ip.net/html/ether-arp.html#ether-arp-flux"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_99b544d0","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":36},"in_reply_to":"ffb9cba7_59c10c80","updated":"2019-04-24 12:19:24.000000000","message":"No, the IP is in another interface. The LB is replying to this ARP, with the other interface IP, with it\u0027s own MAC.\n\nIf you deploy a compute node with firewall\u003diptables_hybrid and you add any interface in the compute node with the same IP of the VM, you\u0027ll see this problem.","commit_id":"dee5f0ebc693af278deae69225c235ac9fc69024"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"54be616040e7379c8a37a5f21a899c24cff1ad17","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[2]http://linux-ip.net/html/ether-arp.html#ether-arp-flux"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I8721b680bbd9f59a67bd8e6855ffb291c208cdb8"},{"line_number":18,"context_line":"Closes-Bug: #1825888"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffb9cba7_795ad0f3","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":20},"updated":"2019-04-24 11:31:18.000000000","message":"ok reading the bug description this makes a little more sense. so im ok with this change","commit_id":"dee5f0ebc693af278deae69225c235ac9fc69024"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"502a9d0cef7f135ffccffe26c101b1db643d0348","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[2]http://linux-ip.net/html/ether-arp.html#ether-arp-flux"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I8721b680bbd9f59a67bd8e6855ffb291c208cdb8"},{"line_number":18,"context_line":"Closes-Bug: #1825888"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffb9cba7_3c7e8619","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":20},"updated":"2019-04-24 12:38:00.000000000","message":"this effect linux bridge too so this shoudl either be partial bug or you shoudl fix linux bridge in the same way\n\nif you want to keep that bug for ovs i guess you could file a second one but for linux bridge but form a backporting point of view i would prefer to have just one patch.\n\nalso could you add a short release note.","commit_id":"c8ff51cea9c1eba422199d41cafa085aa7ff0f6a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4dc4717ae858c697eee29ec5d601ad0b5d3c4444","unresolved":false,"context_lines":[{"line_number":15,"context_line":"[2]http://linux-ip.net/html/ether-arp.html#ether-arp-flux"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I8721b680bbd9f59a67bd8e6855ffb291c208cdb8"},{"line_number":18,"context_line":"Closes-Bug: #1825888"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffb9cba7_3cb20696","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":20},"in_reply_to":"ffb9cba7_3c7e8619","updated":"2019-04-24 12:51:30.000000000","message":"I\u0027ll add a release note and I\u0027ll add LB in this patch","commit_id":"c8ff51cea9c1eba422199d41cafa085aa7ff0f6a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f0f5e56d367db7eed338ce616af9cb7dd0bac596","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent \"qbr\" Linux Bridge from replying to ARP messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Linux Bridge inbetween the VM TAP interface and OVS should [1][2]:"},{"line_number":10,"context_line":"- Reply only if the target IP address is local address configured"},{"line_number":11,"context_line":"  on the incoming interface."},{"line_number":12,"context_line":"- Always use the best local address."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffb9cba7_17e102ff","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":26},"updated":"2019-04-25 14:14:01.000000000","message":"in between","commit_id":"fe36b1d023624b3e283dcb0cfc915c8166faccfc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8a384396e577132166eecbd6c1aacaac450aad4c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent \"qbr\" Linux Bridge from replying to ARP messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Linux Bridge inbetween the VM TAP interface and OVS should [1][2]:"},{"line_number":10,"context_line":"- Reply only if the target IP address is local address configured"},{"line_number":11,"context_line":"  on the incoming interface."},{"line_number":12,"context_line":"- Always use the best local address."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffb9cba7_d7f5aa84","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":26},"in_reply_to":"ffb9cba7_17e102ff","updated":"2019-04-25 14:19:53.000000000","message":"Done","commit_id":"fe36b1d023624b3e283dcb0cfc915c8166faccfc"}],"vif_plug_linux_bridge/linux_net.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f0f5e56d367db7eed338ce616af9cb7dd0bac596","unresolved":false,"context_lines":[{"line_number":120,"context_line":"       incoming interface."},{"line_number":121,"context_line":"    2. Always use the best local address."},{"line_number":122,"context_line":"    \"\"\""},{"line_number":123,"context_line":"    arp_params \u003d {\u0027/proc/sys/net/ipv4/conf/%s/arp_ignore\u0027 % bridge: \u00271\u0027,"},{"line_number":124,"context_line":"                  \u0027/proc/sys/net/ipv4/conf/%s/arp_announce\u0027 % bridge: \u00272\u0027}"},{"line_number":125,"context_line":"    for parameter, value in arp_params.items():"},{"line_number":126,"context_line":"        if os.path.exists(parameter):"},{"line_number":127,"context_line":"            with open(parameter, \u0027w\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_57a53ab4","line":124,"range":{"start_line":123,"start_character":17,"end_line":124,"end_character":74},"updated":"2019-04-25 14:14:01.000000000","message":"This feels extremely odd. Any reason this isn\u0027t a list of tuples?","commit_id":"fe36b1d023624b3e283dcb0cfc915c8166faccfc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8a384396e577132166eecbd6c1aacaac450aad4c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"       incoming interface."},{"line_number":121,"context_line":"    2. Always use the best local address."},{"line_number":122,"context_line":"    \"\"\""},{"line_number":123,"context_line":"    arp_params \u003d {\u0027/proc/sys/net/ipv4/conf/%s/arp_ignore\u0027 % bridge: \u00271\u0027,"},{"line_number":124,"context_line":"                  \u0027/proc/sys/net/ipv4/conf/%s/arp_announce\u0027 % bridge: \u00272\u0027}"},{"line_number":125,"context_line":"    for parameter, value in arp_params.items():"},{"line_number":126,"context_line":"        if os.path.exists(parameter):"},{"line_number":127,"context_line":"            with open(parameter, \u0027w\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_97ef32af","line":124,"range":{"start_line":123,"start_character":17,"end_line":124,"end_character":74},"in_reply_to":"ffb9cba7_57a53ab4","updated":"2019-04-25 14:19:53.000000000","message":"Done","commit_id":"fe36b1d023624b3e283dcb0cfc915c8166faccfc"}],"vif_plug_ovs/linux_net.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"54be616040e7379c8a37a5f21a899c24cff1ad17","unresolved":false,"context_lines":[{"line_number":116,"context_line":"       incoming interface."},{"line_number":117,"context_line":"    2. Always use the best local address."},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":"    processutils.execute(\u0027sysctl\u0027, \u0027-w\u0027,"},{"line_number":120,"context_line":"                         \u0027net.ipv4.conf.%s.arp_ignore\u003d1\u0027 % bridge)"},{"line_number":121,"context_line":"    processutils.execute(\u0027sysctl\u0027, \u0027-w\u0027,"},{"line_number":122,"context_line":"                         \u0027net.ipv4.conf.%s.arp_announce\u003d2\u0027 % bridge)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"@privsep.vif_plug.entrypoint"},{"line_number":126,"context_line":"def ensure_bridge(bridge):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_39e77815","line":123,"range":{"start_line":119,"start_character":5,"end_line":123,"end_character":0},"updated":"2019-04-24 11:31:18.000000000","message":"lets not sue processutils for this\n\ncan you follow the example fo disabling ipv6 above.\n\nalso this should proably be done in the linux bridge driver too.\n\nhttps://github.com/openstack/os-vif/blob/master/vif_plug_linux_bridge/linux_net.py#L179","commit_id":"dee5f0ebc693af278deae69225c235ac9fc69024"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fdb6f41d4b9bf45101c88032b6ee581e83c606db","unresolved":false,"context_lines":[{"line_number":116,"context_line":"       incoming interface."},{"line_number":117,"context_line":"    2. Always use the best local address."},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":"    processutils.execute(\u0027sysctl\u0027, \u0027-w\u0027,"},{"line_number":120,"context_line":"                         \u0027net.ipv4.conf.%s.arp_ignore\u003d1\u0027 % bridge)"},{"line_number":121,"context_line":"    processutils.execute(\u0027sysctl\u0027, \u0027-w\u0027,"},{"line_number":122,"context_line":"                         \u0027net.ipv4.conf.%s.arp_announce\u003d2\u0027 % bridge)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"@privsep.vif_plug.entrypoint"},{"line_number":126,"context_line":"def ensure_bridge(bridge):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_1c8dc27a","line":123,"range":{"start_line":119,"start_character":5,"end_line":123,"end_character":0},"in_reply_to":"ffb9cba7_39e77815","updated":"2019-04-24 12:19:24.000000000","message":"Done","commit_id":"dee5f0ebc693af278deae69225c235ac9fc69024"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"502a9d0cef7f135ffccffe26c101b1db643d0348","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        if os.path.exists(parameter):"},{"line_number":123,"context_line":"            with open(parameter, \u0027w\u0027) as f:"},{"line_number":124,"context_line":"                f.write(value)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"@privsep.vif_plug.entrypoint"},{"line_number":128,"context_line":"def ensure_bridge(bridge):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_fc9eae61","line":125,"updated":"2019-04-24 12:38:00.000000000","message":"+1","commit_id":"c8ff51cea9c1eba422199d41cafa085aa7ff0f6a"}]}