)]}'
{".zuul.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"72a61a6fc78539a0eff32f9b75b616bb58b41e31","unresolved":false,"context_lines":[{"line_number":42,"context_line":"- job:"},{"line_number":43,"context_line":"    name: os-vif-ovs"},{"line_number":44,"context_line":"    parent: os-vif-tempest-base"},{"line_number":45,"context_line":"    run: playbooks/os-vif-ovs/run.yaml"},{"line_number":46,"context_line":"    post-run: playbooks/os-vif-ovs/post.yaml"},{"line_number":47,"context_line":"    timeout: 7800"},{"line_number":48,"context_line":"    description: |"},{"line_number":49,"context_line":"      os-vif ovs job with ovs firewall dirver"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_abd378d2","line":46,"range":{"start_line":45,"start_character":2,"end_line":46,"end_character":44},"updated":"2020-01-08 21:17:07.000000000","message":"oh i forgot to remove this","commit_id":"3db185b200c45ab6fe9c8a2babce070dc401c65b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c7676cd78815d4cba2d40a72760741c54c7a7f5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    parent: os-vif-tempest-base"},{"line_number":45,"context_line":"    timeout: 7800"},{"line_number":46,"context_line":"    description: |"},{"line_number":47,"context_line":"      os-vif ovs job with ovs firewall dirver"},{"line_number":48,"context_line":"    vars:"},{"line_number":49,"context_line":"      # TODO(sean-k-mooney): this will execute more test cases than we"},{"line_number":50,"context_line":"      # actually need to validate this configuration. Reduce this to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_278e9733","line":47,"range":{"start_line":47,"start_character":39,"end_line":47,"end_character":45},"updated":"2020-01-14 14:01:39.000000000","message":"driver","commit_id":"48a506b91c1d7aadcf8b49702e12362465605c2a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c7676cd78815d4cba2d40a72760741c54c7a7f5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      tox_envlist: full"},{"line_number":53,"context_line":"      devstack_local_conf:"},{"line_number":54,"context_line":"        post-config:"},{"line_number":55,"context_line":"          $NEUTRON_CONF:"},{"line_number":56,"context_line":"            QUOTAS:"},{"line_number":57,"context_line":"              quota_router: 100"},{"line_number":58,"context_line":"              quota_floatingip: 500"},{"line_number":59,"context_line":"              quota_security_group: 100"},{"line_number":60,"context_line":"              quota_security_group_rule: 1000"},{"line_number":61,"context_line":"          # NOTE(slaweq): We can get rid of this hardcoded absolute path when"},{"line_number":62,"context_line":"          # devstack-tempest job will be switched to use lib/neutron instead of"},{"line_number":63,"context_line":"          # lib/neutron-legacy"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_8782ebfe","line":60,"range":{"start_line":55,"start_character":0,"end_line":60,"end_character":45},"updated":"2020-01-14 14:01:39.000000000","message":"Can you add a comment for why this is here?","commit_id":"48a506b91c1d7aadcf8b49702e12362465605c2a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"42e1488b89179701ee6c56d76c3598cff3dddb94","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      tox_envlist: full"},{"line_number":53,"context_line":"      devstack_local_conf:"},{"line_number":54,"context_line":"        post-config:"},{"line_number":55,"context_line":"          $NEUTRON_CONF:"},{"line_number":56,"context_line":"            QUOTAS:"},{"line_number":57,"context_line":"              quota_router: 100"},{"line_number":58,"context_line":"              quota_floatingip: 500"},{"line_number":59,"context_line":"              quota_security_group: 100"},{"line_number":60,"context_line":"              quota_security_group_rule: 1000"},{"line_number":61,"context_line":"          # NOTE(slaweq): We can get rid of this hardcoded absolute path when"},{"line_number":62,"context_line":"          # devstack-tempest job will be switched to use lib/neutron instead of"},{"line_number":63,"context_line":"          # lib/neutron-legacy"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_a7b7e788","line":60,"range":{"start_line":55,"start_character":0,"end_line":60,"end_character":45},"in_reply_to":"3fa7e38b_8782ebfe","updated":"2020-01-14 14:10:01.000000000","message":"actully this was just done in the neutron job so i kept it\n\ni dont think its actully needed so i could drop it","commit_id":"48a506b91c1d7aadcf8b49702e12362465605c2a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c7676cd78815d4cba2d40a72760741c54c7a7f5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"              quota_security_group: 100"},{"line_number":60,"context_line":"              quota_security_group_rule: 1000"},{"line_number":61,"context_line":"          # NOTE(slaweq): We can get rid of this hardcoded absolute path when"},{"line_number":62,"context_line":"          # devstack-tempest job will be switched to use lib/neutron instead of"},{"line_number":63,"context_line":"          # lib/neutron-legacy"},{"line_number":64,"context_line":"          \"/$NEUTRON_CORE_PLUGIN_CONF\":"},{"line_number":65,"context_line":"            ml2_type_vlan:"},{"line_number":66,"context_line":"              network_vlan_ranges: foo:1:10"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_076efb63","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":30},"updated":"2020-01-14 14:01:39.000000000","message":"unrelated, but I saw a mail on openstack-discuss suggesting this might never happen since lib/neutron still doesn\u0027t have feature parity","commit_id":"48a506b91c1d7aadcf8b49702e12362465605c2a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"42e1488b89179701ee6c56d76c3598cff3dddb94","unresolved":false,"context_lines":[{"line_number":59,"context_line":"              quota_security_group: 100"},{"line_number":60,"context_line":"              quota_security_group_rule: 1000"},{"line_number":61,"context_line":"          # NOTE(slaweq): We can get rid of this hardcoded absolute path when"},{"line_number":62,"context_line":"          # devstack-tempest job will be switched to use lib/neutron instead of"},{"line_number":63,"context_line":"          # lib/neutron-legacy"},{"line_number":64,"context_line":"          \"/$NEUTRON_CORE_PLUGIN_CONF\":"},{"line_number":65,"context_line":"            ml2_type_vlan:"},{"line_number":66,"context_line":"              network_vlan_ranges: foo:1:10"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_47a87320","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":30},"in_reply_to":"3fa7e38b_076efb63","updated":"2020-01-14 14:10:01.000000000","message":"oh good to know.\ni kind of hope it does not get droped as networking-ovs-dpdk uses neutron-legacy well one function form it at least.","commit_id":"48a506b91c1d7aadcf8b49702e12362465605c2a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c7676cd78815d4cba2d40a72760741c54c7a7f5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"              provider_vlans: foo,"},{"line_number":83,"context_line":"              agent_availability_zone: nova"},{"line_number":84,"context_line":"              image_is_advanced: true"},{"line_number":85,"context_line":"              available_type_drivers: flat,geneve,vlan,gre,local,vxlan"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- job:"},{"line_number":88,"context_line":"    name: os-vif-ovs-iptables"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_c7778307","line":85,"updated":"2020-01-14 14:01:39.000000000","message":"comments on all these would be A+\n\nAlso, this looks almost identical to the below test. Any chance we could use a base job and just do the individual overrides?","commit_id":"48a506b91c1d7aadcf8b49702e12362465605c2a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"42e1488b89179701ee6c56d76c3598cff3dddb94","unresolved":false,"context_lines":[{"line_number":82,"context_line":"              provider_vlans: foo,"},{"line_number":83,"context_line":"              agent_availability_zone: nova"},{"line_number":84,"context_line":"              image_is_advanced: true"},{"line_number":85,"context_line":"              available_type_drivers: flat,geneve,vlan,gre,local,vxlan"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- job:"},{"line_number":88,"context_line":"    name: os-vif-ovs-iptables"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_67348ffb","line":85,"in_reply_to":"3fa7e38b_c7778307","updated":"2020-01-14 14:10:01.000000000","message":"i was thinking about that and i would prefer to try and shorten this in a separate follow up patch.\n\ni had started to work on a follow up in https://review.opendev.org/#/c/701607/2 but it actully was slower but the other thing i wanted to do was pull out the common config","commit_id":"48a506b91c1d7aadcf8b49702e12362465605c2a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c7676cd78815d4cba2d40a72760741c54c7a7f5","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    parent: os-vif-tempest-base"},{"line_number":90,"context_line":"    timeout: 10800"},{"line_number":91,"context_line":"    description: |"},{"line_number":92,"context_line":"      os-vif iptables job derived from neutron-tempest-iptables_hybrid"},{"line_number":93,"context_line":"    vars:"},{"line_number":94,"context_line":"      # TODO(sean-k-mooney): this will execute more test cases than we"},{"line_number":95,"context_line":"      # actually need to validate this configuration. Reduce this to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_474cf3c8","line":92,"updated":"2020-01-14 14:01:39.000000000","message":"It\u0027s not really related (unless you use a base test) but a better description of this would help (me) contrast the two jobs","commit_id":"48a506b91c1d7aadcf8b49702e12362465605c2a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"42e1488b89179701ee6c56d76c3598cff3dddb94","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    parent: os-vif-tempest-base"},{"line_number":90,"context_line":"    timeout: 10800"},{"line_number":91,"context_line":"    description: |"},{"line_number":92,"context_line":"      os-vif iptables job derived from neutron-tempest-iptables_hybrid"},{"line_number":93,"context_line":"    vars:"},{"line_number":94,"context_line":"      # TODO(sean-k-mooney): this will execute more test cases than we"},{"line_number":95,"context_line":"      # actually need to validate this configuration. Reduce this to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4704f319","line":92,"in_reply_to":"3fa7e38b_474cf3c8","updated":"2020-01-14 14:10:01.000000000","message":"the only difference is this one use the ip tabeles firewall driver and hybrid plug strategy where as the other job uses the ovs contrack driver and does not use hybrid plug.\n\nthis takes different code paths in os-vif as one adds the port to ovs and the other to the intermediate Linux bridge.","commit_id":"48a506b91c1d7aadcf8b49702e12362465605c2a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4d8851ddead0c61b336327579ec53e54e0b72fc0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"          $NEUTRON_DHCP_CONF:"},{"line_number":56,"context_line":"            agent:"},{"line_number":57,"context_line":"              availability_zone: nova"},{"line_number":58,"context_line":"          \"/$NEUTRON_CORE_PLUGIN_CONF\":"},{"line_number":59,"context_line":"            ml2_type_vlan:"},{"line_number":60,"context_line":"              network_vlan_ranges: foo:1:10"},{"line_number":61,"context_line":"            agent:"},{"line_number":62,"context_line":"              enable_distributed_routing: true"},{"line_number":63,"context_line":"              l2_population: true"},{"line_number":64,"context_line":"              tunnel_types: vxlan,gre"},{"line_number":65,"context_line":"        test-config:"},{"line_number":66,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":67,"context_line":"            neutron_plugin_options:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_dbda7b74","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":37},"updated":"2020-01-22 17:42:17.000000000","message":"I guess you could drop this now since you uniquely define it below?","commit_id":"1ed44bd400fc8adb83438083d376658f27205373"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3ade404d98d4df0e2e5402cf90ee97adecb3c937","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    vars:"},{"line_number":79,"context_line":"      devstack_local_conf:"},{"line_number":80,"context_line":"        post-config:"},{"line_number":81,"context_line":"          # NOTE(sean-k-mooney): i do not believe that the devstack role"},{"line_number":82,"context_line":"          # will merge the base /$NEUTRON_CORE_PLUGIN_CONF with the parent"},{"line_number":83,"context_line":"          # job so we redefine the entire section"},{"line_number":84,"context_line":"          \"/$NEUTRON_CORE_PLUGIN_CONF\":"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_176d49ca","line":81,"updated":"2020-01-22 15:11:30.000000000","message":"The zuul.model.Job class has a method to update the vars from other jobs, called in \"applyVariant\". This method \"Copy the attributes which have been set on the other job to this job\".\n\nYou can try...","commit_id":"1ed44bd400fc8adb83438083d376658f27205373"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5b29a7e6850aaee051adeabe09f84fe27137ba5c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    vars:"},{"line_number":79,"context_line":"      devstack_local_conf:"},{"line_number":80,"context_line":"        post-config:"},{"line_number":81,"context_line":"          # NOTE(sean-k-mooney): i do not believe that the devstack role"},{"line_number":82,"context_line":"          # will merge the base /$NEUTRON_CORE_PLUGIN_CONF with the parent"},{"line_number":83,"context_line":"          # job so we redefine the entire section"},{"line_number":84,"context_line":"          \"/$NEUTRON_CORE_PLUGIN_CONF\":"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_5b6c4bce","line":81,"in_reply_to":"3fa7e38b_176d49ca","updated":"2020-01-22 17:34:05.000000000","message":"i might change this is a follow up but i want to merge this quickly to enable us to revert the next patch.\n\ni will be doing more job changes in the next week or so so ill look into this in more detail then and see if i can override just the section that is relevant.","commit_id":"1ed44bd400fc8adb83438083d376658f27205373"}]}