)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0e1fe654b49a1ba51b3e9e77ec804a080e7bcf1c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"trivial: Remove some rules from flake8 ignore list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Most of these were either unnecessary or trivial to resolve."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2952e4906a511f6ffc6c53dc1c582464000e22de"},{"line_number":12,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_611fe4b6","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":60},"updated":"2020-03-31 16:32:50.000000000","message":"sure but that does not mean we should jsut enable them.","commit_id":"ba9d4ca9561356a34077fe435fb4e9855625d072"}],"vif_plug_linux_bridge/tests/unit/test_linux_net.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3aa44ab12ac8379f3af8b0fc218efe42385c4490","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        calls \u003d [mock.call(\u0027fake-interface\u0027, 1500),"},{"line_number":131,"context_line":"                 mock.call(\u0027fake-bridge\u0027, 1500)]"},{"line_number":132,"context_line":"        mock_set_mtu.assert_has_calls(calls)"},{"line_number":133,"context_line":"        calls \u003d [mock.call(\u0027fake-bridge\u0027, state\u003d\u0027up\u0027),"},{"line_number":134,"context_line":"                 mock.call(\u0027fake-interface\u0027, master\u003d\u0027fake-bridge\u0027, state\u003d\u0027up\u0027,"},{"line_number":135,"context_line":"                 check_exit_code\u003d[0, 2, 254])]"},{"line_number":136,"context_line":"        mock_ip_set.assert_has_calls(calls)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_e143f46a","line":133,"range":{"start_line":133,"start_character":39,"end_line":133,"end_character":54},"updated":"2020-03-31 16:41:58.000000000","message":"this is better in terms of readablity sice we can use the convention that if there is no space around the \u003d then it is used as a keyword arg.","commit_id":"ba9d4ca9561356a34077fe435fb4e9855625d072"}],"vif_plug_ovs/ovs.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0e1fe654b49a1ba51b3e9e77ec804a080e7bcf1c","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def describe(self):"},{"line_number":102,"context_line":"        pp_ovs \u003d objects.host_info.HostPortProfileInfo("},{"line_number":103,"context_line":"            profile_object_name\u003dobjects.vif.VIFPortProfileOpenVSwitch.__name__,  # noqa"},{"line_number":104,"context_line":"            min_version\u003d\"1.0\","},{"line_number":105,"context_line":"            max_version\u003d\"1.0\","},{"line_number":106,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_4171000c","line":103,"updated":"2020-03-31 16:32:50.000000000","message":"this is arguable worse since we are add #noqa","commit_id":"ba9d4ca9561356a34077fe435fb4e9855625d072"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0ff461c36618458696dafd1a4ed1e34ac4c40ca1","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def describe(self):"},{"line_number":102,"context_line":"        pp_ovs \u003d objects.host_info.HostPortProfileInfo("},{"line_number":103,"context_line":"            profile_object_name\u003dobjects.vif.VIFPortProfileOpenVSwitch.__name__,  # noqa"},{"line_number":104,"context_line":"            min_version\u003d\"1.0\","},{"line_number":105,"context_line":"            max_version\u003d\"1.0\","},{"line_number":106,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_a1bf2c5f","line":103,"in_reply_to":"df33271e_4171000c","updated":"2020-03-31 16:39:56.000000000","message":"Hardly? noqa is a suitable resolution to flake8\u0027s overly strict line length checking. The alternative is silly line wrapping that\u0027s tougher to read, IMO. I\u0027d prefer if flake8 had this flexibility built in so that it behaved like bugbear\u0027s B950 but alas, nope\n\n[1] https://github.com/PyCQA/flake8-bugbear","commit_id":"ba9d4ca9561356a34077fe435fb4e9855625d072"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3aa44ab12ac8379f3af8b0fc218efe42385c4490","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def describe(self):"},{"line_number":102,"context_line":"        pp_ovs \u003d objects.host_info.HostPortProfileInfo("},{"line_number":103,"context_line":"            profile_object_name\u003dobjects.vif.VIFPortProfileOpenVSwitch.__name__,  # noqa"},{"line_number":104,"context_line":"            min_version\u003d\"1.0\","},{"line_number":105,"context_line":"            max_version\u003d\"1.0\","},{"line_number":106,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_816948fa","line":103,"in_reply_to":"df33271e_4171000c","updated":"2020-03-31 16:41:58.000000000","message":"if your going to do this pull the class name out into another variable and use it here and below.\nthat will remvoe the need for the # noqa","commit_id":"ba9d4ca9561356a34077fe435fb4e9855625d072"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6f02dfacbc5bf7ec81a1f133cccb665ece6795e","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def describe(self):"},{"line_number":102,"context_line":"        pp_ovs \u003d objects.host_info.HostPortProfileInfo("},{"line_number":103,"context_line":"            profile_object_name\u003dobjects.vif.VIFPortProfileOpenVSwitch.__name__,  # noqa"},{"line_number":104,"context_line":"            min_version\u003d\"1.0\","},{"line_number":105,"context_line":"            max_version\u003d\"1.0\","},{"line_number":106,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_104c6040","line":103,"in_reply_to":"df33271e_a1bf2c5f","updated":"2020-03-31 20:06:49.000000000","message":"i would be ok with swapping to that.","commit_id":"ba9d4ca9561356a34077fe435fb4e9855625d072"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0e1fe654b49a1ba51b3e9e77ec804a080e7bcf1c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            max_version\u003d\"1.0\","},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        pp_ovs_representor \u003d objects.host_info.HostPortProfileInfo("},{"line_number":108,"context_line":"            profile_object_name\u003dobjects.vif.VIFPortProfileOVSRepresentor.__name__,  # noqa"},{"line_number":109,"context_line":"            min_version\u003d\"1.0\","},{"line_number":110,"context_line":"            max_version\u003d\"1.0\","},{"line_number":111,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_8168281d","line":108,"range":{"start_line":108,"start_character":86,"end_line":108,"end_character":90},"updated":"2020-03-31 16:32:50.000000000","message":"here we are also not breaking the line lenght.","commit_id":"ba9d4ca9561356a34077fe435fb4e9855625d072"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"c51cb89395322a3c75b3e5c7016921517ccfc12c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            max_version\u003d\"1.0\","},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        pp_ovs_representor \u003d objects.host_info.HostPortProfileInfo("},{"line_number":108,"context_line":"            profile_object_name\u003dobjects.vif.VIFPortProfileOVSRepresentor.__name__,  # noqa"},{"line_number":109,"context_line":"            min_version\u003d\"1.0\","},{"line_number":110,"context_line":"            max_version\u003d\"1.0\","},{"line_number":111,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_a400da02","line":108,"range":{"start_line":108,"start_character":86,"end_line":108,"end_character":90},"in_reply_to":"df33271e_2105dc46","updated":"2020-03-31 16:48:13.000000000","message":"As one of the perpetrators of the naming of this object, yeah, I kinda hate the run-on-name. I don\u0027t object to #noqa or the temporary variable.","commit_id":"ba9d4ca9561356a34077fe435fb4e9855625d072"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0ff461c36618458696dafd1a4ed1e34ac4c40ca1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            max_version\u003d\"1.0\","},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        pp_ovs_representor \u003d objects.host_info.HostPortProfileInfo("},{"line_number":108,"context_line":"            profile_object_name\u003dobjects.vif.VIFPortProfileOVSRepresentor.__name__,  # noqa"},{"line_number":109,"context_line":"            min_version\u003d\"1.0\","},{"line_number":110,"context_line":"            max_version\u003d\"1.0\","},{"line_number":111,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_2105dc46","line":108,"range":{"start_line":108,"start_character":86,"end_line":108,"end_character":90},"in_reply_to":"df33271e_8168281d","updated":"2020-03-31 16:39:56.000000000","message":"We are, unfortunately","commit_id":"ba9d4ca9561356a34077fe435fb4e9855625d072"}]}