)]}'
{"doc/source/contributor/contributing.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6d310e94c8931961d83b453a995c803f8548b745","unresolved":false,"context_lines":[{"line_number":25,"context_line":"New Feature Planning"},{"line_number":26,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"os-vif does not track feature planning."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Task Tracking"},{"line_number":31,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_035f2972","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":39},"updated":"2020-04-27 13:41:48.000000000","message":"actually we do although more informally \n\nyou are meant to file an RFE bug if it has no interaction with other projects or file a spec with nova or nueton if it requires changes in those project for the new feature to used.\n\nwhere a feature is being tracked as part of a nova or neutron change you should use the same topic to track the os-vif work in gerrit","commit_id":"76595a3bfe38601e566bfaa43b13995a57bd20bd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9851bc3496edd358ab25e00b0d086c51d1eaebf5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"New Feature Planning"},{"line_number":26,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"os-vif does not track feature planning."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Task Tracking"},{"line_number":31,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_da914054","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":39},"in_reply_to":"1f493fa4_035f2972","updated":"2020-04-30 21:27:14.000000000","message":"i see, This is good info to mention here. done","commit_id":"76595a3bfe38601e566bfaa43b13995a57bd20bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6d310e94c8931961d83b453a995c803f8548b745","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Getting Your Patch Merged"},{"line_number":47,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"All changes proposed to the os-vif requires two ``Code-Review +2`` votes from"},{"line_number":50,"context_line":"os-vif core reviewers before one of the core reviewers can approve patch by"},{"line_number":51,"context_line":"giving ``Workflow +1`` vote."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_630f0d37","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":28},"updated":"2020-04-27 13:41:48.000000000","message":"also we technically we don\u0027t have this requirement for all changes. trivial changes can be approved by a single core if its just fixing a typo or similar and we do not require that the author and approver be different.\n\ne.g. if a core submits a patch and its +2\u0027d by another core then they can be the second +2 +w but in general in that case the core that wrote the patch should first ping people on irc to review an wait a few days after the initial +2 before merging to give time to other cores to review.\n\ngetting 2 other cores to review a change by a third core has been slightly less of an issue since we expanded the team but for a long time it was very hard to do as there were only 2 active cores reviewing.","commit_id":"76595a3bfe38601e566bfaa43b13995a57bd20bd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9851bc3496edd358ab25e00b0d086c51d1eaebf5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Getting Your Patch Merged"},{"line_number":47,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"All changes proposed to the os-vif requires two ``Code-Review +2`` votes from"},{"line_number":50,"context_line":"os-vif core reviewers before one of the core reviewers can approve patch by"},{"line_number":51,"context_line":"giving ``Workflow +1`` vote."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_5a8ff028","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":28},"in_reply_to":"1f493fa4_630f0d37","updated":"2020-04-30 21:27:14.000000000","message":"ok, I can mention the trivial patches things. But core author part is fine as this doc is mainly for new people to know what is usual process of this team. Core anyways know the process.","commit_id":"76595a3bfe38601e566bfaa43b13995a57bd20bd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fa5b91b4fb8921c1f6fed738f948b8c0de8ef762","unresolved":false,"context_lines":[{"line_number":26,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"You can file an RFE `bug \u003chttps://bugs.launchpad.net/os-vif/+filebug\u003e`_ if it"},{"line_number":29,"context_line":"has no interaction with other projects like nova or neutron. "},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"If changes are part of the nova or neutron feature then it is being tracked"},{"line_number":32,"context_line":"as part of the nova or neutron feature. In that case, you should use the same topic"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f493fa4_dad780be","line":29,"range":{"start_line":29,"start_character":60,"end_line":29,"end_character":61},"updated":"2020-04-30 21:45:35.000000000","message":"extra space","commit_id":"343aa1517a89aef8ed5378c7060a30af0d6b2438"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fa5b91b4fb8921c1f6fed738f948b8c0de8ef762","unresolved":false,"context_lines":[{"line_number":28,"context_line":"You can file an RFE `bug \u003chttps://bugs.launchpad.net/os-vif/+filebug\u003e`_ if it"},{"line_number":29,"context_line":"has no interaction with other projects like nova or neutron. "},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"If changes are part of the nova or neutron feature then it is being tracked"},{"line_number":32,"context_line":"as part of the nova or neutron feature. In that case, you should use the same topic"},{"line_number":33,"context_line":"to track the os-vif changes."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f493fa4_1ade08d9","line":31,"range":{"start_line":31,"start_character":59,"end_line":31,"end_character":67},"updated":"2020-04-30 21:45:35.000000000","message":"nit: can be","commit_id":"343aa1517a89aef8ed5378c7060a30af0d6b2438"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fa5b91b4fb8921c1f6fed738f948b8c0de8ef762","unresolved":false,"context_lines":[{"line_number":29,"context_line":"has no interaction with other projects like nova or neutron. "},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"If changes are part of the nova or neutron feature then it is being tracked"},{"line_number":32,"context_line":"as part of the nova or neutron feature. In that case, you should use the same topic"},{"line_number":33,"context_line":"to track the os-vif changes."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Task Tracking"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f493fa4_7af2ac71","line":32,"range":{"start_line":32,"start_character":78,"end_line":32,"end_character":83},"updated":"2020-04-30 21:45:35.000000000","message":"nit: not sure if sphinx care about line lenght but you could wrap this.","commit_id":"343aa1517a89aef8ed5378c7060a30af0d6b2438"}]}