)]}'
{"lower-constraints.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"782b700f131e9e9bde720154fbfeb654168c3310","unresolved":false,"context_lines":[{"line_number":29,"context_line":"mccabe\u003d\u003d0.2.1"},{"line_number":30,"context_line":"mock\u003d\u003d2.0.0"},{"line_number":31,"context_line":"monotonic\u003d\u003d1.4"},{"line_number":32,"context_line":"mox3\u003d\u003d0.20.0"},{"line_number":33,"context_line":"msgpack-python\u003d\u003d0.4.0"},{"line_number":34,"context_line":"msgpack\u003d\u003d0.5.6"},{"line_number":35,"context_line":"netaddr\u003d\u003d0.7.18"}],"source_content_type":"text/plain","patch_set":1,"id":"1f493fa4_77453415","side":"PARENT","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":12},"updated":"2020-05-07 14:49:54.000000000","message":"i dont think we ever used mox actully mayhbe very very early on but i think this is just left over from nova so yep good to remove.","commit_id":"222e2866615e65ece5a1575326e082bb75c5b544"}],"os_vif/tests/unit/test_base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"782b700f131e9e9bde720154fbfeb654168c3310","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_serialization import jsonutils"},{"line_number":17,"context_line":"from oslo_versionedobjects import base"},{"line_number":18,"context_line":"from oslo_versionedobjects import fields"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from os_vif.objects import base as osv_base"},{"line_number":22,"context_line":"from os_vif.tests.unit import base as test_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_575ab8f2","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":10},"updated":"2020-05-07 14:49:54.000000000","message":"nits this is incorrect six shoudl not have been moved.\n\nthis is going to conflict with the six removal patch unless they are based on each other.","commit_id":"bbcb54e7f73da60251bb5f9446c8ce83530f50e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0886c9b9d53c0e6244695850d68737f8b11ad605","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from oslo_serialization import jsonutils"},{"line_number":17,"context_line":"from oslo_versionedobjects import base"},{"line_number":18,"context_line":"from oslo_versionedobjects import fields"},{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from os_vif.objects import base as osv_base"},{"line_number":22,"context_line":"from os_vif.tests.unit import base as test_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_dd1b8718","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":10},"in_reply_to":"1f493fa4_575ab8f2","updated":"2020-05-07 16:04:26.000000000","message":"It should have been moved since it\u0027s not a first party library. You are correct in suggesting it will conflict, but since Takashi is authoring both I don\u0027t think that\u0027s an issue :)","commit_id":"bbcb54e7f73da60251bb5f9446c8ce83530f50e9"}],"vif_plug_linux_bridge/tests/unit/test_linux_net.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"782b700f131e9e9bde720154fbfeb654168c3310","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from unittest import mock"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import fixtures"},{"line_number":16,"context_line":"from os_vif.internal.ip.api import ip as ip_lib"},{"line_number":17,"context_line":"from oslo_concurrency import lockutils"},{"line_number":18,"context_line":"from oslo_concurrency import processutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_172e7042","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":15},"updated":"2020-05-07 14:49:54.000000000","message":"this is wrong too","commit_id":"bbcb54e7f73da60251bb5f9446c8ce83530f50e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0886c9b9d53c0e6244695850d68737f8b11ad605","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from unittest import mock"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import fixtures"},{"line_number":16,"context_line":"from os_vif.internal.ip.api import ip as ip_lib"},{"line_number":17,"context_line":"from oslo_concurrency import lockutils"},{"line_number":18,"context_line":"from oslo_concurrency import processutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_bd167bf0","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":15},"in_reply_to":"1f493fa4_172e7042","updated":"2020-05-07 16:04:26.000000000","message":"No, it\u0027s correct. This isn\u0027t stdlib.","commit_id":"bbcb54e7f73da60251bb5f9446c8ce83530f50e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"782b700f131e9e9bde720154fbfeb654168c3310","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_config import fixture as config_fixture"},{"line_number":21,"context_line":"from oslo_log.fixture import logging_error as log_fixture"},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from vif_plug_linux_bridge import linux_net"},{"line_number":25,"context_line":"from vif_plug_linux_bridge import privsep"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_17a150aa","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":16},"updated":"2020-05-07 14:49:54.000000000","message":"again this is wrong\n\n\nthe import groups we shoul be using are\n\nimports from standard library\n\nfrom standard library import\n\nimports form third party libs\n\nfrom third party libs import\n\nimport from other openstack projects\n\nfrom other openstack projects import\n\nimport os_vif.X\n\nfrom os_vif import x\n\n\nif your going to update this pleas format them correctly.","commit_id":"bbcb54e7f73da60251bb5f9446c8ce83530f50e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0886c9b9d53c0e6244695850d68737f8b11ad605","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_config import fixture as config_fixture"},{"line_number":21,"context_line":"from oslo_log.fixture import logging_error as log_fixture"},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from vif_plug_linux_bridge import linux_net"},{"line_number":25,"context_line":"from vif_plug_linux_bridge import privsep"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_3db9cbe8","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":16},"in_reply_to":"1f493fa4_17a150aa","updated":"2020-05-07 16:04:26.000000000","message":"Afraid not. It\u0027s actually.\n\n  imports from stdlib\n\n  imports from third-party libraries\n\n  imports from self\n\nYou\u0027re also free to intermingle \u0027import foo\u0027 and \u0027from foo import bar\u0027 functions. We alphabetically order them by full import path [1], so \u0027from foo import bar\u0027 should come after \u0027import foo\u0027, because \u0027foo.bar\u0027 \u003e \u0027foo\u0027.\n\ntesttools is third party btw.\n\n[1] https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"bbcb54e7f73da60251bb5f9446c8ce83530f50e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"29376216c36c546d58e7a0ccd38cdf87a52d978f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_config import fixture as config_fixture"},{"line_number":21,"context_line":"from oslo_log.fixture import logging_error as log_fixture"},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from vif_plug_linux_bridge import linux_net"},{"line_number":25,"context_line":"from vif_plug_linux_bridge import privsep"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_ab6915bf","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":16},"in_reply_to":"1f493fa4_3db9cbe8","updated":"2020-05-07 17:14:14.000000000","message":"then hacking is wrong that is not the convention we have been using and i am not ok with mixing them because it breaks so many tools in different ide that fight with it.","commit_id":"bbcb54e7f73da60251bb5f9446c8ce83530f50e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"99fb8faad683a3cf769e9b4421001f752af183ea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_config import fixture as config_fixture"},{"line_number":21,"context_line":"from oslo_log.fixture import logging_error as log_fixture"},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from vif_plug_linux_bridge import linux_net"},{"line_number":25,"context_line":"from vif_plug_linux_bridge import privsep"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_ef131bb7","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":16},"in_reply_to":"1f493fa4_455af5f2","updated":"2020-05-08 12:47:43.000000000","message":"as far as i am concerned hacking what hacking allows is a superset of what we want in os-vif.\n\nim not going to -2 over this but i am not ok with mixing from and import in the same block.\n\nif fix that in every file i edit because its is really hard to parse what order they shoudl be in when there is a mix.\ni have literally wasted the 10 or more on a patch reordering imports to get it to pass when they have been mixed so i dont do that ever any more i always split them.\n\nthe scheme i am asking for is still allowed by hacking as i use it in os-vif and nova every time i write a patch\n\ni dont really want to have to go write a custome hacking check to enforece no mixing as i woudl have to learn how hacking works but if i need too i will.\n\ni just review for this pattern and call out any instance were its mixed.","commit_id":"bbcb54e7f73da60251bb5f9446c8ce83530f50e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b052697dc31a44acf4b29a056ab5f4c9f6adfa21","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_config import fixture as config_fixture"},{"line_number":21,"context_line":"from oslo_log.fixture import logging_error as log_fixture"},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from vif_plug_linux_bridge import linux_net"},{"line_number":25,"context_line":"from vif_plug_linux_bridge import privsep"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_455af5f2","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":16},"in_reply_to":"1f493fa4_ab6915bf","updated":"2020-05-08 09:25:09.000000000","message":"Perhaps, but it\u0027s been that way for years and modifying it now would require massive changes across almost every project in OpenStack. Alternatively, you could configure your IDE to use hacking in addition to flake8, or simply disable that check","commit_id":"bbcb54e7f73da60251bb5f9446c8ce83530f50e9"}]}